https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43401 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #11 from David Cook <dcook@prosentient.com.au> --- (In reply to Paul Derscheid from comment #7)
Test plan: 1. In a KTD shell, from the koha checkout: perl Makefile.PL (accept the defaults, 'standard' install mode is fine)
I'd prefer "single" with an install dir of /opt/koha, but sure.
2. make -n move_compiled_js | grep 'js/vue/dist' => without this patch only the intranet cp line is printed; with it there is also a line copying koha-tmpl/opac-tmpl/bootstrap/js/vue/dist into blib/OPAC_TMPL_DIR/bootstrap/js/vue/
So that's a problem because we're trying to find it in "js/vue/dist": grep -R "/vue/dist" /opt/koha/opac/htdocs/opac-tmpl/* --exclude="*.min.js*" --exclude="*.map*" /opt/koha/opac/htdocs/opac-tmpl/bootstrap/en/modules/opac-user.tt:[% SET islands = Asset.js("js/vue/dist/islands.esm.js").match('(src="([^"]+)")').1 %]
3. make 4. ls blib/INTRANET_TMPL_DIR/prog/js/vue/dist blib/OPAC_TMPL_DIR/bootstrap/js/vue/dist => both directories exist and contain the compiled bundles (e.g. islands.esm.js); no vue/dist directory is left anywhere else under blib.
But both directories don't exist: kohadev-koha@kohadevbox:koha(bug_43401)$ ls blib/INTRANET_TMPL_DIR/prog/js/vue/dist acquisitions.js admin-menu.40c7c23d28770ef8.esm.js ill.js.map sip2.js acquisitions.js.map admin-menu.40c7c23d28770ef8.esm.js.map islands.esm.js sip2.js.map acquisitions-menu.c09a1c8d56bf1c61.js admin-menu.699a618ebbcdea9b.js islands.esm.js.map vendor-menu.ca0b96e230ffffb2.js acquisitions-menu.c09a1c8d56bf1c61.js.map admin-menu.699a618ebbcdea9b.js.map islands.js vendor-menu.ca0b96e230ffffb2.js.map acquisitions-menu.c9a796d3a4310bd7.esm.js erm.js islands.js.map vendor-menu.f9089946d9ea2fb9.esm.js acquisitions-menu.c9a796d3a4310bd7.esm.js.map erm.js.map preservation.js vendor-menu.f9089946d9ea2fb9.esm.js.map admin ill.js preservation.js.map kohadev-koha@kohadevbox:koha(bug_43401)$ ls blib/OPAC_TMPL_DIR/bootstrap/js/vue/ islands.esm.js islands.esm.js.map patron-self-renewal.d9bbd0b66f921f5d.esm.js patron-self-renewal.d9bbd0b66f921f5d.esm.js.map The "/dist" is being dropped for the OPAC. -- You are receiving this mail because: You are watching all bug changes.