[Bug 18589] New: Show ILLs as part of patron profile
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 Bug ID: 18589 Summary: Show ILLs as part of patron profile Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: magnus@libriotech.no QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Bug 7317 adds a "Interlibrary loans" tab on the left hand side of patron details, under Purchase suggestions. But this behaves more like a link than a tab, taking you to the ILL module and a list limited to the patron in question. It would be better if this view looked more like a part of the patron details, with the tabs on the left hand side and the buttons on top. Compare this to the "Modification log" tab/link, which actually takes you to the log "module", but still looks like part of the patron profile. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |7317 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |20536 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20536 [Bug 20536] ILL: authnotrequired not explicitly unset -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|20536 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20536 [Bug 20536] ILL: authnotrequired not explicitly unset -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |andrew.isherwood@ptfs-europ | |e.com Assignee|koha-bugs@lists.koha-commun |andrew.isherwood@ptfs-europ |ity.org |e.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 --- Comment #1 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 74809 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74809&action=edit Bug 18589: Show ILLs as part of patron profile This patch moves the display of a patron's ILL requests to be inline in the Patron Profile page, as per all other patron information. It includes a substantial refactor of koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt in that it moves the display of the illlist table (which is populated by an API request) into it's own separate include file. It also moves the datatable related Javascript for this table into it's own JS file. Doing this allows us to reuse both in both the new members/ill-requests.tt template and the pre-existing ill/ill-requests.tt template. To test: 1) Ensure ILL is enabled and your user has sufficient permissions 2) Ensure your user has some ILL requests 3) Navigate to the user's patron profile page 4) Click on the "Interlibrary loans" tab 5) Observe that the requests table is displayed inline 6) Observe that only your user's requests are displayed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |20548, 20600, 20581, 20563 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20548 [Bug 20548] Remove copyright clearance workflow from staff created ILL requests https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20563 [Bug 20563] ILL request list gives no indication of source and/or target https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581 [Bug 20581] Allow manual selection of custom ILL request statuses https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 [Bug 20600] Provide the ability for users to filter ILL requests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 --- Comment #2 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Dependencies have been added to reflect other pending patches that touch ill-requests.tt, which has been substantially refactored here -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|7317 | CC| |martin.renvoize@ptfs-europe | |.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |20651 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20651 [Bug 20651] Improve display of "Toggle full supplier metadata" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |20640 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20640 [Bug 20640] Allow migrating a request between backends -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 Niamh <niamh.walker-headon@it-tallaght.ie> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |niamh.walker-headon@it-tall | |aght.ie -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 Bug 18589 depends on bug 20651, which changed state. Bug 20651 Summary: Improve display of "Toggle full supplier metadata" https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20651 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |20996, 21377, 20772, 20750, | |20941, 20917, 20797, 20883, | |20770 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20750 [Bug 20750] Allow timestamped auditing of ILL request events https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20772 [Bug 20772] Bib metadata pertaining to an ILL request should be editable https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20797 [Bug 20797] If an Ill request has an associated bib record, the detail view should contain a link to the record https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20883 [Bug 20883] Patron userid should be exposed https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20917 [Bug 20917] Improve email functionality relating to ILL requests https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20941 [Bug 20941] Displaying requests does not display request material type https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20996 [Bug 20996] Fix API response time on ILL request endpoint https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21377 [Bug 21377] Variable declarations erroneously filtered -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 --- Comment #3 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Dependencies updated -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74809|0 |1 is obsolete| | --- Comment #4 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 79692 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79692&action=edit Bug 18589: Show ILLs as part of patron profile This patch moves the display of a patron's ILL requests to be inline in the Patron Profile page, as per all other patron information. It includes a substantial refactor of koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt in that it moves the display of the illlist table (which is populated by an API request) into it's own separate include file. It also moves the datatable related Javascript for this table into it's own JS file. Doing this allows us to reuse both in both the new members/ill-requests.tt template and the pre-existing ill/ill-requests.tt template. To test: 1) Ensure ILL is enabled and your user has sufficient permissions 2) Ensure your user has some ILL requests 3) Navigate to the user's patron profile page 4) Click on the "Interlibrary loans" tab 5) Observe that the requests table is displayed inline 6) Observe that only your user's requests are displayed Signed-off-by: Niamh.Walker-Headon@it-tallaght.ie -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 Bug 18589 depends on bug 21377, which changed state. Bug 21377 Summary: Variable declarations erroneously filtered https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21377 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|20772 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20772 [Bug 20772] Bib metadata pertaining to an ILL request should be editable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|20797 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20797 [Bug 20797] If an Ill request has an associated bib record, the detail view should contain a link to the record -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|21377 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21377 [Bug 21377] Variable declarations erroneously filtered -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|20651 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20651 [Bug 20651] Improve display of "Toggle full supplier metadata" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19605 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19605 [Bug 19605] ILL backends should be pluggable through regular Koha plugins -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 Bug 18589 depends on bug 20883, which changed state. Bug 20883 Summary: Display patron user id https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20883 What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|20548 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20548 [Bug 20548] Remove copyright clearance workflow from staff created ILL requests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|20640 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20640 [Bug 20640] Allow migrating a request between backends -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|20600 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 [Bug 20600] Provide the ability for users to filter ILL requests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|20581 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581 [Bug 20581] Allow manual selection of custom ILL request statuses -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|20750 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20750 [Bug 20750] Allow timestamped auditing of ILL request events -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|20770, 20917, 20941, 20996, | |20883 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20883 [Bug 20883] Display patron user id https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20917 [Bug 20917] Improve email functionality relating to ILL requests https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20941 [Bug 20941] Displaying requests does not display request material type https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20996 [Bug 20996] Fix API response time on ILL request endpoint -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Component|Circulation |ILL QA Contact|testopia@bugs.koha-communit | |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79692|0 |1 is obsolete| | --- Comment #5 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Comment on attachment 79692 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79692 Bug 18589: Show ILLs as part of patron profile Obsoleted by rebase upon current dependency tree -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 --- Comment #6 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 82177 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82177&action=edit Bug 18589: Show ILLs as part of patron profile This patch moves the display of a patron's ILL requests to be inline in the Patron Profile page, as per all other patron information. It includes a substantial refactor of koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt in that it moves the display of the illlist table (which is populated by an API request) into it's own separate include file. It also moves the datatable related Javascript for this table into it's own JS file. Doing this allows us to reuse both in both the new members/ill-requests.tt template and the pre-existing ill/ill-requests.tt template. To test: 1) Ensure ILL is enabled and your user has sufficient permissions 2) Ensure your user has some ILL requests 3) Navigate to the user's patron profile page 4) Click on the "Interlibrary loans" tab 5) Observe that the requests table is displayed inline 6) Observe that only your user's requests are displayed Signed-off-by: Niamh.Walker-Headon@it-tallaght.ie -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82177|0 |1 is obsolete| | --- Comment #7 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 82513 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82513&action=edit Bug 18589: Show ILLs as part of patron profile This patch moves the display of a patron's ILL requests to be inline in the Patron Profile page, as per all other patron information. It includes a substantial refactor of koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt in that it moves the display of the illlist table (which is populated by an API request) into it's own separate include file. It also moves the datatable related Javascript for this table into it's own JS file. Doing this allows us to reuse both in both the new members/ill-requests.tt template and the pre-existing ill/ill-requests.tt template. To test: 1) Ensure ILL is enabled and your user has sufficient permissions 2) Ensure your user has some ILL requests 3) Navigate to the user's patron profile page 4) Click on the "Interlibrary loans" tab 5) Observe that the requests table is displayed inline 6) Observe that only your user's requests are displayed Signed-off-by: Niamh.Walker-Headon@it-tallaght.ie -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=21460 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |21460 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21460 [Bug 21460] Filtering ILL requests on borrowernumber does not work -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 --- Comment #8 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 84197 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84197&action=edit Bug 18589: (follow-up) Fix QA error -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 --- Comment #9 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 84199 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84199&action=edit Bug 18589: (follow-up) Fix QA failure This patch removes the id and class attributes on the body tag in: koha-tmpl/intranet-tmpl/prog/en/modules/members/ill-requests.tt To test: - Apply the patch - Run the QA tools - Note that the "Failed test '<body> tag with id and class attributes'" no longer is reported -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 --- Comment #10 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 84204 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84204&action=edit Bug 18589: (follow-up) Fix QA errors This patch fixes the "missing_filter" QA errors -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22268 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22268 [Bug 22268] Data displayed in request list datatable is not sanitized -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 --- Comment #11 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 84792 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84792&action=edit Bug 18589: (follow-up) Fix rebase errors Minor rebase errors -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82513|0 |1 is obsolete| | --- Comment #12 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 84796 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84796&action=edit Bug 18589: Show ILLs as part of patron profile This patch moves the display of a patron's ILL requests to be inline in the Patron Profile page, as per all other patron information. It includes a substantial refactor of koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt in that it moves the display of the illlist table (which is populated by an API request) into it's own separate include file. It also moves the datatable related Javascript for this table into it's own JS file. Doing this allows us to reuse both in both the new members/ill-requests.tt template and the pre-existing ill/ill-requests.tt template. To test: 1) Ensure ILL is enabled and your user has sufficient permissions 2) Ensure your user has some ILL requests 3) Navigate to the user's patron profile page 4) Click on the "Interlibrary loans" tab 5) Observe that the requests table is displayed inline 6) Observe that only your user's requests are displayed Signed-off-by: Niamh.Walker-Headon@it-tallaght.ie Bug 18589: (follow-up) Fix QA error Bug 18589: (follow-up) Fix QA failure This patch removes the id and class attributes on the body tag in: koha-tmpl/intranet-tmpl/prog/en/modules/members/ill-requests.tt To test: - Apply the patch - Run the QA tools - Note that the "Failed test '<body> tag with id and class attributes'" no longer is reported Bug 18589: (follow-up) Fix QA errors This patch fixes the "missing_filter" QA errors Bug 18589: (follow-up) Fix rebase errors Minor rebase errors Bug 18589: (follow-up) More merge errors -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84197|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84199|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84204|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84792|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 --- Comment #13 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- I had to squash all patches thus far in order to get them to apply. The previous patches contained within can be seen in the obsoleted patches for this bug. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22121 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22121 [Bug 22121] Display 'Price paid' on ILL requests according to CurrencyFormat pref -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21460 Depends on|21460 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21460 [Bug 21460] Filtering ILL requests on borrowernumber does not work -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22440 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22440 [Bug 22440] ILL API response objects inconsistent with other endpoints -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22464 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22464 [Bug 22464] Copyright notice does not pass forward request properties -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 Chris Slone <cslone@camdencountylibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cslone@camdencountylibrary. | |org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |josef.moravec@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84796|0 |1 is obsolete| | --- Comment #14 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 86432 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86432&action=edit Bug 18589: Show ILLs as part of patron profile This patch moves the display of a patron's ILL requests to be inline in the Patron Profile page, as per all other patron information. It includes a substantial refactor of koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt in that it moves the display of the illlist table (which is populated by an API request) into it's own separate include file. It also moves the datatable related Javascript for this table into it's own JS file. Doing this allows us to reuse both in both the new members/ill-requests.tt template and the pre-existing ill/ill-requests.tt template. To test: 1) Ensure ILL is enabled and your user has sufficient permissions 2) Ensure your user has some ILL requests 3) Navigate to the user's patron profile page 4) Click on the "Interlibrary loans" tab 5) Observe that the requests table is displayed inline 6) Observe that only your user's requests are displayed Signed-off-by: Niamh.Walker-Headon@it-tallaght.ie Bug 18589: (follow-up) Fix QA error Bug 18589: (follow-up) Fix QA failure This patch removes the id and class attributes on the body tag in: koha-tmpl/intranet-tmpl/prog/en/modules/members/ill-requests.tt To test: - Apply the patch - Run the QA tools - Note that the "Failed test '<body> tag with id and class attributes'" no longer is reported Bug 18589: (follow-up) Fix QA errors This patch fixes the "missing_filter" QA errors Bug 18589: (follow-up) Fix rebase errors Minor rebase errors Bug 18589: (follow-up) More merge errors -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86432|0 |1 is obsolete| | --- Comment #15 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 86433 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86433&action=edit Bug 18589: Show ILLs as part of patron profile This patch moves the display of a patron's ILL requests to be inline in the Patron Profile page, as per all other patron information. It includes a substantial refactor of koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt in that it moves the display of the illlist table (which is populated by an API request) into it's own separate include file. It also moves the datatable related Javascript for this table into it's own JS file. Doing this allows us to reuse both in both the new members/ill-requests.tt template and the pre-existing ill/ill-requests.tt template. To test: 1) Ensure ILL is enabled and your user has sufficient permissions 2) Ensure your user has some ILL requests 3) Navigate to the user's patron profile page 4) Click on the "Interlibrary loans" tab 5) Observe that the requests table is displayed inline 6) Observe that only your user's requests are displayed Signed-off-by: Niamh.Walker-Headon@it-tallaght.ie This is essentially a reimplementation of attachment 84796 to take into account all changes that had happened beneath this bug and also to ensure JS strings are translatable. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22491 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22491 [Bug 22491] Borrowers should be searchable by surname -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 --- Comment #16 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 86456 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86456&action=edit Bug 18589: (follow-up) Remove redundant-ness Following feedback from Josef via IRC, removing redundant code -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #17 from Josef Moravec <josef.moravec@gmail.com> --- Andrew, thanks for quick rebase. I just run QA test tools and they are not happy: FAIL koha-tmpl/intranet-tmpl/prog/en/includes/ill-list-table-strings.inc FAIL forbidden patterns forbidden pattern: simple-quote string (line 2) forbidden pattern: simple-quote string (line 3) forbidden pattern: simple-quote string (line 5) forbidden pattern: simple-quote string (line 6) forbidden pattern: simple-quote string (line 7) forbidden pattern: simple-quote string (line 8) forbidden pattern: simple-quote string (line 9) forbidden pattern: simple-quote string (line 10) forbidden pattern: simple-quote string (line 11) forbidden pattern: simple-quote string (line 12) forbidden pattern: simple-quote string (line 14) forbidden pattern: simple-quote string (line 16) forbidden pattern: simple-quote string (line 17) FAIL koha-tmpl/intranet-tmpl/prog/en/includes/ill-list-table.inc FAIL forbidden patterns forbidden pattern: tab char (line 2) forbidden pattern: tab char (line 3) forbidden pattern: tab char (line 4) forbidden pattern: tab char (line 5) forbidden pattern: tab char (line 6) forbidden pattern: tab char (line 7) forbidden pattern: tab char (line 8) forbidden pattern: tab char (line 9) forbidden pattern: tab char (line 10) forbidden pattern: tab char (line 11) forbidden pattern: tab char (line 12) forbidden pattern: tab char (line 13) forbidden pattern: tab char (line 14) forbidden pattern: tab char (line 15) forbidden pattern: tab char (line 16) forbidden pattern: tab char (line 17) forbidden pattern: tab char (line 18) forbidden pattern: tab char (line 19) forbidden pattern: tab char (line 20) forbidden pattern: tab char (line 21) forbidden pattern: tab char (line 22) forbidden pattern: tab char (line 23) forbidden pattern: tab char (line 24) forbidden pattern: tab char (line 25) forbidden pattern: tab char (line 26) forbidden pattern: tab char (line 27) forbidden pattern: tab char (line 28) forbidden pattern: tab char (line 29) forbidden pattern: tab char (line 30) forbidden pattern: tab char (line 31) forbidden pattern: tab char (line 32) forbidden pattern: tab char (line 33) forbidden pattern: tab char (line 34) forbidden pattern: tab char (line 35) forbidden pattern: tab char (line 36) forbidden pattern: tab char (line 37) forbidden pattern: tab char (line 38) forbidden pattern: tab char (line 39) forbidden pattern: tab char (line 40) forbidden pattern: tab char (line 41) FAIL koha-tmpl/intranet-tmpl/prog/en/modules/members/ill-requests.tt FAIL forbidden patterns forbidden pattern: tab char (line 16) forbidden pattern: tab char (line 17) forbidden pattern: tab char (line 19) forbidden pattern: tab char (line 20) forbidden pattern: tab char (line 21) forbidden pattern: tab char (line 22) forbidden pattern: tab char (line 23) forbidden pattern: tab char (line 25) forbidden pattern: tab char (line 27) forbidden pattern: tab char (line 28) forbidden pattern: tab char (line 29) forbidden pattern: tab char (line 30) forbidden pattern: tab char (line 31) forbidden pattern: tab char (line 32) forbidden pattern: tab char (line 33) forbidden pattern: tab char (line 34) forbidden pattern: tab char (line 35) forbidden pattern: tab char (line 36) forbidden pattern: tab char (line 37) forbidden pattern: tab char (line 38) forbidden pattern: tab char (line 39) forbidden pattern: tab char (line 41) forbidden pattern: tab char (line 42) forbidden pattern: tab char (line 43) forbidden pattern: tab char (line 44) forbidden pattern: tab char (line 45) forbidden pattern: tab char (line 46) forbidden pattern: tab char (line 47) forbidden pattern: tab char (line 48) forbidden pattern: tab char (line 49) forbidden pattern: tab char (line 50) forbidden pattern: tab char (line 51) forbidden pattern: tab char (line 52) forbidden pattern: tab char (line 53) forbidden pattern: tab char (line 54) forbidden pattern: tab char (line 55) forbidden pattern: tab char (line 56) forbidden pattern: tab char (line 57) forbidden pattern: tab char (line 58) forbidden pattern: tab char (line 60) forbidden pattern: tab char (line 61) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 --- Comment #18 from Josef Moravec <josef.moravec@gmail.com> --- Also, it would be nice to have test for changes in Koha/REST/V1/Illrequests.pm -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 --- Comment #19 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 86465 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86465&action=edit Bug 18589: (follow-up) Fix QA tool failures As per comment #17: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589#c17 Sorry Josef, I honestly have no idea where those tabs came from :( Every once in a while my copy of Vim decides to embarass me and stick in tabs instead of spaces... <shakes fist at screen> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 --- Comment #20 from Josef Moravec <josef.moravec@gmail.com> --- 1) You are setting dateFormat on two places, but not use it anywhere. 2) In the ill requests list tables (both, in ill module and patron ill view) are shown columns placed_unformatted and updated_unformatted, only data, table header is blank. 3) There is error in js console, when load the ill request lista table in ill module ill-list-table_18.1200024.js:242 Uncaught TypeError: Cannot read property 'hasOwnProperty' of undefined at getStatusName (ill-list-table_18.1200024.js:242) at ill-list-table_18.1200024.js:34 at Array.forEach (<anonymous>) at Object.prep (ill-list-table_18.1200024.js:29) at a.fn.init.initComplete (ill-list-table_18.1200024.js:460) at jquery.dataTables.min_18.1200024.js:75 at Function.map (jquery-2.2.3.min_18.1200024.js:2) at v (jquery.dataTables.min_18.1200024.js:75) at ta (jquery.dataTables.min_18.1200024.js:49) at ia (jquery.dataTables.min_18.1200024.js:48) 3) when trying to filter by date placed, there is one more error in console: ill-list-table_18.1200024.js:519 Uncaught TypeError: Cannot read property 'api' of undefined at HTMLFormElement.<anonymous> (ill-list-table_18.1200024.js:519) at HTMLFormElement.dispatch (jquery-2.2.3.min_18.1200024.js:3) at HTMLFormElement.r.handle (jquery-2.2.3.min_18.1200024.js:3) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 --- Comment #21 from Josef Moravec <josef.moravec@gmail.com> --- (In reply to Josef Moravec from comment #18)
Also, it would be nice to have test for changes in Koha/REST/V1/Illrequests.pm
Test in this attachmend of 21460 is exactly what I mean: https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83184&action=diff we could move it here maybe... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 --- Comment #22 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 86504 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86504&action=edit Bug 18589: (follow-up) Add borrowernumber test As per comment #21: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589#c21 We now test borrowernumber filter works. This test has come from https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83184&action=diff and will be removed from that bug -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 --- Comment #23 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 86506 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86506&action=edit Bug 18589: (follow-up) Fix merge problem Date format setting got lost in the merge As per item 1) in comment #20: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589#c20 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86506|0 |1 is obsolete| | --- Comment #24 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 86507 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86507&action=edit Bug 18589: (follow-up) Fix merge problem Bug in passing row to getStatusName As per item 3) in comment #20: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589#c20 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86506|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #25 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- (In reply to Josef Moravec from comment #20)
1) You are setting dateFormat on two places, but not use it anywhere. Good spot, this was a merge error, fixed in https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86506
2) In the ill requests list tables (both, in ill module and patron ill view) are shown columns placed_unformatted and updated_unformatted, only data, table header is blank. These are used for sorting. This is a technique I observed was used elsewhere. Since the formatted dates don't always work well for sorting, hidden unformatted date columns that are used for sorting are used instead.
3) There is error in js console, when load the ill request lista table in ill module ill-list-table_18.1200024.js:242 Uncaught TypeError: Cannot read property 'hasOwnProperty' of undefined Another merge error, fixed in https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86507
3) when trying to filter by date placed, there is one more error in console: ill-list-table_18.1200024.js:519 Uncaught TypeError: Cannot read property 'api' of undefined at HTMLFormElement.<anonymous> (ill-list-table_18.1200024.js:519) at HTMLFormElement.dispatch (jquery-2.2.3.min_18.1200024.js:3) at HTMLFormElement.r.handle (jquery-2.2.3.min_18.1200024.js:3) I can't replicate this. Can you make sure you do a hard refresh and try again?
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22528 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22528 [Bug 22528] Add tab with current/active ILL requests to patron circulation page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86433|0 |1 is obsolete| | Attachment #86456|0 |1 is obsolete| | Attachment #86465|0 |1 is obsolete| | Attachment #86504|0 |1 is obsolete| | Attachment #86506|0 |1 is obsolete| | Attachment #86507|0 |1 is obsolete| | --- Comment #26 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 86714 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86714&action=edit Bug 18589: Show ILLs as part of patron profile This patch moves the display of a patron's ILL requests to be inline in the Patron Profile page, as per all other patron information. It includes a substantial refactor of koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt in that it moves the display of the illlist table (which is populated by an API request) into it's own separate include file. It also moves the datatable related Javascript for this table into it's own JS file. Doing this allows us to reuse both in both the new members/ill-requests.tt template and the pre-existing ill/ill-requests.tt template. To test: 1) Ensure ILL is enabled and your user has sufficient permissions 2) Ensure your user has some ILL requests 3) Navigate to the user's patron profile page 4) Click on the "Interlibrary loans" tab 5) Observe that the requests table is displayed inline 6) Observe that only your user's requests are displayed Signed-off-by: Niamh.Walker-Headon@it-tallaght.ie This is essentially a reimplementation of attachment 84796 to take into account all changes that had happened beneath this bug and also to ensure JS strings are translatable. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 --- Comment #27 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 86715 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86715&action=edit Bug 18589: (follow-up) Remove redundant-ness Following feedback from Josef via IRC, removing redundant code Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 --- Comment #28 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 86716 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86716&action=edit Bug 18589: (follow-up) Fix QA tool failures As per comment #17: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589#c17 Sorry Josef, I honestly have no idea where those tabs came from :( Every once in a while my copy of Vim decides to embarass me and stick in tabs instead of spaces... <shakes fist at screen> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 --- Comment #29 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 86717 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86717&action=edit Bug 18589: (follow-up) Add borrowernumber test As per comment #21: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589#c21 We now test borrowernumber filter works. This test has come from https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83184&action=diff and will be removed from that bug Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 --- Comment #30 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 86718 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86718&action=edit Bug 18589: (follow-up) Fix merge problem Date format setting got lost in the merge As per item 1) in comment #20: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589#c20 Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 --- Comment #31 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 86719 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86719&action=edit Bug 18589: (follow-up) Fix merge problem Bug in passing row to getStatusName As per item 3) in comment #20: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589#c20 Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 --- Comment #32 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 86720 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86720&action=edit Bug 18589: (QA follow-up) Rename page to "ILL requests history" for consistancy Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 --- Comment #33 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 86721 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86721&action=edit Bug 18589: (QA follow-up) Move template to bootstrap grid Test plan: Go to patrons Ill request history page and ensure the layout is not broken and is consistant with other patron pages (except Circulation and Details pages) Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86718|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22531 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22531 [Bug 22531] Allow for multiple requests to partners and display partners in audit log -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 --- Comment #34 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 86722 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86722&action=edit Bug 18589: (QA follow-up) Remove dateFormat from javascript on ill requests pages. This is not needed, the right formatting is done in calendar.inc Test plan: Use datepickers on ILL requests list page and ensure they work as expected and the list is right filterred Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 --- Comment #35 from Josef Moravec <josef.moravec@gmail.com> --- Ad changes in Koha/REST/V1/Illrequests.pm: Working with parameters should use objects search plugin and patron_id instead of borrowernumber. But such changes are out of scope of this bug and will be done on bug 22440 and after ILL request api rfc is voted. So, I would consider this as Passed QA Just would like somebody to test and sign off on my three follow-ups -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86720|0 |1 is obsolete| | --- Comment #36 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 86735 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86735&action=edit Bug 18589: (QA follow-up) Rename page to "ILL requests history" for consistancy Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Andrew Isherwood <andrew.isherwood@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86721|0 |1 is obsolete| | --- Comment #37 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 86736 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86736&action=edit Bug 18589: (QA follow-up) Move template to bootstrap grid Test plan: Go to patrons Ill request history page and ensure the layout is not broken and is consistant with other patron pages (except Circulation and Details pages) Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Andrew Isherwood <andrew.isherwood@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86722|0 |1 is obsolete| | --- Comment #38 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 86737 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86737&action=edit Bug 18589: (QA follow-up) Remove dateFormat from javascript on ill requests pages. This is not needed, the right formatting is done in calendar.inc Test plan: Use datepickers on ILL requests list page and ensure they work as expected and the list is right filterred Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Andrew Isherwood <andrew.isherwood@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |josef.moravec@gmail.com Status|Signed Off |Passed QA --- Comment #39 from Josef Moravec <josef.moravec@gmail.com> ---
Signed-off-by: Andrew Isherwood <andrew.isherwood@ptfs-europe.com>
Thanks Andrew, so now I am passing it -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 Bug 18589 depends on bug 20563, which changed state. Bug 20563 Summary: ILL request list gives no indication of source and/or target https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20563 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick@bywatersolutions.com --- Comment #40 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #41 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Enhancement will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|22464 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22464 [Bug 22464] Copyright notice does not pass forward request properties -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|19605 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19605 [Bug 19605] ILL backends should be pluggable through regular Koha plugins -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|22121 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22121 [Bug 22121] Display 'Price paid' on ILL requests according to CurrencyFormat pref -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|22440 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22440 [Bug 22440] ILL API response objects inconsistent with other endpoints -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|22491 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22491 [Bug 22491] Patrons should be searchable by surname -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|22528 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22528 [Bug 22528] Add tab with current/active ILL requests to patron circulation page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|22531 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22531 [Bug 22531] Allow for multiple requests to partners and display partners in audit log -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|21460 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21460 [Bug 21460] Filtering ILL requests on borrowernumber does not work -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|22268 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22268 [Bug 22268] Data displayed in request list datatable is not sanitized -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 Andrew Isherwood <bugzilla@warmlight.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|bugzilla@warmlight.co.uk | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org