[Bug 18837] New: Add an unmediated Interlibrary Loans workflow
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18837 Bug ID: 18837 Summary: Add an unmediated Interlibrary Loans workflow Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: alex.sassmannshausen@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Some libraries may wish to allow their patrons to place Interlibrary loan requests without those requests going through a formal moderation process. The ILLModule cannot guarantee an unmediated workflow for every backend. I propose the following approach: - A system preference switching this functionality on & off. - Use ILL module's generic capabilities functionality to allow execution of unmediated requests on a per backend basis, but falling back on the normal process for backends that don't support unmediated. Alex -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18837 Alex Sassmannshausen <alex.sassmannshausen@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |alex.sassmannshausen@ptfs-e |ity.org |urope.com Depends on| |7317 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18837 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18837 --- Comment #1 from Alex Sassmannshausen <alex.sassmannshausen@ptfs-europe.com> --- Created attachment 66628 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66628&action=edit Add ILL Unmediated syspref stuff. * installer/data/mysql/atomicupdate/illunmediated_tables.sql: New file. * installer/data/mysql/sysprefs.sql: Add `ILLModuleUnmediated`. * koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/admin.pref: Add `ILLModuleUnmediated` handling. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18837 --- Comment #2 from Alex Sassmannshausen <alex.sassmannshausen@ptfs-europe.com> --- Created attachment 66629 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66629&action=edit Introduce delegation to backends for unmediated workflows. * Koha/Illrequest.pm (backend_create): Add dispatch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18837 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |20536 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20536 [Bug 20536] ILL: authnotrequired not explicitly unset -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18837 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|20536 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20536 [Bug 20536] ILL: authnotrequired not explicitly unset -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18837 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|alex.sassmannshausen@gmail. |andrew.isherwood@ptfs-europ |com |e.com CC| |andrew.isherwood@ptfs-europ | |e.com Component|Circulation |ILL QA Contact|testopia@bugs.koha-communit | |y.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18837 --- Comment #3 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 74874 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74874&action=edit Bug 18837: Add ILL Unmediated syspref stuff This patch adds the syspref requirements for unmediated ILL requests. It is a recreation of https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66628&action=diff which had diverged sufficiently as to make it impossible to apply. * installer/data/mysql/atomicupdate/illunmediated_tables.sql: New file. * installer/data/mysql/sysprefs.sql: Add `ILLModuleUnmediated`. * koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/admin.pref: Add `ILLModuleUnmediated` handling. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18837 --- Comment #4 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 74875 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74875&action=edit Bug 18837: Introduce delegation to backends for unmediated workflows This patch adds support to Illrequest.pm to allow delegation of unmediated requests to happen in backends that support them. It is a recreation of https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66629&action=diff which had diverged sufficiently as to make it impossible to apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18837 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66628|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18837 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66629|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18837 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Andrew, please always make sure to include a test plan. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18837 --- Comment #6 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Hi Katrin Thanks for the reminder. I'd not added test plans because these patches were simply direct replacements for Alex's, which had become impossible to apply. The work on this bug is incomplete so there's a good chance these patches will be obsoleted as I complete the work. I figured it was probably OK to not include test plans yet as no-one would be trying to test it as it's not yet in "Needs signoff", and won't be until the work is complete. Hope that's OK. Andrew -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18837 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Ah sure, I missed ASSIGNED the status! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18837 Joe McGlynn <joe.mcglynn@educampus.ie> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joe.mcglynn@educampus.ie -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18837 --- Comment #8 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- To test: - Apply patches - Ensure ILL is enabled and you have at least one backend available that supports unmediated requests (currently only the BLDSS backend supports this) - Enable "ILLModuleUnmediated" preference - As an OPAC user, navigate to "Your summary" > "Your interlibrary loan requests" - Select "Create a new request" > "BLDSS" - Search for an item and create an interlibrary loan request - Observe that in the "Your interlibrary loan requests" view, the request now has the status of "Requested" rather than the "New request" status that it would have in an mediated workflow. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18837 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18837 Bug 18837 depends on bug 7317, which changed state. Bug 7317 Summary: Add an Interlibrary Loan Module to Circulation and OPAC https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18837 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74874|0 |1 is obsolete| | --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 79542 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79542&action=edit Bug 18837: Add ILL Unmediated syspref stuff This patch adds the syspref requirements for unmediated ILL requests. It is a recreation of https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66628&action=diff which had diverged sufficiently as to make it impossible to apply. * installer/data/mysql/atomicupdate/illunmediated_tables.sql: New file. * installer/data/mysql/sysprefs.sql: Add `ILLModuleUnmediated`. * koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/admin.pref: Add `ILLModuleUnmediated` handling. Signed-off-by: Stephen Graham <s.graham4@herts.ac.uk> Signed-off-by: David Peacock <d.m.peacock@herts.ac.uk> Signed-off-by: Jayne Maisey <j.maisey@herts.ac.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18837 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74875|0 |1 is obsolete| | --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 79543 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79543&action=edit Bug 18837: Introduce delegation to backends for unmediated workflows This patch adds support to Illrequest.pm to allow delegation of unmediated requests to happen in backends that support them. It is a recreation of https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66629&action=diff which had diverged sufficiently as to make it impossible to apply Signed-off-by: Stephen Graham <s.graham4@herts.ac.uk> Signed-off-by: David Peacock <d.m.peacock@herts.ac.uk> Signed-off-by: Jayne Maisey <j.maisey@herts.ac.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18837 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Needs Signoff |Signed Off --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Hertfordshire University have undertaken lots of testing upon this work and have been running it in production for some time now. They have asked me to sign it off on their behalf.. I have added their testing team to the patches signoff lines. Thanks guys :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18837 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |21063 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21063 [Bug 21063] Allow columns in intranet ILL request datatable to be customisable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18837 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20563 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20563 [Bug 20563] ILL request list gives no indication of source and/or target -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18837 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|7317 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18837 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79542|0 |1 is obsolete| | --- Comment #12 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 82158 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82158&action=edit Bug 18837: Add ILL Unmediated syspref stuff This patch adds the syspref requirements for unmediated ILL requests. It is a recreation of https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66628&action=diff which had diverged sufficiently as to make it impossible to apply. * installer/data/mysql/atomicupdate/illunmediated_tables.sql: New file. * installer/data/mysql/sysprefs.sql: Add `ILLModuleUnmediated`. * koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/admin.pref: Add `ILLModuleUnmediated` handling. Signed-off-by: Stephen Graham <s.graham4@herts.ac.uk> Signed-off-by: David Peacock <d.m.peacock@herts.ac.uk> Signed-off-by: Jayne Maisey <j.maisey@herts.ac.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18837 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79543|0 |1 is obsolete| | --- Comment #13 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 82159 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82159&action=edit Bug 18837: Introduce delegation to backends for unmediated workflows This patch adds support to Illrequest.pm to allow delegation of unmediated requests to happen in backends that support them. It is a recreation of https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66629&action=diff which had diverged sufficiently as to make it impossible to apply Signed-off-by: Stephen Graham <s.graham4@herts.ac.uk> Signed-off-by: David Peacock <d.m.peacock@herts.ac.uk> Signed-off-by: Jayne Maisey <j.maisey@herts.ac.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18837 --- Comment #14 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Rebased on top of current dependency tree -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18837 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82158|0 |1 is obsolete| | --- Comment #15 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 82508 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82508&action=edit Bug 18837: Add ILL Unmediated syspref stuff This patch adds the syspref requirements for unmediated ILL requests. It is a recreation of https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66628&action=diff which had diverged sufficiently as to make it impossible to apply. * installer/data/mysql/atomicupdate/illunmediated_tables.sql: New file. * installer/data/mysql/sysprefs.sql: Add `ILLModuleUnmediated`. * koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/admin.pref: Add `ILLModuleUnmediated` handling. Signed-off-by: Stephen Graham <s.graham4@herts.ac.uk> Signed-off-by: David Peacock <d.m.peacock@herts.ac.uk> Signed-off-by: Jayne Maisey <j.maisey@herts.ac.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18837 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82159|0 |1 is obsolete| | --- Comment #16 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 82509 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82509&action=edit Bug 18837: Introduce delegation to backends for unmediated workflows This patch adds support to Illrequest.pm to allow delegation of unmediated requests to happen in backends that support them. It is a recreation of https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66629&action=diff which had diverged sufficiently as to make it impossible to apply Signed-off-by: Stephen Graham <s.graham4@herts.ac.uk> Signed-off-by: David Peacock <d.m.peacock@herts.ac.uk> Signed-off-by: Jayne Maisey <j.maisey@herts.ac.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18837 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #17 from Josef Moravec <josef.moravec@gmail.com> --- Could you rebase please? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18837 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82508|0 |1 is obsolete| | --- Comment #18 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 86188 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86188&action=edit Bug 18837: Add ILL Unmediated syspref stuff This patch adds the syspref requirements for unmediated ILL requests. It is a recreation of https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66628&action=diff which had diverged sufficiently as to make it impossible to apply. * installer/data/mysql/atomicupdate/illunmediated_tables.sql: New file. * installer/data/mysql/sysprefs.sql: Add `ILLModuleUnmediated`. * koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/admin.pref: Add `ILLModuleUnmediated` handling. Signed-off-by: Stephen Graham <s.graham4@herts.ac.uk> Signed-off-by: David Peacock <d.m.peacock@herts.ac.uk> Signed-off-by: Jayne Maisey <j.maisey@herts.ac.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18837 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82509|0 |1 is obsolete| | --- Comment #19 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 86189 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86189&action=edit Bug 18837: Introduce delegation to backends for unmediated workflows This patch adds support to Illrequest.pm to allow delegation of unmediated requests to happen in backends that support them. It is a recreation of https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66629&action=diff which had diverged sufficiently as to make it impossible to apply Signed-off-by: Stephen Graham <s.graham4@herts.ac.uk> Signed-off-by: David Peacock <d.m.peacock@herts.ac.uk> Signed-off-by: Jayne Maisey <j.maisey@herts.ac.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18837 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18837 --- Comment #20 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- To test: - Apply patches - Ensure ILL is enabled and you have at least one backend available that supports unmediated requests (currently only the BLDSS backend supports this) - Enable "ILLModuleUnmediated" preference - Ensure you have default delivery formats specified in your koha-conf.xml. These should be placed inside the <interlibrary_loans> block, an example (which specifies the loan should be a paper copy, of standard quality, delivered within 4 days) is below: <default_formats> <format>4</format> <speed>4</speed> <quality>1</quality> </default_formats> - As an OPAC user, navigate to "Your summary" > "Your interlibrary loan requests" - Select "Create a new request" > "BLDSS" - Search for an item and create an interlibrary loan request => TEST: Observe that in the "Your interlibrary loan requests" view, the request now has the status of "Requested" rather than the "New request" status that it would have in an mediated workflow. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18837 --- Comment #21 from Josef Moravec <josef.moravec@gmail.com> --- When the library has missing some data it is shown like this: https://screenshots.firefox.com/R4iMqp2SVyEkh8Qz/localhost But when is missing country, it dies in BLDSS/Base.pm, (but request is still created with status "New") not sure if we could do something with this in Koha... Also, you have ILLOpacbackends in sysprefs and yaml, but not in db update and also not used in code, so probably should be removed When I have all address data OK, I got this message: "Invalid Request: At least one Item Of Interest level piece of metadata is required." Is it possible to show which metadata is missing? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18837 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18837 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86188|0 |1 is obsolete| | --- Comment #22 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 86236 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86236&action=edit Bug 18837: Add ILL Unmediated syspref stuff This patch adds the syspref requirements for unmediated ILL requests. It is a recreation of https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66628&action=diff which had diverged sufficiently as to make it impossible to apply. * installer/data/mysql/atomicupdate/illunmediated_tables.sql: New file. * installer/data/mysql/sysprefs.sql: Add `ILLModuleUnmediated`. * koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/admin.pref: Add `ILLModuleUnmediated` handling. Signed-off-by: Stephen Graham <s.graham4@herts.ac.uk> Signed-off-by: David Peacock <d.m.peacock@herts.ac.uk> Signed-off-by: Jayne Maisey <j.maisey@herts.ac.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18837 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86189|0 |1 is obsolete| | --- Comment #23 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 86237 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86237&action=edit Bug 18837: Introduce delegation to backends for unmediated workflows This patch adds support to Illrequest.pm to allow delegation of unmediated requests to happen in backends that support them. It is a recreation of https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66629&action=diff which had diverged sufficiently as to make it impossible to apply Signed-off-by: Stephen Graham <s.graham4@herts.ac.uk> Signed-off-by: David Peacock <d.m.peacock@herts.ac.uk> Signed-off-by: Jayne Maisey <j.maisey@herts.ac.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18837 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #24 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- (In reply to Josef Moravec from comment #21)
When the library has missing some data it is shown like this: https://screenshots.firefox.com/R4iMqp2SVyEkh8Qz/localhost
But when is missing country, it dies in BLDSS/Base.pm, (but request is still created with status "New") not sure if we could do something with this in Koha...
Yes, I'll create a bug report on the BLDSS Github site so we can get it fixed.
Also, you have ILLOpacbackends in sysprefs and yaml, but not in db update and also not used in code, so probably should be removed
Updated patches attached
When I have all address data OK, I got this message: "Invalid Request: At least one Item Of Interest level piece of metadata is required." Is it possible to show which metadata is missing?
Sadly not, that error is coming back from the BLDSS service, it's not very helpful, I agree! :( -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18837 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |josef.moravec@gmail.com --- Comment #25 from Josef Moravec <josef.moravec@gmail.com> --- (In reply to Andrew Isherwood from comment #24)
(In reply to Josef Moravec from comment #21)
When the library has missing some data it is shown like this: https://screenshots.firefox.com/R4iMqp2SVyEkh8Qz/localhost
But when is missing country, it dies in BLDSS/Base.pm, (but request is still created with status "New") not sure if we could do something with this in Koha...
Yes, I'll create a bug report on the BLDSS Github site so we can get it fixed.
Also, you have ILLOpacbackends in sysprefs and yaml, but not in db update and also not used in code, so probably should be removed
Updated patches attached
When I have all address data OK, I got this message: "Invalid Request: At least one Item Of Interest level piece of metadata is required." Is it possible to show which metadata is missing?
Sadly not, that error is coming back from the BLDSS service, it's not very helpful, I agree! :(
Thanks for answers and quick rebase! I am continuing here... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18837 --- Comment #26 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 86238 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86238&action=edit Bug 18837: (QA follow-up) Update system preference desciprition -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18837 --- Comment #27 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 86371 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86371&action=edit Bug 18837: (follow-up) Add additional tests As requested by Josef on IRC, we now mock the unmediated_ill backend method and ensure it is called when the ILLModuleUnmediated syspref is enabled and ensure it is not called when the syspref is disabled -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18837 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86236|0 |1 is obsolete| | --- Comment #28 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 86372 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86372&action=edit Bug 18837: Add ILL Unmediated syspref stuff This patch adds the syspref requirements for unmediated ILL requests. It is a recreation of https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66628&action=diff which had diverged sufficiently as to make it impossible to apply. * installer/data/mysql/atomicupdate/illunmediated_tables.sql: New file. * installer/data/mysql/sysprefs.sql: Add `ILLModuleUnmediated`. * koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/admin.pref: Add `ILLModuleUnmediated` handling. Signed-off-by: Stephen Graham <s.graham4@herts.ac.uk> Signed-off-by: David Peacock <d.m.peacock@herts.ac.uk> Signed-off-by: Jayne Maisey <j.maisey@herts.ac.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18837 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86237|0 |1 is obsolete| | --- Comment #29 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 86373 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86373&action=edit Bug 18837: Introduce delegation to backends for unmediated workflows This patch adds support to Illrequest.pm to allow delegation of unmediated requests to happen in backends that support them. It is a recreation of https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66629&action=diff which had diverged sufficiently as to make it impossible to apply Signed-off-by: Stephen Graham <s.graham4@herts.ac.uk> Signed-off-by: David Peacock <d.m.peacock@herts.ac.uk> Signed-off-by: Jayne Maisey <j.maisey@herts.ac.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18837 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86238|0 |1 is obsolete| | --- Comment #30 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 86374 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86374&action=edit Bug 18837: (QA follow-up) Update system preference desciprition -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18837 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86371|0 |1 is obsolete| | --- Comment #31 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 86375 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86375&action=edit Bug 18837: (follow-up) Add additional tests As requested by Josef on IRC, we now mock the unmediated_ill backend method and ensure it is called when the ILLModuleUnmediated syspref is enabled and ensure it is not called when the syspref is disabled -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18837 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18837 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86372|0 |1 is obsolete| | Attachment #86373|0 |1 is obsolete| | Attachment #86374|0 |1 is obsolete| | Attachment #86375|0 |1 is obsolete| | --- Comment #32 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 86422 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86422&action=edit Bug 18837: Add ILL Unmediated syspref stuff This patch adds the syspref requirements for unmediated ILL requests. It is a recreation of https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66628&action=diff which had diverged sufficiently as to make it impossible to apply. * installer/data/mysql/atomicupdate/illunmediated_tables.sql: New file. * installer/data/mysql/sysprefs.sql: Add `ILLModuleUnmediated`. * koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/admin.pref: Add `ILLModuleUnmediated` handling. Signed-off-by: Stephen Graham <s.graham4@herts.ac.uk> Signed-off-by: David Peacock <d.m.peacock@herts.ac.uk> Signed-off-by: Jayne Maisey <j.maisey@herts.ac.uk> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18837 --- Comment #33 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 86423 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86423&action=edit Bug 18837: Introduce delegation to backends for unmediated workflows This patch adds support to Illrequest.pm to allow delegation of unmediated requests to happen in backends that support them. It is a recreation of https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66629&action=diff which had diverged sufficiently as to make it impossible to apply Signed-off-by: Stephen Graham <s.graham4@herts.ac.uk> Signed-off-by: David Peacock <d.m.peacock@herts.ac.uk> Signed-off-by: Jayne Maisey <j.maisey@herts.ac.uk> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18837 --- Comment #34 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 86424 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86424&action=edit Bug 18837: (QA follow-up) Update system preference desciprition Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18837 --- Comment #35 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 86425 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86425&action=edit Bug 18837: (follow-up) Add additional tests As requested by Josef on IRC, we now mock the unmediated_ill backend method and ensure it is called when the ILLModuleUnmediated syspref is enabled and ensure it is not called when the syspref is disabled Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18837 --- Comment #36 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 86426 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86426&action=edit Bug 18837: (QA follow-up) Fix order of sysprefa.sql Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18837 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick@bywatersolutions.com --- Comment #37 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18837 Bug 18837 depends on bug 21063, which changed state. Bug 21063 Summary: Allow columns in intranet ILL request datatable to be customisable https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21063 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18837 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Master |RESOLVED --- Comment #38 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Enhancement, will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18837 Andrew Isherwood <bugzilla@warmlight.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|bugzilla@warmlight.co.uk | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org