[Bug 38924] New: Introduce a loan 'Quota' system for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Bug ID: 38924 Summary: Introduce a loan 'Quota' system for Koha Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvoize@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Some libraries work based on the number of allowed issues in a time period as opposed to the number of simultaneous issues. This enhancement intends to add a per-user, including guarantee/guarantor relations, quota option for setting a fixed number of issues a user is allowed within a specified period. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 --- Comment #1 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Initial proposed specification: https://docs.google.com/document/d/1YbEuWbt2ELNbFv36T0qlMscofhMI2wwyhjhhLYAM... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jacob.omara@ptfs-europe.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Introduce a loan 'Quota' |Introduce an organization |system for Koha |level loan 'Quota' system | |for Koha -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 --- Comment #2 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 178582 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178582&action=edit Bug 38924: Add patron_quotas table Add the new patron_quotas table for storing circulation quotas -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 --- Comment #3 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 178583 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178583&action=edit Bug 38924: DBIC Schema DBIC update -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 --- Comment #4 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 178584 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178584&action=edit Bug 38924: Add Koha::Patron::Quota(s) classes Add initial Koha::Patron::Quota(s) classes for working with circulation quotas, including an overloaded store method to prevent overlapping quota periods. Additionally added a definition for the custom exception for if you are trying to store a quota whos active period overlaps with another for this patron -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 --- Comment #5 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 178585 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178585&action=edit Bug 38924: Add quotas permissions This patch adds the new quotas permissions to the system -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 --- Comment #6 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 178586 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178586&action=edit Bug 38924: Add API endpoints for managing quotas This commit adds the api endpoints for administering circulation quotas -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 --- Comment #7 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 178587 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178587&action=edit Bug 38924: Add patron quota management page Add a new patron quota management tab under the members area for patrons of the organization category type. FIXME: Tie into permissions for 'add', 'edit' Depending on permissions, we will need display only options including guarantor and guarantee usage against quotas and also the options to add and edit quota. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 --- Comment #8 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 178588 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178588&action=edit Bug 38924: Add patron_quota_usage table Add the new patron_quota_usage table for recording usage of quota allocations against user issues. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 --- Comment #9 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 178589 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178589&action=edit Bug 38924: DBIC Schema -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 --- Comment #10 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 178590 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178590&action=edit Bug 38924: Add Koha::Patron::Quota::Usage(s) classes Add ::Usage(s) classes for working with quota allocation usage. We overload store to ensure data consistency for the checkout_id field which is linked to either the issue or old_issue table appropriatly. We include a checkout relationship that handles the lack of foreign key due to issues/old_issues. We also add the Usage relations to Quota objects -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 --- Comment #11 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 178591 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178591&action=edit Bug 38924: Overload delete method in Koha::Old::Checkout This overloads the delete method for old::checkouts to ensure that the issue_id for quotas usage is nulled in the event that an old_checkout is deleted. Would like to make this the standard for all the tables we have had to handle issue/old_issues for but is currently just hard-coded for quotas as many of the other tables with issue_id columns are not nullable. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 --- Comment #12 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 178592 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178592&action=edit Bug 38924: Add AllowQuotaOverride and UseGuarantorQuota preferences Add a system preferences to allow/dissallow quota overflow at checkout and enable/disable the use of guarantor quotas against guarantees -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 --- Comment #13 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 178593 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178593&action=edit Bug 38924: Add get_patron_quotas method This commit adds the ability to return the guarantor's quota when searching for a patron's quota at checkout. This will only occur if the related syspref is enabled "UseGuaratorQuota" and will return in this order or priority: guarantor's quota with availability patrons's quota with availability guarantor's quota with no availability patron's quota with no availibility null -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 --- Comment #14 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 178594 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178594&action=edit Bug 38924: Hook quota check and allocation into checkout -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 --- Comment #15 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 178595 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178595&action=edit Bug 38924: Hook quota check and allocation into renewals This adds the checks for quotas and allocates a usage for a renewal of a book, should a quota exist for this patron -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 --- Comment #16 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 178596 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178596&action=edit Bug 38924: Add quota picker to checkout confirmation This patch adds the quota selector to the checkout confirmation for if multiple eligable quotas are available Bug 38924: Return all eligable quotas so that the staff user can pick This patch adds the logic to return multiple eligable quotas if there are more than 1, allowing the staff user to pick which to assign an item to. Bug 38924: Add searcher method for currently active quota for patron Bug 38924: amend circ logic to handle multiple eligable quotas This amends the circulations logic to handle the fact that we can return multiple eligable quotas now. This ensures that the same quotas as was used for the checkout will be used for the renewal (both check and assignment) and that we use the selected quota from our confirmation dropdown for checkout of new item Bug 38924: add better name display for quota select at checkout -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 --- Comment #17 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 178597 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178597&action=edit Bug 38924: Add koha_object_class to Schema files -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 --- Comment #18 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 178598 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178598&action=edit Bug 38924: Move from get_patron_quota to Koha::Patron relations Bug 38924: Deal with multiple quota options in QUOTA_EXCEEDED handling Bug 38924: Deal with using the same quota for renewals -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 --- Comment #19 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 178599 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178599&action=edit Bug 38924: Add quotas available on circuation screen -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 --- Comment #20 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 178600 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178600&action=edit Bug 38924: Add relations after the hash in DBIC This adds additional relations to our DBIC classes to allow relation traversal in our Koha::Objects -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 --- Comment #21 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 178601 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178601&action=edit Bug 38924: Add type and timestamp to usage table This allows us to more easily audit what actions incremented the usage and when. We will use this later in display -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 --- Comment #22 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 178602 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178602&action=edit Bug 38924: DBIC Dump -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 --- Comment #23 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 178603 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178603&action=edit Bug 38924: Add quota accessor to Koha::Checkout and use on checkouts page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 --- Comment #24 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 178604 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178604&action=edit Bug 38924: Display quota used at checkout Use the quota relation added to Koha::Checkout to display an info alert message that quota allocation has been used by the checkout that just took place -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 --- Comment #25 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 178605 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178605&action=edit Bug 38924: Add issue and old_issue relations to Schema -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 --- Comment #26 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 178606 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178606&action=edit Bug 38924: Add quota usage api endpoint -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 --- Comment #27 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 178607 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178607&action=edit Bug 38924: Add quota usage details modal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 --- Comment #28 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 178608 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178608&action=edit Bug 38924: Add option to enable/disable quotas -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #29 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- This was a team effort between Jacob and I -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178582|0 |1 is obsolete| | --- Comment #30 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 185631 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185631&action=edit Bug 38924: Add patron_quotas table Add the new patron_quotas table for storing circulation quotas -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178583|0 |1 is obsolete| | Attachment #178589|0 |1 is obsolete| | --- Comment #31 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 185632 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185632&action=edit Bug 38924: DBIC Schema DBIC update -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178584|0 |1 is obsolete| | --- Comment #32 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 185633 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185633&action=edit Bug 38924: Add Koha::Patron::Quota(s) classes Add initial Koha::Patron::Quota(s) classes for working with circulation quotas, including an overloaded store method to prevent overlapping quota periods. Additionally added a definition for the custom exception for if you are trying to store a quota whos active period overlaps with another for this patron -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178585|0 |1 is obsolete| | --- Comment #33 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 185634 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185634&action=edit Bug 38924: Add quotas permissions This patch adds the new quotas permissions to the system Rebased-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178586|0 |1 is obsolete| | --- Comment #34 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 185635 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185635&action=edit Bug 38924: Add API endpoints for managing quotas This commit adds the api endpoints for administering circulation quotas -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178587|0 |1 is obsolete| | --- Comment #35 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 185636 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185636&action=edit Bug 38924: Add patron quota management page Add a new patron quota management tab under the members area for patrons of the organization category type. FIXME: Tie into permissions for 'add', 'edit' Depending on permissions, we will need display only options including guarantor and guarantee usage against quotas and also the options to add and edit quota. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178588|0 |1 is obsolete| | --- Comment #36 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 185637 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185637&action=edit Bug 38924: Add patron_quota_usage table Add the new patron_quota_usage table for recording usage of quota allocations against user issues. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 --- Comment #37 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 185638 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185638&action=edit Bug 38924: DBIC Schema -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178590|0 |1 is obsolete| | --- Comment #38 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 185639 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185639&action=edit Bug 38924: Add Koha::Patron::Quota::Usage(s) classes Add ::Usage(s) classes for working with quota allocation usage. We overload store to ensure data consistency for the checkout_id field which is linked to either the issue or old_issue table appropriatly. We include a checkout relationship that handles the lack of foreign key due to issues/old_issues. We also add the Usage relations to Quota objects -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178591|0 |1 is obsolete| | --- Comment #39 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 185640 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185640&action=edit Bug 38924: Overload delete method in Koha::Old::Checkout This overloads the delete method for old::checkouts to ensure that the issue_id for quotas usage is nulled in the event that an old_checkout is deleted. Would like to make this the standard for all the tables we have had to handle issue/old_issues for but is currently just hard-coded for quotas as many of the other tables with issue_id columns are not nullable. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178592|0 |1 is obsolete| | --- Comment #40 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 185641 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185641&action=edit Bug 38924: Add AllowQuotaOverride and UseGuarantorQuota preferences Add a system preferences to allow/dissallow quota overflow at checkout and enable/disable the use of guarantor quotas against guarantees -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178593|0 |1 is obsolete| | --- Comment #41 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 185642 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185642&action=edit Bug 38924: Add get_patron_quotas method This commit adds the ability to return the guarantor's quota when searching for a patron's quota at checkout. This will only occur if the related syspref is enabled "UseGuaratorQuota" and will return in this order or priority: guarantor's quota with availability patrons's quota with availability guarantor's quota with no availability patron's quota with no availibility null -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178594|0 |1 is obsolete| | --- Comment #42 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 185643 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185643&action=edit Bug 38924: Hook quota check and allocation into checkout -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178595|0 |1 is obsolete| | --- Comment #43 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 185644 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185644&action=edit Bug 38924: Hook quota check and allocation into renewals This adds the checks for quotas and allocates a usage for a renewal of a book, should a quota exist for this patron -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178596|0 |1 is obsolete| | --- Comment #44 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 185645 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185645&action=edit Bug 38924: Add quota picker to checkout confirmation This patch adds the quota selector to the checkout confirmation for if multiple eligable quotas are available Bug 38924: Return all eligable quotas so that the staff user can pick This patch adds the logic to return multiple eligable quotas if there are more than 1, allowing the staff user to pick which to assign an item to. Bug 38924: Add searcher method for currently active quota for patron Bug 38924: amend circ logic to handle multiple eligable quotas This amends the circulations logic to handle the fact that we can return multiple eligable quotas now. This ensures that the same quotas as was used for the checkout will be used for the renewal (both check and assignment) and that we use the selected quota from our confirmation dropdown for checkout of new item Bug 38924: add better name display for quota select at checkout -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178597|0 |1 is obsolete| | --- Comment #45 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 185646 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185646&action=edit Bug 38924: Add koha_object_class to Schema files -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178598|0 |1 is obsolete| | --- Comment #46 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 185647 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185647&action=edit Bug 38924: Move from get_patron_quota to Koha::Patron relations Bug 38924: Deal with multiple quota options in QUOTA_EXCEEDED handling Bug 38924: Deal with using the same quota for renewals -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178599|0 |1 is obsolete| | --- Comment #47 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 185648 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185648&action=edit Bug 38924: Add quotas available on circuation screen -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178600|0 |1 is obsolete| | --- Comment #48 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 185649 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185649&action=edit Bug 38924: Add relations after the hash in DBIC This adds additional relations to our DBIC classes to allow relation traversal in our Koha::Objects Rebased-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178601|0 |1 is obsolete| | --- Comment #49 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 185650 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185650&action=edit Bug 38924: Add type and timestamp to usage table This allows us to more easily audit what actions incremented the usage and when. We will use this later in display -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178602|0 |1 is obsolete| | --- Comment #50 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 185651 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185651&action=edit Bug 38924: DBIC Dump -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178603|0 |1 is obsolete| | --- Comment #51 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 185652 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185652&action=edit Bug 38924: Add quota accessor to Koha::Checkout and use on checkouts page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178604|0 |1 is obsolete| | --- Comment #52 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 185653 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185653&action=edit Bug 38924: Display quota used at checkout Use the quota relation added to Koha::Checkout to display an info alert message that quota allocation has been used by the checkout that just took place Rebased-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178605|0 |1 is obsolete| | --- Comment #53 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 185654 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185654&action=edit Bug 38924: Add issue and old_issue relations to Schema -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178606|0 |1 is obsolete| | --- Comment #54 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 185655 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185655&action=edit Bug 38924: Add quota usage api endpoint -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178607|0 |1 is obsolete| | --- Comment #55 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 185656 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185656&action=edit Bug 38924: Add quota usage details modal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178608|0 |1 is obsolete| | --- Comment #56 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 185657 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185657&action=edit Bug 38924: Add option to enable/disable quotas -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185631|0 |1 is obsolete| | --- Comment #57 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 185675 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185675&action=edit Bug 38924: Add patron_quotas table Add the new patron_quotas table for storing circulation quotas -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185632|0 |1 is obsolete| | Attachment #185638|0 |1 is obsolete| | --- Comment #58 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 185676 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185676&action=edit Bug 38924: DBIC Schema DBIC update -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185633|0 |1 is obsolete| | --- Comment #59 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 185677 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185677&action=edit Bug 38924: Add Koha::Patron::Quota(s) classes Add initial Koha::Patron::Quota(s) classes for working with circulation quotas, including an overloaded store method to prevent overlapping quota periods. Additionally added a definition for the custom exception for if you are trying to store a quota whos active period overlaps with another for this patron -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185634|0 |1 is obsolete| | --- Comment #60 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 185678 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185678&action=edit Bug 38924: Add quotas permissions This patch adds the new quotas permissions to the system Rebased-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185635|0 |1 is obsolete| | --- Comment #61 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 185679 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185679&action=edit Bug 38924: Add API endpoints for managing quotas This commit adds the api endpoints for administering circulation quotas -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185636|0 |1 is obsolete| | --- Comment #62 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 185680 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185680&action=edit Bug 38924: Add patron quota management page Add a new patron quota management tab under the members area for patrons of the organization category type. FIXME: Tie into permissions for 'add', 'edit' Depending on permissions, we will need display only options including guarantor and guarantee usage against quotas and also the options to add and edit quota. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185637|0 |1 is obsolete| | --- Comment #63 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 185681 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185681&action=edit Bug 38924: Add patron_quota_usage table Add the new patron_quota_usage table for recording usage of quota allocations against user issues. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 --- Comment #64 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 185682 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185682&action=edit Bug 38924: DBIC Schema -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185639|0 |1 is obsolete| | --- Comment #65 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 185683 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185683&action=edit Bug 38924: Add Koha::Patron::Quota::Usage(s) classes Add ::Usage(s) classes for working with quota allocation usage. We overload store to ensure data consistency for the checkout_id field which is linked to either the issue or old_issue table appropriatly. We include a checkout relationship that handles the lack of foreign key due to issues/old_issues. We also add the Usage relations to Quota objects -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185640|0 |1 is obsolete| | --- Comment #66 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 185684 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185684&action=edit Bug 38924: Overload delete method in Koha::Old::Checkout This overloads the delete method for old::checkouts to ensure that the issue_id for quotas usage is nulled in the event that an old_checkout is deleted. Would like to make this the standard for all the tables we have had to handle issue/old_issues for but is currently just hard-coded for quotas as many of the other tables with issue_id columns are not nullable. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185641|0 |1 is obsolete| | --- Comment #67 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 185685 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185685&action=edit Bug 38924: Add AllowQuotaOverride and UseGuarantorQuota preferences Add a system preferences to allow/dissallow quota overflow at checkout and enable/disable the use of guarantor quotas against guarantees -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185642|0 |1 is obsolete| | --- Comment #68 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 185686 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185686&action=edit Bug 38924: Add get_patron_quotas method This commit adds the ability to return the guarantor's quota when searching for a patron's quota at checkout. This will only occur if the related syspref is enabled "UseGuaratorQuota" and will return in this order or priority: guarantor's quota with availability patrons's quota with availability guarantor's quota with no availability patron's quota with no availibility null -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185643|0 |1 is obsolete| | --- Comment #69 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 185687 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185687&action=edit Bug 38924: Hook quota check and allocation into checkout -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185644|0 |1 is obsolete| | --- Comment #70 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 185688 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185688&action=edit Bug 38924: Hook quota check and allocation into renewals This adds the checks for quotas and allocates a usage for a renewal of a book, should a quota exist for this patron -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185645|0 |1 is obsolete| | --- Comment #71 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 185689 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185689&action=edit Bug 38924: Add quota picker to checkout confirmation This patch adds the quota selector to the checkout confirmation for if multiple eligable quotas are available Bug 38924: Return all eligable quotas so that the staff user can pick This patch adds the logic to return multiple eligable quotas if there are more than 1, allowing the staff user to pick which to assign an item to. Bug 38924: Add searcher method for currently active quota for patron Bug 38924: amend circ logic to handle multiple eligable quotas This amends the circulations logic to handle the fact that we can return multiple eligable quotas now. This ensures that the same quotas as was used for the checkout will be used for the renewal (both check and assignment) and that we use the selected quota from our confirmation dropdown for checkout of new item Bug 38924: add better name display for quota select at checkout -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185646|0 |1 is obsolete| | --- Comment #72 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 185690 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185690&action=edit Bug 38924: Add koha_object_class to Schema files -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185647|0 |1 is obsolete| | --- Comment #73 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 185691 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185691&action=edit Bug 38924: Move from get_patron_quota to Koha::Patron relations Bug 38924: Deal with multiple quota options in QUOTA_EXCEEDED handling Bug 38924: Deal with using the same quota for renewals -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185648|0 |1 is obsolete| | --- Comment #74 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 185692 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185692&action=edit Bug 38924: Add quotas available on circuation screen -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185649|0 |1 is obsolete| | --- Comment #75 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 185693 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185693&action=edit Bug 38924: Add relations after the hash in DBIC This adds additional relations to our DBIC classes to allow relation traversal in our Koha::Objects Rebased-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185650|0 |1 is obsolete| | --- Comment #76 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 185694 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185694&action=edit Bug 38924: Add type and timestamp to usage table This allows us to more easily audit what actions incremented the usage and when. We will use this later in display -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185651|0 |1 is obsolete| | --- Comment #77 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 185695 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185695&action=edit Bug 38924: DBIC Dump -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185652|0 |1 is obsolete| | --- Comment #78 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 185696 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185696&action=edit Bug 38924: Add quota accessor to Koha::Checkout and use on checkouts page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185653|0 |1 is obsolete| | --- Comment #79 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 185697 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185697&action=edit Bug 38924: Display quota used at checkout Use the quota relation added to Koha::Checkout to display an info alert message that quota allocation has been used by the checkout that just took place Rebased-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185654|0 |1 is obsolete| | --- Comment #80 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 185698 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185698&action=edit Bug 38924: Add issue and old_issue relations to Schema -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185655|0 |1 is obsolete| | --- Comment #81 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 185699 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185699&action=edit Bug 38924: Add quota usage api endpoint -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185656|0 |1 is obsolete| | --- Comment #82 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 185700 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185700&action=edit Bug 38924: Add quota usage details modal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185657|0 |1 is obsolete| | --- Comment #83 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 185701 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185701&action=edit Bug 38924: Add option to enable/disable quotas -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 --- Comment #84 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 185702 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185702&action=edit Bug 38924: Remove duplicate sub It also made the tests fail -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net --- Comment #85 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Rebased. Compared old patches to new patches to ensure no unintended introduced changes. There are some differences. But it seems it's not from solving conflicts but more the other changes in Koha somehow causing a change generated schema code to move from one commit to another. Anyway, same final state. https://gitlab.com/tuxayo/Koha/-/commit/a8314615be7286edde4f00338f91d3143606... https://gitlab.com/tuxayo/Koha/-/commit/17092c96432275b77e8297a9e388e8a76e2f... https://gitlab.com/tuxayo/Koha/-/commit/acedb3f90e07d6ed2b26ab0427ad8dadc86e... https://gitlab.com/tuxayo/Koha/-/commit/49afbbcb06d0b19e35dc8c0df543c3594f9b... Tests pass. Anything else to run than t/Koha/Auth/Permissions.t ? Doesn't mean everything works as on 2025-02-24. In case it's needed later, relevant branch: https://gitlab.com/tuxayo/Koha/-/commits/bug_38924-old-2025-02-24 Any test plan besides following the high level user stories of the document in comment 1? If it's that, at least that should be mentioned in a commit message in a test plan section. Or copy the user story there. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #86 from Victor Grousset/tuxayo <victor@tuxayo.net> --- There are 3 DBIC generation commits (which generate 3 times conflicts VS having one). And they don't have DO NOT PUSH in the name. https://wiki.koha-community.org/wiki/Database_updates#Files_to_change -- Since February, bug 39367 landed, providing that test: kohadev-koha@kohadevbox:koha(bug_38924-rebase-wip)$ time prove xt/author/pod_coverage.t xt/author/pod_coverage.t .. 864/1249 # Failed test 'POD coverage for Koha/Schema/Result/PatronQuota.pm' # at xt/author/pod_coverage.t line 35. # got: '1' # expected: '0' # koha_objects_class # Failed test 'POD coverage for Koha/Schema/Result/PatronQuotaUsage.pm' # at xt/author/pod_coverage.t line 35. # got: '2' # expected: '0' # koha_objects_class, koha_object_class xt/author/pod_coverage.t .. 1241/1249 # Looks like you failed 2 tests of 1249. xt/author/pod_coverage.t .. Dubious, test returned 2 (wstat 512, 0x200) Failed 2/1249 subtests Test Summary Report ------------------- xt/author/pod_coverage.t (Wstat: 512 (exited 2) Tests: 1249 Failed: 2) Failed tests: 1015-1016 Non-zero exit status: 2 Files=1, Tests=1249, 8 wallclock secs ( 0.23 usr 0.02 sys + 6.43 cusr 0.63 csys = 7.31 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185675|0 |1 is obsolete| | --- Comment #87 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 189266 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189266&action=edit Bug 38924: Add patron_quotas table Add the new patron_quotas table for storing circulation quotas -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185677|0 |1 is obsolete| | --- Comment #88 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 189267 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189267&action=edit Bug 38924: Add Koha::Patron::Quota(s) classes Add initial Koha::Patron::Quota(s) classes for working with circulation quotas, including an overloaded store method to prevent overlapping quota periods. Additionally added a definition for the custom exception for if you are trying to store a quota whos active period overlaps with another for this patron -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185678|0 |1 is obsolete| | --- Comment #89 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 189268 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189268&action=edit Bug 38924: Add quotas permissions This patch adds the new quotas permissions to the system -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185679|0 |1 is obsolete| | --- Comment #90 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 189269 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189269&action=edit Bug 38924: Add API endpoints for managing quotas This commit adds the api endpoints for administering circulation quotas -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185680|0 |1 is obsolete| | --- Comment #91 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 189270 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189270&action=edit Bug 38924: Add patron quota management page Add a new patron quota management tab under the members area for patrons of the organization category type. FIXME: Tie into permissions for 'add', 'edit' Depending on permissions, we will need display only options including guarantor and guarantee usage against quotas and also the options to add and edit quota. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185681|0 |1 is obsolete| | --- Comment #92 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 189271 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189271&action=edit Bug 38924: Add patron_quota_usage table Add the new patron_quota_usage table for recording usage of quota allocations against user issues. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185683|0 |1 is obsolete| | --- Comment #93 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 189272 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189272&action=edit Bug 38924: Add Koha::Patron::Quota::Usage(s) classes Add ::Usage(s) classes for working with quota allocation usage. We overload store to ensure data consistency for the checkout_id field which is linked to either the issue or old_issue table appropriatly. We include a checkout relationship that handles the lack of foreign key due to issues/old_issues. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185684|0 |1 is obsolete| | --- Comment #94 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 189273 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189273&action=edit Bug 38924: Overload delete method in Koha::Old::Checkout This overloads the delete method for old::checkouts to ensure that the issue_id for quotas usage is nulled in the event that an old_checkout is deleted. Would like to make this the standard for all the tables we have had to handle issue/old_issues for but is currently just hard-coded for quotas as many of the other tables with issue_id columns are not nullable. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 --- Comment #95 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 189274 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189274&action=edit Bug 38924: Add Usage relations to Quota objects -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185685|0 |1 is obsolete| | --- Comment #96 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 189275 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189275&action=edit Bug 38924: Add AllowQuotaOverride and UseGuarantorQuota preferences Add a system preferences to allow/dissallow quota overflow at checkout and enable/disable the use of guarantor quotas against guarantees -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185686|0 |1 is obsolete| | --- Comment #97 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 189276 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189276&action=edit Bug 38924: Add get_patron_quotas method This commit adds the ability to return the guarantor's quota when searching for a patron's quota at checkout. This will only occur if the related syspref is enabled "UseGuaratorQuota" and will return in this order or priority: guarantor's quota with availability patrons's quota with availability guarantor's quota with no availability patron's quota with no availibility null -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185687|0 |1 is obsolete| | --- Comment #98 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 189277 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189277&action=edit Bug 38924: Hook quota check and allocation into checkout -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185688|0 |1 is obsolete| | --- Comment #99 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 189278 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189278&action=edit Bug 38924: Hook quota check and allocation into renewals This adds the checks for quotas and allocates a usage for a renewal of a book, should a quota exist for this patron -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185689|0 |1 is obsolete| | --- Comment #100 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 189279 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189279&action=edit Bug 38924: Add quota picker to checkout confirmation This patch adds the quota selector to the checkout confirmation for if multiple eligable quotas are available Bug 38924: Return all eligable quotas so that the staff user can pick This patch adds the logic to return multiple eligable quotas if there are more than 1, allowing the staff user to pick which to assign an item to. Bug 38924: Add searcher method for currently active quota for patron Bug 38924: amend circ logic to handle multiple eligable quotas This amends the circulations logic to handle the fact that we can return multiple eligable quotas now. This ensures that the same quotas as was used for the checkout will be used for the renewal (both check and assignment) and that we use the selected quota from our confirmation dropdown for checkout of new item Bug 38924: add better name display for quota select at checkout -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185691|0 |1 is obsolete| | --- Comment #101 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 189280 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189280&action=edit Bug 38924: Move from get_patron_quota to Koha::Patron relations Bug 38924: Deal with multiple quota options in QUOTA_EXCEEDED handling Bug 38924: Deal with using the same quota for renewals -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185692|0 |1 is obsolete| | --- Comment #102 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 189281 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189281&action=edit Bug 38924: Add quotas available on circuation screen -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185694|0 |1 is obsolete| | --- Comment #103 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 189282 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189282&action=edit Bug 38924: Add type and timestamp to usage table This allows us to more easily audit what actions incremented the usage and when. We will use this later in display -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185696|0 |1 is obsolete| | --- Comment #104 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 189283 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189283&action=edit Bug 38924: Add quota accessor to Koha::Checkout and use on checkouts page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185697|0 |1 is obsolete| | --- Comment #105 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 189284 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189284&action=edit Bug 38924: Display quota used at checkout Use the quota relation added to Koha::Checkout to display an info alert message that quota allocation has been used by the checkout that just took place -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185700|0 |1 is obsolete| | --- Comment #106 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 189285 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189285&action=edit Bug 38924: Add quota usage details modal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185701|0 |1 is obsolete| | --- Comment #107 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 189286 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189286&action=edit Bug 38924: Add option to enable/disable quotas -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 --- Comment #108 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 189287 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189287&action=edit Bug 38924: DBIC - DO NOT PUSH -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185693|0 |1 is obsolete| | --- Comment #109 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 189288 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189288&action=edit Bug 38924: Add relations after the hash in DBIC This adds additional relations to our DBIC classes to allow relation traversal in our Koha::Objects -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185698|0 |1 is obsolete| | --- Comment #110 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 189289 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189289&action=edit Bug 38924: Add issue and old_issue relations to Schema -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185690|0 |1 is obsolete| | --- Comment #111 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 189290 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189290&action=edit Bug 38924: Add koha_object_class to Schema files -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185699|0 |1 is obsolete| | --- Comment #112 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 189291 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189291&action=edit Bug 38924: Add quota usage api endpoint -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 --- Comment #113 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 189292 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189292&action=edit Bug 38924: (follow-up) Minor QOL quota modal fixes This patch: - Makes sure that the quotas modal displays the error message for why the submit failed, instead of a generic message - Clears the modal data on modal close to remove persistent data - Get dates directly from flatpickr selectedDates for API requests to ensure sync. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185676|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185682|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185695|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185702|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 --- Comment #114 from Victor Grousset/tuxayo <victor@tuxayo.net> --- After comparing the diffs, "Bug 38924: DBIC - DO NOT PUSH" include all changes from the 3 duplicates. The patches weren't marked as obsolete so they would have conflicted. -- The content of "Bug 38924: Remove duplicate sub" seem to have been done inline. So I obsoleted my follow-up that was hanging in the ticket. -- Any test plan besides following the high level user stories of the document in comment 1? If it's that, at least that should be mentioned in a commit message in a test plan section. Or copy the user story there. -- New Test failure: kohadev-koha@kohadevbox:koha(testing-SO-QA)$ prove t/Koha/Auth/Permissions.t t/Koha/Auth/Permissions.t .. 1/4 # Failed test 'Expected permissions generated for superlibrarian' # at t/Koha/Auth/Permissions.t line 308. # Structures begin differing at: # $got->{CAN_user_borrowers_manage_borrower_quotas} = Does not exist # $expected->{CAN_user_borrowers_manage_borrower_quotas} = '1' # Looks like you failed 1 test of 1. # Failed test 'superlibrarian tests' # at t/Koha/Auth/Permissions.t line 309. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189266|0 |1 is obsolete| | --- Comment #115 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 193377 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193377&action=edit Bug 38924: Add patron_quotas table Setup: 1. Enable EnableCirculationQuotas, AllowQuotaOverride, and UseGuarantorQuota in system preferences 2. Create an Institutional patron (ORG) and a second Institutional patron (MEMBER) as guarantee of ORG 3. Create a non-institutional patron (NORELATION) with no relationships Quota management: 4. Open ORG's detail page → verify "Circulation quota" tab visible in sidebar 5. Open NORELATION's detail page → verify no quota tab 6. Disable EnableCirculationQuotas → open ORG → verify no quota tab. Re-enable before continuing 7. Add a quota for ORG: Q1 2026, allocation 10 → verify it appears in the table 8. Add a second quota with overlapping dates → verify rejected with clash error 9. Edit the quota → verify modal prefills all fields including end date, save updates correctly 10. Add a future non-overlapping quota with no usage → verify Delete button appears. Delete it. Verify Delete button is absent on quotas that have usage Checkout with single quota: 11. Checkout an item to ORG → verify checkout succeeds, quota used increments, ISSUE usage record visible in details 12. Exhaust ORG's quota, set AllowQuotaOverride ON → attempt checkout → verify confirmation prompt, can override 13. With quota still exhausted, set AllowQuotaOverride OFF → attempt checkout → verify blocked, cannot proceed Checkout with guarantor quotas: 14. Give MEMBER their own active quota (allocation 5). 15. Checkout to MEMBER → verify QUOTA_SELECT prompt to choose between own and guarantor quota Renewals and returns: 16. Renew an existing checkout that has quota usage → verify used increments and new RENEW usage record created 17. Return a checked-out item → verify quota used value is unchanged Add the new patron_quotas table for storing circulation quotas -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189267|0 |1 is obsolete| | --- Comment #116 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 193378 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193378&action=edit Bug 38924: Add Koha::Patron::Quota(s) classes Add initial Koha::Patron::Quota(s) classes for working with circulation quotas, including an overloaded store method to prevent overlapping quota periods. Additionally added a definition for the custom exception for if you are trying to store a quota whos active period overlaps with another for this patron -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189268|0 |1 is obsolete| | --- Comment #117 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 193379 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193379&action=edit Bug 38924: Add quotas permissions This patch adds the new quotas permissions to the system -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189269|0 |1 is obsolete| | --- Comment #118 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 193380 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193380&action=edit Bug 38924: Add API endpoints for managing quotas This commit adds the api endpoints for administering circulation quotas -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189270|0 |1 is obsolete| | --- Comment #119 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 193381 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193381&action=edit Bug 38924: Add patron quota management page Add a new patron quota management tab under the members area for patrons of the organization category type. FIXME: Tie into permissions for 'add', 'edit' Depending on permissions, we will need display only options including guarantor and guarantee usage against quotas and also the options to add and edit quota. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189271|0 |1 is obsolete| | --- Comment #120 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 193382 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193382&action=edit Bug 38924: Add patron_quota_usage table Add the new patron_quota_usage table for recording usage of quota allocations against user issues. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189272|0 |1 is obsolete| | --- Comment #121 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 193383 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193383&action=edit Bug 38924: Add Koha::Patron::Quota::Usage(s) classes Add ::Usage(s) classes for working with quota allocation usage. We overload store to ensure data consistency for the checkout_id field which is linked to either the issue or old_issue table appropriatly. We include a checkout relationship that handles the lack of foreign key due to issues/old_issues. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189273|0 |1 is obsolete| | --- Comment #122 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 193384 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193384&action=edit Bug 38924: Overload delete method in Koha::Old::Checkout This overloads the delete method for old::checkouts to ensure that the issue_id for quotas usage is nulled in the event that an old_checkout is deleted. Would like to make this the standard for all the tables we have had to handle issue/old_issues for but is currently just hard-coded for quotas as many of the other tables with issue_id columns are not nullable. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189274|0 |1 is obsolete| | --- Comment #123 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 193385 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193385&action=edit Bug 38924: Add Usage relations to Quota objects -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189275|0 |1 is obsolete| | --- Comment #124 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 193386 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193386&action=edit Bug 38924: Add AllowQuotaOverride and UseGuarantorQuota preferences Add a system preferences to allow/dissallow quota overflow at checkout and enable/disable the use of guarantor quotas against guarantees -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189276|0 |1 is obsolete| | --- Comment #125 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 193387 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193387&action=edit Bug 38924: Add get_patron_quotas method This commit adds the ability to return the guarantor's quota when searching for a patron's quota at checkout. This will only occur if the related syspref is enabled "UseGuaratorQuota" and will return in this order or priority: guarantor's quota with availability patrons's quota with availability guarantor's quota with no availability patron's quota with no availibility null -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189277|0 |1 is obsolete| | --- Comment #126 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 193388 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193388&action=edit Bug 38924: Hook quota check and allocation into checkout -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189278|0 |1 is obsolete| | --- Comment #127 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 193389 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193389&action=edit Bug 38924: Hook quota check and allocation into renewals This adds the checks for quotas and allocates a usage for a renewal of a book, should a quota exist for this patron -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189279|0 |1 is obsolete| | --- Comment #128 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 193390 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193390&action=edit Bug 38924: Add quota picker to checkout confirmation This patch adds the quota selector to the checkout confirmation for if multiple eligable quotas are available Bug 38924: Return all eligable quotas so that the staff user can pick This patch adds the logic to return multiple eligable quotas if there are more than 1, allowing the staff user to pick which to assign an item to. Bug 38924: Add searcher method for currently active quota for patron Bug 38924: amend circ logic to handle multiple eligable quotas This amends the circulations logic to handle the fact that we can return multiple eligable quotas now. This ensures that the same quotas as was used for the checkout will be used for the renewal (both check and assignment) and that we use the selected quota from our confirmation dropdown for checkout of new item Bug 38924: add better name display for quota select at checkout -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189280|0 |1 is obsolete| | --- Comment #129 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 193391 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193391&action=edit Bug 38924: Move from get_patron_quota to Koha::Patron relations Bug 38924: Deal with multiple quota options in QUOTA_EXCEEDED handling Bug 38924: Deal with using the same quota for renewals -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189281|0 |1 is obsolete| | --- Comment #130 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 193392 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193392&action=edit Bug 38924: Add quotas available on circuation screen -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189282|0 |1 is obsolete| | --- Comment #131 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 193393 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193393&action=edit Bug 38924: Add type and timestamp to usage table This allows us to more easily audit what actions incremented the usage and when. We will use this later in display -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189283|0 |1 is obsolete| | --- Comment #132 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 193394 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193394&action=edit Bug 38924: Add quota accessor to Koha::Checkout and use on checkouts page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189284|0 |1 is obsolete| | --- Comment #133 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 193395 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193395&action=edit Bug 38924: Display quota used at checkout Use the quota relation added to Koha::Checkout to display an info alert message that quota allocation has been used by the checkout that just took place -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189285|0 |1 is obsolete| | --- Comment #134 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 193396 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193396&action=edit Bug 38924: Add quota usage details modal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189286|0 |1 is obsolete| | --- Comment #135 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 193397 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193397&action=edit Bug 38924: Add option to enable/disable quotas -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193377|0 |1 is obsolete| | --- Comment #136 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 193398 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193398&action=edit Bug 38924: Add patron_quotas table Add the new patron_quotas table for storing circulation quotas -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193378|0 |1 is obsolete| | --- Comment #137 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 193399 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193399&action=edit Bug 38924: Add Koha::Patron::Quota(s) classes Add initial Koha::Patron::Quota(s) classes for working with circulation quotas, including an overloaded store method to prevent overlapping quota periods. Additionally added a definition for the custom exception for if you are trying to store a quota whos active period overlaps with another for this patron -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193379|0 |1 is obsolete| | --- Comment #138 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 193400 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193400&action=edit Bug 38924: Add quotas permissions This patch adds the new quotas permissions to the system -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193380|0 |1 is obsolete| | --- Comment #139 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 193401 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193401&action=edit Bug 38924: Add API endpoints for managing quotas This commit adds the api endpoints for administering circulation quotas -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193381|0 |1 is obsolete| | --- Comment #140 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 193402 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193402&action=edit Bug 38924: Add patron quota management page Add a new patron quota management tab under the members area for patrons of the organization category type. FIXME: Tie into permissions for 'add', 'edit' Depending on permissions, we will need display only options including guarantor and guarantee usage against quotas and also the options to add and edit quota. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193398|0 |1 is obsolete| | --- Comment #141 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 193403 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193403&action=edit Bug 38924: Add patron_quotas table Add the new patron_quotas table for storing circulation quotas Setup: 1. Enable EnableCirculationQuotas, AllowQuotaOverride, and UseGuarantorQuota in system preferences 2. Create an Institutional patron (ORG) and a second Institutional patron (MEMBER) as guarantee of ORG 3. Create a non-institutional patron (NORELATION) with no relationships Quota management: 4. Open ORG's detail page → verify "Circulation quota" tab visible in sidebar 5. Open NORELATION's detail page → verify no quota tab 6. Disable EnableCirculationQuotas → open ORG → verify no quota tab. Re-enable before continuing 7. Add a quota for ORG: Q1 2026, allocation 10 → verify it appears in the table 8. Add a second quota with overlapping dates → verify rejected with clash error 9. Edit the quota → verify modal prefills all fields including end date, save updates correctly 10. Add a future non-overlapping quota with no usage → verify Delete button appears. Delete it. Verify Delete button is absent on quotas that have usage Checkout with single quota: 11. Checkout an item to ORG → verify checkout succeeds, quota used increments, ISSUE usage record visible in details 12. Exhaust ORG's quota, set AllowQuotaOverride ON → attempt checkout → verify confirmation prompt, can override 13. With quota still exhausted, set AllowQuotaOverride OFF → attempt checkout → verify blocked, cannot proceed Checkout with guarantor quotas: 14. Give MEMBER their own active quota (allocation 5). 15. Checkout to MEMBER → verify QUOTA_SELECT prompt to choose between own and guarantor quota Renewals and returns: 16. Renew an existing checkout that has quota usage → verify used increments and new RENEW usage record created 17. Return a checked-out item → verify quota used value is unchanged -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193399|0 |1 is obsolete| | --- Comment #142 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 193404 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193404&action=edit Bug 38924: Add Koha::Patron::Quota(s) classes Add initial Koha::Patron::Quota(s) classes for working with circulation quotas, including an overloaded store method to prevent overlapping quota periods. Additionally added a definition for the custom exception for if you are trying to store a quota whos active period overlaps with another for this patron -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193400|0 |1 is obsolete| | --- Comment #143 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 193405 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193405&action=edit Bug 38924: Add quotas permissions This patch adds the new quotas permissions to the system -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193401|0 |1 is obsolete| | --- Comment #144 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 193406 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193406&action=edit Bug 38924: Add API endpoints for managing quotas This commit adds the api endpoints for administering circulation quotas -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193402|0 |1 is obsolete| | --- Comment #145 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 193407 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193407&action=edit Bug 38924: Add patron quota management page Add a new patron quota management tab under the members area for patrons of the organization category type. FIXME: Tie into permissions for 'add', 'edit' Depending on permissions, we will need display only options including guarantor and guarantee usage against quotas and also the options to add and edit quota. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193382|0 |1 is obsolete| | --- Comment #146 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 193408 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193408&action=edit Bug 38924: Add patron_quota_usage table Add the new patron_quota_usage table for recording usage of quota allocations against user issues. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193383|0 |1 is obsolete| | --- Comment #147 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 193409 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193409&action=edit Bug 38924: Add Koha::Patron::Quota::Usage(s) classes Add ::Usage(s) classes for working with quota allocation usage. We overload store to ensure data consistency for the checkout_id field which is linked to either the issue or old_issue table appropriatly. We include a checkout relationship that handles the lack of foreign key due to issues/old_issues. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193384|0 |1 is obsolete| | --- Comment #148 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 193410 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193410&action=edit Bug 38924: Overload delete method in Koha::Old::Checkout This overloads the delete method for old::checkouts to ensure that the issue_id for quotas usage is nulled in the event that an old_checkout is deleted. Would like to make this the standard for all the tables we have had to handle issue/old_issues for but is currently just hard-coded for quotas as many of the other tables with issue_id columns are not nullable. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193385|0 |1 is obsolete| | --- Comment #149 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 193411 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193411&action=edit Bug 38924: Add Usage relations to Quota objects -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193386|0 |1 is obsolete| | --- Comment #150 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 193412 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193412&action=edit Bug 38924: Add AllowQuotaOverride and UseGuarantorQuota preferences Add a system preferences to allow/dissallow quota overflow at checkout and enable/disable the use of guarantor quotas against guarantees -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193387|0 |1 is obsolete| | --- Comment #151 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 193413 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193413&action=edit Bug 38924: Add get_patron_quotas method This commit adds the ability to return the guarantor's quota when searching for a patron's quota at checkout. This will only occur if the related syspref is enabled "UseGuaratorQuota" and will return in this order or priority: guarantor's quota with availability patrons's quota with availability guarantor's quota with no availability patron's quota with no availibility null -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193388|0 |1 is obsolete| | --- Comment #152 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 193414 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193414&action=edit Bug 38924: Hook quota check and allocation into checkout -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193389|0 |1 is obsolete| | --- Comment #153 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 193415 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193415&action=edit Bug 38924: Hook quota check and allocation into renewals This adds the checks for quotas and allocates a usage for a renewal of a book, should a quota exist for this patron -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193390|0 |1 is obsolete| | --- Comment #154 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 193416 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193416&action=edit Bug 38924: Add quota picker to checkout confirmation This patch adds the quota selector to the checkout confirmation for if multiple eligable quotas are available Bug 38924: Return all eligable quotas so that the staff user can pick This patch adds the logic to return multiple eligable quotas if there are more than 1, allowing the staff user to pick which to assign an item to. Bug 38924: Add searcher method for currently active quota for patron Bug 38924: amend circ logic to handle multiple eligable quotas This amends the circulations logic to handle the fact that we can return multiple eligable quotas now. This ensures that the same quotas as was used for the checkout will be used for the renewal (both check and assignment) and that we use the selected quota from our confirmation dropdown for checkout of new item Bug 38924: add better name display for quota select at checkout -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193391|0 |1 is obsolete| | --- Comment #155 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 193417 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193417&action=edit Bug 38924: Move from get_patron_quota to Koha::Patron relations Bug 38924: Deal with multiple quota options in QUOTA_EXCEEDED handling Bug 38924: Deal with using the same quota for renewals -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193392|0 |1 is obsolete| | --- Comment #156 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 193418 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193418&action=edit Bug 38924: Add quotas available on circuation screen -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193393|0 |1 is obsolete| | --- Comment #157 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 193419 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193419&action=edit Bug 38924: Add type and timestamp to usage table This allows us to more easily audit what actions incremented the usage and when. We will use this later in display -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193394|0 |1 is obsolete| | --- Comment #158 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 193420 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193420&action=edit Bug 38924: Add quota accessor to Koha::Checkout and use on checkouts page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193395|0 |1 is obsolete| | --- Comment #159 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 193421 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193421&action=edit Bug 38924: Display quota used at checkout Use the quota relation added to Koha::Checkout to display an info alert message that quota allocation has been used by the checkout that just took place -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193396|0 |1 is obsolete| | --- Comment #160 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 193422 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193422&action=edit Bug 38924: Add quota usage details modal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193397|0 |1 is obsolete| | --- Comment #161 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 193423 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193423&action=edit Bug 38924: Add option to enable/disable quotas -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 --- Comment #162 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 193424 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193424&action=edit Bug 38924: Add tests for quotas object classes and api endpoints -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189287|0 |1 is obsolete| | --- Comment #163 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 193425 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193425&action=edit Bug 38924: DBIC - DO NOT PUSH -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189288|0 |1 is obsolete| | --- Comment #164 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 193426 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193426&action=edit Bug 38924: Add relations after the hash in DBIC This adds additional relations to our DBIC classes to allow relation traversal in our Koha::Objects -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189289|0 |1 is obsolete| | --- Comment #165 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 193427 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193427&action=edit Bug 38924: Add issue and old_issue relations to Schema -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189290|0 |1 is obsolete| | --- Comment #166 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 193428 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193428&action=edit Bug 38924: Add koha_object_class to Schema files -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189291|0 |1 is obsolete| | --- Comment #167 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 193429 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193429&action=edit Bug 38924: Add quota usage api endpoint -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189292|0 |1 is obsolete| | --- Comment #168 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 193430 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193430&action=edit Bug 38924: (follow-up) Minor QOL quota modal fixes - Makes sure that the quotas modal displays the error message for why the submit failed, instead of a generic message - Clears the modal data on modal close to remove persistent data - Get dates directly from flatpickr selectedDates for API requests to ensure sync. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 --- Comment #169 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 193431 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193431&action=edit Bug 38924: (follow-up) Fix edit modal not autofilling end date The flatpickr setDate calls were passing triggerChange=1 which caused the start picker's hooks to interfere with the end picker before its value could be set. Remove triggerChange to match the pattern used by other Koha date pickers (members.js, datatables.js). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #170 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Test plan is hidden in the ~200 comments so posting at the bottom as well for easier finding! Setup: 1. Enable EnableCirculationQuotas, AllowQuotaOverride, and UseGuarantorQuota in system preferences 2. Create an Institutional patron (ORG) and a second Institutional patron (MEMBER) as guarantee of ORG 3. Create a non-institutional patron (NORELATION) with no relationships Quota management: 4. Open ORG's detail page → verify "Circulation quota" tab visible in sidebar 5. Open NORELATION's detail page → verify no quota tab 6. Disable EnableCirculationQuotas → open ORG → verify no quota tab. Re-enable before continuing 7. Add a quota for ORG: Q1 2026, allocation 10 → verify it appears in the table 8. Add a second quota with overlapping dates → verify rejected with clash error 9. Edit the quota → verify modal prefills all fields including end date, save updates correctly 10. Add a future non-overlapping quota with no usage → verify Delete button appears. Delete it. Verify Delete button is absent on quotas that have usage Checkout with single quota: 11. Checkout an item to ORG → verify checkout succeeds, quota used increments, ISSUE usage record visible in details 12. Exhaust ORG's quota, set AllowQuotaOverride ON → attempt checkout → verify confirmation prompt, can override 13. With quota still exhausted, set AllowQuotaOverride OFF → attempt checkout → verify blocked, cannot proceed Checkout with guarantor quotas: 14. Give MEMBER their own active quota (allocation 5). 15. Checkout to MEMBER → verify QUOTA_SELECT prompt to choose between own and guarantor quota Renewals and returns: 16. Renew an existing checkout that has quota usage → verify used increments and new RENEW usage record created 17. Return a checked-out item → verify quota used value is unchanged Add the new patron_quotas table for storing circulation quotas -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey@cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193403|0 |1 is obsolete| | --- Comment #171 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 193432 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193432&action=edit Bug 38924: Add patron_quotas table Add the new patron_quotas table for storing circulation quotas Setup: 1. Enable EnableCirculationQuotas, AllowQuotaOverride, and UseGuarantorQuota in system preferences 2. Create an Institutional patron (ORG) and a second Institutional patron (MEMBER) as guarantee of ORG 3. Create a non-institutional patron (NORELATION) with no relationships Quota management: 4. Open ORG's detail page → verify "Circulation quota" tab visible in sidebar 5. Open NORELATION's detail page → verify no quota tab 6. Disable EnableCirculationQuotas → open ORG → verify no quota tab. Re-enable before continuing 7. Add a quota for ORG: Q1 2026, allocation 10 → verify it appears in the table 8. Add a second quota with overlapping dates → verify rejected with clash error 9. Edit the quota → verify modal prefills all fields including end date, save updates correctly 10. Add a future non-overlapping quota with no usage → verify Delete button appears. Delete it. Verify Delete button is absent on quotas that have usage Checkout with single quota: 11. Checkout an item to ORG → verify checkout succeeds, quota used increments, ISSUE usage record visible in details 12. Exhaust ORG's quota, set AllowQuotaOverride ON → attempt checkout → verify confirmation prompt, can override 13. With quota still exhausted, set AllowQuotaOverride OFF → attempt checkout → verify blocked, cannot proceed Checkout with guarantor quotas: 14. Give MEMBER their own active quota (allocation 5). 15. Checkout to MEMBER → verify QUOTA_SELECT prompt to choose between own and guarantor quota Renewals and returns: 16. Renew an existing checkout that has quota usage → verify used increments and new RENEW usage record created 17. Return a checked-out item → verify quota used value is unchanged Signed-off-by: Jacob O'Mara <jacob.omara@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193404|0 |1 is obsolete| | --- Comment #172 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 193433 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193433&action=edit Bug 38924: Add Koha::Patron::Quota(s) classes Add initial Koha::Patron::Quota(s) classes for working with circulation quotas, including an overloaded store method to prevent overlapping quota periods. Additionally added a definition for the custom exception for if you are trying to store a quota whos active period overlaps with another for this patron Signed-off-by: Jacob O'Mara <jacob.omara@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193405|0 |1 is obsolete| | --- Comment #173 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 193434 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193434&action=edit Bug 38924: Add quotas permissions This patch adds the new quotas permissions to the system Signed-off-by: Jacob O'Mara <jacob.omara@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193406|0 |1 is obsolete| | --- Comment #174 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 193435 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193435&action=edit Bug 38924: Add API endpoints for managing quotas This commit adds the api endpoints for administering circulation quotas Signed-off-by: Jacob O'Mara <jacob.omara@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193407|0 |1 is obsolete| | --- Comment #175 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 193436 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193436&action=edit Bug 38924: Add patron quota management page Add a new patron quota management tab under the members area for patrons of the organization category type. FIXME: Tie into permissions for 'add', 'edit' Depending on permissions, we will need display only options including guarantor and guarantee usage against quotas and also the options to add and edit quota. Signed-off-by: Jacob O'Mara <jacob.omara@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193408|0 |1 is obsolete| | --- Comment #176 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 193437 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193437&action=edit Bug 38924: Add patron_quota_usage table Add the new patron_quota_usage table for recording usage of quota allocations against user issues. Signed-off-by: Jacob O'Mara <jacob.omara@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193409|0 |1 is obsolete| | --- Comment #177 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 193438 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193438&action=edit Bug 38924: Add Koha::Patron::Quota::Usage(s) classes Add ::Usage(s) classes for working with quota allocation usage. We overload store to ensure data consistency for the checkout_id field which is linked to either the issue or old_issue table appropriatly. We include a checkout relationship that handles the lack of foreign key due to issues/old_issues. Signed-off-by: Jacob O'Mara <jacob.omara@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193410|0 |1 is obsolete| | --- Comment #178 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 193439 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193439&action=edit Bug 38924: Overload delete method in Koha::Old::Checkout This overloads the delete method for old::checkouts to ensure that the issue_id for quotas usage is nulled in the event that an old_checkout is deleted. Would like to make this the standard for all the tables we have had to handle issue/old_issues for but is currently just hard-coded for quotas as many of the other tables with issue_id columns are not nullable. Signed-off-by: Jacob O'Mara <jacob.omara@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193411|0 |1 is obsolete| | --- Comment #179 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 193440 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193440&action=edit Bug 38924: Add Usage relations to Quota objects Signed-off-by: Jacob O'Mara <jacob.omara@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193412|0 |1 is obsolete| | --- Comment #180 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 193441 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193441&action=edit Bug 38924: Add AllowQuotaOverride and UseGuarantorQuota preferences Add a system preferences to allow/dissallow quota overflow at checkout and enable/disable the use of guarantor quotas against guarantees Signed-off-by: Jacob O'Mara <jacob.omara@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193413|0 |1 is obsolete| | --- Comment #181 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 193442 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193442&action=edit Bug 38924: Add get_patron_quotas method This commit adds the ability to return the guarantor's quota when searching for a patron's quota at checkout. This will only occur if the related syspref is enabled "UseGuaratorQuota" and will return in this order or priority: guarantor's quota with availability patrons's quota with availability guarantor's quota with no availability patron's quota with no availibility null Signed-off-by: Jacob O'Mara <jacob.omara@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193414|0 |1 is obsolete| | --- Comment #182 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 193443 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193443&action=edit Bug 38924: Hook quota check and allocation into checkout Signed-off-by: Jacob O'Mara <jacob.omara@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193415|0 |1 is obsolete| | --- Comment #183 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 193444 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193444&action=edit Bug 38924: Hook quota check and allocation into renewals This adds the checks for quotas and allocates a usage for a renewal of a book, should a quota exist for this patron Signed-off-by: Jacob O'Mara <jacob.omara@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193416|0 |1 is obsolete| | --- Comment #184 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 193445 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193445&action=edit Bug 38924: Add quota picker to checkout confirmation This patch adds the quota selector to the checkout confirmation for if multiple eligable quotas are available Bug 38924: Return all eligable quotas so that the staff user can pick This patch adds the logic to return multiple eligable quotas if there are more than 1, allowing the staff user to pick which to assign an item to. Bug 38924: Add searcher method for currently active quota for patron Bug 38924: amend circ logic to handle multiple eligable quotas This amends the circulations logic to handle the fact that we can return multiple eligable quotas now. This ensures that the same quotas as was used for the checkout will be used for the renewal (both check and assignment) and that we use the selected quota from our confirmation dropdown for checkout of new item Bug 38924: add better name display for quota select at checkout Signed-off-by: Jacob O'Mara <jacob.omara@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193417|0 |1 is obsolete| | --- Comment #185 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 193446 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193446&action=edit Bug 38924: Move from get_patron_quota to Koha::Patron relations Bug 38924: Deal with multiple quota options in QUOTA_EXCEEDED handling Bug 38924: Deal with using the same quota for renewals Signed-off-by: Jacob O'Mara <jacob.omara@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193418|0 |1 is obsolete| | --- Comment #186 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 193447 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193447&action=edit Bug 38924: Add quotas available on circuation screen Signed-off-by: Jacob O'Mara <jacob.omara@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193419|0 |1 is obsolete| | --- Comment #187 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 193448 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193448&action=edit Bug 38924: Add type and timestamp to usage table This allows us to more easily audit what actions incremented the usage and when. We will use this later in display Signed-off-by: Jacob O'Mara <jacob.omara@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193420|0 |1 is obsolete| | --- Comment #188 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 193449 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193449&action=edit Bug 38924: Add quota accessor to Koha::Checkout and use on checkouts page Signed-off-by: Jacob O'Mara <jacob.omara@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193421|0 |1 is obsolete| | --- Comment #189 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 193450 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193450&action=edit Bug 38924: Display quota used at checkout Use the quota relation added to Koha::Checkout to display an info alert message that quota allocation has been used by the checkout that just took place Signed-off-by: Jacob O'Mara <jacob.omara@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193422|0 |1 is obsolete| | --- Comment #190 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 193451 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193451&action=edit Bug 38924: Add quota usage details modal Signed-off-by: Jacob O'Mara <jacob.omara@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193423|0 |1 is obsolete| | --- Comment #191 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 193452 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193452&action=edit Bug 38924: Add option to enable/disable quotas Signed-off-by: Jacob O'Mara <jacob.omara@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193424|0 |1 is obsolete| | --- Comment #192 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 193453 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193453&action=edit Bug 38924: Add tests for quotas object classes and api endpoints Signed-off-by: Jacob O'Mara <jacob.omara@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193425|0 |1 is obsolete| | --- Comment #193 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 193454 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193454&action=edit Bug 38924: DBIC - DO NOT PUSH Signed-off-by: Jacob O'Mara <jacob.omara@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193426|0 |1 is obsolete| | --- Comment #194 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 193455 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193455&action=edit Bug 38924: Add relations after the hash in DBIC This adds additional relations to our DBIC classes to allow relation traversal in our Koha::Objects Signed-off-by: Jacob O'Mara <jacob.omara@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193427|0 |1 is obsolete| | --- Comment #195 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 193456 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193456&action=edit Bug 38924: Add issue and old_issue relations to Schema Signed-off-by: Jacob O'Mara <jacob.omara@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193428|0 |1 is obsolete| | --- Comment #196 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 193457 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193457&action=edit Bug 38924: Add koha_object_class to Schema files Signed-off-by: Jacob O'Mara <jacob.omara@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193429|0 |1 is obsolete| | --- Comment #197 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 193458 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193458&action=edit Bug 38924: Add quota usage api endpoint Signed-off-by: Jacob O'Mara <jacob.omara@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193430|0 |1 is obsolete| | --- Comment #198 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 193459 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193459&action=edit Bug 38924: (follow-up) Minor QOL quota modal fixes - Makes sure that the quotas modal displays the error message for why the submit failed, instead of a generic message - Clears the modal data on modal close to remove persistent data - Get dates directly from flatpickr selectedDates for API requests to ensure sync. Signed-off-by: Jacob O'Mara <jacob.omara@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193431|0 |1 is obsolete| | --- Comment #199 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 193460 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193460&action=edit Bug 38924: (follow-up) Fix edit modal not autofilling end date The flatpickr setDate calls were passing triggerChange=1 which caused the start picker's hooks to interfere with the end picker before its value could be set. Remove triggerChange to match the pattern used by other Koha date pickers (members.js, datatables.js). Signed-off-by: Jacob O'Mara <jacob.omara@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #200 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- This has been on one of our Customer's sites for around a year at this point with no issues, going to call that an implicit sign off that it works as expected. Added sign-off line and moved to needs QA Here is the test plan as it's once again buried: Setup: 1. Enable EnableCirculationQuotas, AllowQuotaOverride, and UseGuarantorQuota in system preferences 2. Create an Institutional patron (ORG) and a second Institutional patron (MEMBER) as guarantee of ORG 3. Create a non-institutional patron (NORELATION) with no relationships Quota management: 4. Open ORG's detail page → verify "Circulation quota" tab visible in sidebar 5. Open NORELATION's detail page → verify no quota tab 6. Disable EnableCirculationQuotas → open ORG → verify no quota tab. Re-enable before continuing 7. Add a quota for ORG: Q1 2026, allocation 10 → verify it appears in the table 8. Add a second quota with overlapping dates → verify rejected with clash error 9. Edit the quota → verify modal prefills all fields including end date, save updates correctly 10. Add a future non-overlapping quota with no usage → verify Delete button appears. Delete it. Verify Delete button is absent on quotas that have usage Checkout with single quota: 11. Checkout an item to ORG → verify checkout succeeds, quota used increments, ISSUE usage record visible in details 12. Exhaust ORG's quota, set AllowQuotaOverride ON → attempt checkout → verify confirmation prompt, can override 13. With quota still exhausted, set AllowQuotaOverride OFF → attempt checkout → verify blocked, cannot proceed Checkout with guarantor quotas: 14. Give MEMBER their own active quota (allocation 5). 15. Checkout to MEMBER → verify QUOTA_SELECT prompt to choose between own and guarantor quota Renewals and returns: 16. Renew an existing checkout that has quota usage → verify used increments and new RENEW usage record created 17. Return a checked-out item → verify quota used value is unchanged -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193432|0 |1 is obsolete| | --- Comment #201 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 193547 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193547&action=edit Bug 38924: Add patron_quotas table Add the new patron_quotas table for storing circulation quotas Setup: 1. Enable EnableCirculationQuotas, AllowQuotaOverride, and UseGuarantorQuota in system preferences 2. Create an Institutional patron (ORG) and a second Institutional patron (MEMBER) as guarantee of ORG 3. Create a non-institutional patron (NORELATION) with no relationships Quota management: 4. Open ORG's detail page → verify "Circulation quota" tab visible in sidebar 5. Open NORELATION's detail page → verify no quota tab 6. Disable EnableCirculationQuotas → open ORG → verify no quota tab. Re-enable before continuing 7. Add a quota for ORG: Q1 2026, allocation 10 → verify it appears in the table 8. Add a second quota with overlapping dates → verify rejected with clash error 9. Edit the quota → verify modal prefills all fields including end date, save updates correctly 10. Add a future non-overlapping quota with no usage → verify Delete button appears. Delete it. Verify Delete button is absent on quotas that have usage Checkout with single quota: 11. Checkout an item to ORG → verify checkout succeeds, quota used increments, ISSUE usage record visible in details 12. Exhaust ORG's quota, set AllowQuotaOverride ON → attempt checkout → verify confirmation prompt, can override 13. With quota still exhausted, set AllowQuotaOverride OFF → attempt checkout → verify blocked, cannot proceed Checkout with guarantor quotas: 14. Give MEMBER their own active quota (allocation 5). 15. Checkout to MEMBER → verify QUOTA_SELECT prompt to choose between own and guarantor quota Renewals and returns: 16. Renew an existing checkout that has quota usage → verify used increments and new RENEW usage record created 17. Return a checked-out item → verify quota used value is unchanged -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193433|0 |1 is obsolete| | --- Comment #202 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 193548 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193548&action=edit Bug 38924: Add Koha::Patron::Quota(s) classes Add initial Koha::Patron::Quota(s) classes for working with circulation quotas, including an overloaded store method to prevent overlapping quota periods. Additionally added a definition for the custom exception for if you are trying to store a quota whos active period overlaps with another for this patron -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193434|0 |1 is obsolete| | --- Comment #203 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 193549 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193549&action=edit Bug 38924: Add quotas permissions This patch adds the new quotas permissions to the system -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193435|0 |1 is obsolete| | --- Comment #204 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 193550 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193550&action=edit Bug 38924: Add API endpoints for managing quotas This commit adds the api endpoints for administering circulation quotas -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193436|0 |1 is obsolete| | --- Comment #205 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 193551 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193551&action=edit Bug 38924: Add patron quota management page Add a new patron quota management tab under the members area for patrons of the organization category type. FIXME: Tie into permissions for 'add', 'edit' Depending on permissions, we will need display only options including guarantor and guarantee usage against quotas and also the options to add and edit quota. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193437|0 |1 is obsolete| | --- Comment #206 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 193552 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193552&action=edit Bug 38924: Add patron_quota_usage table Add the new patron_quota_usage table for recording usage of quota allocations against user issues. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193438|0 |1 is obsolete| | --- Comment #207 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 193553 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193553&action=edit Bug 38924: Add Koha::Patron::Quota::Usage(s) classes Add ::Usage(s) classes for working with quota allocation usage. We overload store to ensure data consistency for the checkout_id field which is linked to either the issue or old_issue table appropriatly. We include a checkout relationship that handles the lack of foreign key due to issues/old_issues. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193439|0 |1 is obsolete| | --- Comment #208 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 193554 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193554&action=edit Bug 38924: Overload delete method in Koha::Old::Checkout This overloads the delete method for old::checkouts to ensure that the issue_id for quotas usage is nulled in the event that an old_checkout is deleted. Would like to make this the standard for all the tables we have had to handle issue/old_issues for but is currently just hard-coded for quotas as many of the other tables with issue_id columns are not nullable. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193440|0 |1 is obsolete| | --- Comment #209 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 193555 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193555&action=edit Bug 38924: Add Usage relations to Quota objects -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193441|0 |1 is obsolete| | --- Comment #210 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 193556 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193556&action=edit Bug 38924: Add AllowQuotaOverride and UseGuarantorQuota preferences Add a system preferences to allow/dissallow quota overflow at checkout and enable/disable the use of guarantor quotas against guarantees -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193442|0 |1 is obsolete| | --- Comment #211 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 193557 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193557&action=edit Bug 38924: Add get_patron_quotas method This commit adds the ability to return the guarantor's quota when searching for a patron's quota at checkout. This will only occur if the related syspref is enabled "UseGuaratorQuota" and will return in this order or priority: guarantor's quota with availability patrons's quota with availability guarantor's quota with no availability patron's quota with no availibility null -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193443|0 |1 is obsolete| | --- Comment #212 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 193558 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193558&action=edit Bug 38924: Hook quota check and allocation into checkout -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193444|0 |1 is obsolete| | --- Comment #213 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 193559 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193559&action=edit Bug 38924: Hook quota check and allocation into renewals This adds the checks for quotas and allocates a usage for a renewal of a book, should a quota exist for this patron -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193445|0 |1 is obsolete| | --- Comment #214 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 193560 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193560&action=edit Bug 38924: Add quota picker to checkout confirmation This patch adds the quota selector to the checkout confirmation for if multiple eligable quotas are available Bug 38924: Return all eligable quotas so that the staff user can pick This patch adds the logic to return multiple eligable quotas if there are more than 1, allowing the staff user to pick which to assign an item to. Bug 38924: Add searcher method for currently active quota for patron Bug 38924: amend circ logic to handle multiple eligable quotas This amends the circulations logic to handle the fact that we can return multiple eligable quotas now. This ensures that the same quotas as was used for the checkout will be used for the renewal (both check and assignment) and that we use the selected quota from our confirmation dropdown for checkout of new item Bug 38924: add better name display for quota select at checkout -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193446|0 |1 is obsolete| | --- Comment #215 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 193561 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193561&action=edit Bug 38924: Move from get_patron_quota to Koha::Patron relations Bug 38924: Deal with multiple quota options in QUOTA_EXCEEDED handling Bug 38924: Deal with using the same quota for renewals -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193447|0 |1 is obsolete| | --- Comment #216 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 193562 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193562&action=edit Bug 38924: Add quotas available on circuation screen -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193448|0 |1 is obsolete| | --- Comment #217 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 193563 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193563&action=edit Bug 38924: Add type and timestamp to usage table This allows us to more easily audit what actions incremented the usage and when. We will use this later in display -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193449|0 |1 is obsolete| | --- Comment #218 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 193564 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193564&action=edit Bug 38924: Add quota accessor to Koha::Checkout and use on checkouts page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193450|0 |1 is obsolete| | --- Comment #219 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 193565 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193565&action=edit Bug 38924: Display quota used at checkout Use the quota relation added to Koha::Checkout to display an info alert message that quota allocation has been used by the checkout that just took place -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193451|0 |1 is obsolete| | --- Comment #220 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 193566 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193566&action=edit Bug 38924: Add quota usage details modal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193452|0 |1 is obsolete| | --- Comment #221 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 193567 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193567&action=edit Bug 38924: Add option to enable/disable quotas -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193453|0 |1 is obsolete| | --- Comment #222 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 193568 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193568&action=edit Bug 38924: Add tests for quotas object classes and api endpoints -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193454|0 |1 is obsolete| | --- Comment #223 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 193569 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193569&action=edit Bug 38924: DBIC - DO NOT PUSH -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193455|0 |1 is obsolete| | --- Comment #224 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 193570 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193570&action=edit Bug 38924: Add relations after the hash in DBIC This adds additional relations to our DBIC classes to allow relation traversal in our Koha::Objects -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193456|0 |1 is obsolete| | --- Comment #225 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 193571 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193571&action=edit Bug 38924: Add issue and old_issue relations to Schema -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193457|0 |1 is obsolete| | --- Comment #226 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 193572 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193572&action=edit Bug 38924: Add koha_object_class to Schema files -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193458|0 |1 is obsolete| | --- Comment #227 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 193573 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193573&action=edit Bug 38924: Add quota usage api endpoint -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193459|0 |1 is obsolete| | --- Comment #228 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 193574 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193574&action=edit Bug 38924: (follow-up) Minor QOL quota modal fixes - Makes sure that the quotas modal displays the error message for why the submit failed, instead of a generic message - Clears the modal data on modal close to remove persistent data - Get dates directly from flatpickr selectedDates for API requests to ensure sync. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193460|0 |1 is obsolete| | --- Comment #229 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 193575 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193575&action=edit Bug 38924: (follow-up) Fix edit modal not autofilling end date The flatpickr setDate calls were passing triggerChange=1 which caused the start picker's hooks to interfere with the end picker before its value could be set. Remove triggerChange to match the pattern used by other Koha date pickers (members.js, datatables.js). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 --- Comment #230 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 193576 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193576&action=edit Bug 38924: (follow-up) Record RENEW usage type for renewals Pass explicit type param to add_usage: ISSUE for checkouts, RENEW for renewals. Default to ISSUE in add_usage for safety. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 --- Comment #231 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 193577 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193577&action=edit Bug 38924: (follow-up) Exclude QUOTA_SELECT from session remember Prevents quota selection from being stored in or skipped by the session confirmation cookie. Hides the remember checkbox when quota is the only confirmation shown. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 OpenFifth Sandboxes <sandboxes@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193547|0 |1 is obsolete| | --- Comment #232 from OpenFifth Sandboxes <sandboxes@openfifth.co.uk> --- Created attachment 194119 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194119&action=edit Bug 38924: Add patron_quotas table Add the new patron_quotas table for storing circulation quotas Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 OpenFifth Sandboxes <sandboxes@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193548|0 |1 is obsolete| | --- Comment #233 from OpenFifth Sandboxes <sandboxes@openfifth.co.uk> --- Created attachment 194120 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194120&action=edit Bug 38924: Add Koha::Patron::Quota(s) classes Add initial Koha::Patron::Quota(s) classes for working with circulation quotas, including an overloaded store method to prevent overlapping quota periods. Additionally added a definition for the custom exception for if you are trying to store a quota whos active period overlaps with another for this patron Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 OpenFifth Sandboxes <sandboxes@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193549|0 |1 is obsolete| | --- Comment #234 from OpenFifth Sandboxes <sandboxes@openfifth.co.uk> --- Created attachment 194121 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194121&action=edit Bug 38924: Add quotas permissions This patch adds the new quotas permissions to the system Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 OpenFifth Sandboxes <sandboxes@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193550|0 |1 is obsolete| | --- Comment #235 from OpenFifth Sandboxes <sandboxes@openfifth.co.uk> --- Created attachment 194122 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194122&action=edit Bug 38924: Add API endpoints for managing quotas This commit adds the api endpoints for administering circulation quotas Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 OpenFifth Sandboxes <sandboxes@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193551|0 |1 is obsolete| | --- Comment #236 from OpenFifth Sandboxes <sandboxes@openfifth.co.uk> --- Created attachment 194123 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194123&action=edit Bug 38924: Add patron quota management page Add a new patron quota management tab under the members area for patrons of the organization category type. FIXME: Tie into permissions for 'add', 'edit' Depending on permissions, we will need display only options including guarantor and guarantee usage against quotas and also the options to add and edit quota. Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 OpenFifth Sandboxes <sandboxes@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193552|0 |1 is obsolete| | --- Comment #237 from OpenFifth Sandboxes <sandboxes@openfifth.co.uk> --- Created attachment 194124 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194124&action=edit Bug 38924: Add patron_quota_usage table Add the new patron_quota_usage table for recording usage of quota allocations against user issues. Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 OpenFifth Sandboxes <sandboxes@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193553|0 |1 is obsolete| | --- Comment #238 from OpenFifth Sandboxes <sandboxes@openfifth.co.uk> --- Created attachment 194125 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194125&action=edit Bug 38924: Add Koha::Patron::Quota::Usage(s) classes Add ::Usage(s) classes for working with quota allocation usage. We overload store to ensure data consistency for the checkout_id field which is linked to either the issue or old_issue table appropriatly. We include a checkout relationship that handles the lack of foreign key due to issues/old_issues. Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 OpenFifth Sandboxes <sandboxes@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193554|0 |1 is obsolete| | --- Comment #239 from OpenFifth Sandboxes <sandboxes@openfifth.co.uk> --- Created attachment 194126 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194126&action=edit Bug 38924: Overload delete method in Koha::Old::Checkout This overloads the delete method for old::checkouts to ensure that the issue_id for quotas usage is nulled in the event that an old_checkout is deleted. Would like to make this the standard for all the tables we have had to handle issue/old_issues for but is currently just hard-coded for quotas as many of the other tables with issue_id columns are not nullable. Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 OpenFifth Sandboxes <sandboxes@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193555|0 |1 is obsolete| | --- Comment #240 from OpenFifth Sandboxes <sandboxes@openfifth.co.uk> --- Created attachment 194127 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194127&action=edit Bug 38924: Add Usage relations to Quota objects Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 OpenFifth Sandboxes <sandboxes@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193556|0 |1 is obsolete| | --- Comment #241 from OpenFifth Sandboxes <sandboxes@openfifth.co.uk> --- Created attachment 194128 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194128&action=edit Bug 38924: Add AllowQuotaOverride and UseGuarantorQuota preferences Add a system preferences to allow/dissallow quota overflow at checkout and enable/disable the use of guarantor quotas against guarantees Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 OpenFifth Sandboxes <sandboxes@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193557|0 |1 is obsolete| | --- Comment #242 from OpenFifth Sandboxes <sandboxes@openfifth.co.uk> --- Created attachment 194129 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194129&action=edit Bug 38924: Add get_patron_quotas method This commit adds the ability to return the guarantor's quota when searching for a patron's quota at checkout. This will only occur if the related syspref is enabled "UseGuaratorQuota" and will return in this order or priority: guarantor's quota with availability patrons's quota with availability guarantor's quota with no availability patron's quota with no availibility null Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 OpenFifth Sandboxes <sandboxes@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193558|0 |1 is obsolete| | --- Comment #243 from OpenFifth Sandboxes <sandboxes@openfifth.co.uk> --- Created attachment 194130 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194130&action=edit Bug 38924: Hook quota check and allocation into checkout Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 OpenFifth Sandboxes <sandboxes@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193559|0 |1 is obsolete| | --- Comment #244 from OpenFifth Sandboxes <sandboxes@openfifth.co.uk> --- Created attachment 194131 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194131&action=edit Bug 38924: Hook quota check and allocation into renewals This adds the checks for quotas and allocates a usage for a renewal of a book, should a quota exist for this patron Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 OpenFifth Sandboxes <sandboxes@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193560|0 |1 is obsolete| | --- Comment #245 from OpenFifth Sandboxes <sandboxes@openfifth.co.uk> --- Created attachment 194132 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194132&action=edit Bug 38924: Add quota picker to checkout confirmation This patch adds the quota selector to the checkout confirmation for if multiple eligable quotas are available Bug 38924: Return all eligable quotas so that the staff user can pick This patch adds the logic to return multiple eligable quotas if there are more than 1, allowing the staff user to pick which to assign an item to. Bug 38924: Add searcher method for currently active quota for patron Bug 38924: amend circ logic to handle multiple eligable quotas This amends the circulations logic to handle the fact that we can return multiple eligable quotas now. This ensures that the same quotas as was used for the checkout will be used for the renewal (both check and assignment) and that we use the selected quota from our confirmation dropdown for checkout of new item Bug 38924: add better name display for quota select at checkout Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 OpenFifth Sandboxes <sandboxes@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193561|0 |1 is obsolete| | --- Comment #246 from OpenFifth Sandboxes <sandboxes@openfifth.co.uk> --- Created attachment 194133 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194133&action=edit Bug 38924: Move from get_patron_quota to Koha::Patron relations Bug 38924: Deal with multiple quota options in QUOTA_EXCEEDED handling Bug 38924: Deal with using the same quota for renewals Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 OpenFifth Sandboxes <sandboxes@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193562|0 |1 is obsolete| | --- Comment #247 from OpenFifth Sandboxes <sandboxes@openfifth.co.uk> --- Created attachment 194134 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194134&action=edit Bug 38924: Add quotas available on circuation screen Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 OpenFifth Sandboxes <sandboxes@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193563|0 |1 is obsolete| | --- Comment #248 from OpenFifth Sandboxes <sandboxes@openfifth.co.uk> --- Created attachment 194135 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194135&action=edit Bug 38924: Add type and timestamp to usage table This allows us to more easily audit what actions incremented the usage and when. We will use this later in display Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 OpenFifth Sandboxes <sandboxes@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193564|0 |1 is obsolete| | --- Comment #249 from OpenFifth Sandboxes <sandboxes@openfifth.co.uk> --- Created attachment 194136 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194136&action=edit Bug 38924: Add quota accessor to Koha::Checkout and use on checkouts page Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 OpenFifth Sandboxes <sandboxes@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193565|0 |1 is obsolete| | --- Comment #250 from OpenFifth Sandboxes <sandboxes@openfifth.co.uk> --- Created attachment 194137 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194137&action=edit Bug 38924: Display quota used at checkout Use the quota relation added to Koha::Checkout to display an info alert message that quota allocation has been used by the checkout that just took place Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 OpenFifth Sandboxes <sandboxes@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193566|0 |1 is obsolete| | --- Comment #251 from OpenFifth Sandboxes <sandboxes@openfifth.co.uk> --- Created attachment 194138 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194138&action=edit Bug 38924: Add quota usage details modal Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 OpenFifth Sandboxes <sandboxes@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193567|0 |1 is obsolete| | --- Comment #252 from OpenFifth Sandboxes <sandboxes@openfifth.co.uk> --- Created attachment 194139 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194139&action=edit Bug 38924: Add option to enable/disable quotas Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 OpenFifth Sandboxes <sandboxes@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193568|0 |1 is obsolete| | --- Comment #253 from OpenFifth Sandboxes <sandboxes@openfifth.co.uk> --- Created attachment 194140 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194140&action=edit Bug 38924: Add tests for quotas object classes and api endpoints Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 OpenFifth Sandboxes <sandboxes@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193569|0 |1 is obsolete| | --- Comment #254 from OpenFifth Sandboxes <sandboxes@openfifth.co.uk> --- Created attachment 194141 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194141&action=edit Bug 38924: DBIC - DO NOT PUSH Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 OpenFifth Sandboxes <sandboxes@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193570|0 |1 is obsolete| | --- Comment #255 from OpenFifth Sandboxes <sandboxes@openfifth.co.uk> --- Created attachment 194142 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194142&action=edit Bug 38924: Add relations after the hash in DBIC This adds additional relations to our DBIC classes to allow relation traversal in our Koha::Objects Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 OpenFifth Sandboxes <sandboxes@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193571|0 |1 is obsolete| | --- Comment #256 from OpenFifth Sandboxes <sandboxes@openfifth.co.uk> --- Created attachment 194143 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194143&action=edit Bug 38924: Add issue and old_issue relations to Schema Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 OpenFifth Sandboxes <sandboxes@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193572|0 |1 is obsolete| | --- Comment #257 from OpenFifth Sandboxes <sandboxes@openfifth.co.uk> --- Created attachment 194144 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194144&action=edit Bug 38924: Add koha_object_class to Schema files Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 OpenFifth Sandboxes <sandboxes@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193573|0 |1 is obsolete| | --- Comment #258 from OpenFifth Sandboxes <sandboxes@openfifth.co.uk> --- Created attachment 194145 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194145&action=edit Bug 38924: Add quota usage api endpoint Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 OpenFifth Sandboxes <sandboxes@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193574|0 |1 is obsolete| | --- Comment #259 from OpenFifth Sandboxes <sandboxes@openfifth.co.uk> --- Created attachment 194146 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194146&action=edit Bug 38924: (follow-up) Minor QOL quota modal fixes - Makes sure that the quotas modal displays the error message for why the submit failed, instead of a generic message - Clears the modal data on modal close to remove persistent data - Get dates directly from flatpickr selectedDates for API requests to ensure sync. Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 OpenFifth Sandboxes <sandboxes@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193575|0 |1 is obsolete| | --- Comment #260 from OpenFifth Sandboxes <sandboxes@openfifth.co.uk> --- Created attachment 194147 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194147&action=edit Bug 38924: (follow-up) Fix edit modal not autofilling end date The flatpickr setDate calls were passing triggerChange=1 which caused the start picker's hooks to interfere with the end picker before its value could be set. Remove triggerChange to match the pattern used by other Koha date pickers (members.js, datatables.js). Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 OpenFifth Sandboxes <sandboxes@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193576|0 |1 is obsolete| | --- Comment #261 from OpenFifth Sandboxes <sandboxes@openfifth.co.uk> --- Created attachment 194148 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194148&action=edit Bug 38924: (follow-up) Record RENEW usage type for renewals Pass explicit type param to add_usage: ISSUE for checkouts, RENEW for renewals. Default to ISSUE in add_usage for safety. Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 OpenFifth Sandboxes <sandboxes@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193577|0 |1 is obsolete| | --- Comment #262 from OpenFifth Sandboxes <sandboxes@openfifth.co.uk> --- Created attachment 194149 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194149&action=edit Bug 38924: (follow-up) Exclude QUOTA_SELECT from session remember Prevents quota selection from being stored in or skipped by the session confirmation cookie. Hides the remember checkbox when quota is the only confirmation shown. Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 --- Comment #263 from Sally <sally.healey@cheshiresharedservices.gov.uk> --- (In reply to Jacob O'Mara from comment #201)
Created attachment 193547 [details] [review] Bug 38924: Add patron_quotas table
Add the new patron_quotas table for storing circulation quotas
Setup: 1. Enable EnableCirculationQuotas, AllowQuotaOverride, and UseGuarantorQuota in system preferences 2. Create an Institutional patron (ORG) and a second Institutional patron (MEMBER) as guarantee of ORG 3. Create a non-institutional patron (NORELATION) with no relationships
Quota management: 4. Open ORG's detail page → verify "Circulation quota" tab visible in sidebar 5. Open NORELATION's detail page → verify no quota tab 6. Disable EnableCirculationQuotas → open ORG → verify no quota tab. Re-enable before continuing 7. Add a quota for ORG: Q1 2026, allocation 10 → verify it appears in the table 8. Add a second quota with overlapping dates → verify rejected with clash error 9. Edit the quota → verify modal prefills all fields including end date, save updates correctly 10. Add a future non-overlapping quota with no usage → verify Delete button appears. Delete it. Verify Delete button is absent on quotas that have usage
Checkout with single quota: 11. Checkout an item to ORG → verify checkout succeeds, quota used increments, ISSUE usage record visible in details 12. Exhaust ORG's quota, set AllowQuotaOverride ON → attempt checkout → verify confirmation prompt, can override 13. With quota still exhausted, set AllowQuotaOverride OFF → attempt checkout → verify blocked, cannot proceed
Checkout with guarantor quotas: 14. Give MEMBER their own active quota (allocation 5). 15. Checkout to MEMBER → verify QUOTA_SELECT prompt to choose between own and guarantor quota
Renewals and returns: 16. Renew an existing checkout that has quota usage → verify used increments and new RENEW usage record created 17. Return a checked-out item → verify quota used value is unchanged
Works as described in this test plan; signed off. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #264 from Victor Grousset/tuxayo <victor@tuxayo.net> --- There is a divergence between an upgraded install and a fresh one: AllowQuotaOverride and UseGuarantorQuota have a column at NULL or '' depending on upgraded vs fresh. Also a version has two columns swapped putting values in the wrong place. UseGuarantorQuota has divergences in the values of the explanation. ---- When looking at the test coverage as described here: https://wiki.koha-community.org/wiki/Coding_Guidelines#PERL17:_Unit_tests_ar... The findings are that no changes in C4/Circulation.pm are covered. The relevant tests to run are these, right? t/Koha/Auth/Permissions.t t/db_dependent/Koha/Patron/Quotas.t t/db_dependent/api/v1/patrons_quotas.t (the tests files touched by the patches) Changes in Koha/Old/Checkout.pm also aren't covered either. At first I wasn't sure if that was relevant. But that looks useful to check that the quotas are actually updated and not just having a deletion somewhere that runs the code and just shows that it doesn't explode. (I suppose the full test suite would delete a checkout and I would have seen that as covered) In Koha/Patron.pm, all_quotas() look relevant to test also. --- (In reply to Jacob O'Mara from comment #170)
Test plan is hidden in the ~200 comments so posting at the bottom as well for easier finding!
Don't worry, the trick is to go to the attachment section of the bug. Look for the 1st patch. Click on the date => immediate jump to the comment of that patch which is usually the one with the test plan. The re-posting of the test plan was immediately buried anyway :P (twice !) ---- (In reply to Jacob O'Mara from comment #200)
This has been on one of our Customer's sites for around a year at this point with no issues, going to call that an implicit sign off that it works as expected. Added sign-off line and moved to needs QA
Thanks Sally for the explicit signoff. I was going to ask Jacob that someone proofreads the test plan and confirms that their usage fully covers it. It's like my mind got read <.< ----- For next revision of the test plan: it needs a mention of `yarn api:bundle` to apply the API changes. (assuming that's the clean way to do that) ---- Did the sandbox remove the test plan between comment 201 and comment 232 ? 😱 That shouldn't be possible even if wanting to. Did I miss something? So I can report the issue if someone confirms it look legit. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38924 Aude Charillon <aude.charillon@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aude.charillon@openfifth.co | |.uk -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org