https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24288 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kelly@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24288 David Roberts <david.roberts@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david.roberts@ptfs-europe.c | |om Assignee|koha-bugs@lists.koha-commun |david.roberts@ptfs-europe.c |ity.org |om -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24288 --- Comment #1 from David Roberts <david.roberts@ptfs-europe.com> --- Created attachment 103060 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103060&action=edit Bug 24288: Add wording to authorized value interface to indicate valid code length This patch adds a warning that the authorized value field needs to be a single numeric character, where appropriate To test: 1) Apply the patch 2) Add a new authorised value policy in the LOST, NOTFORLOAN, DAMAGED, RESTRICTED, and WITHDRAWN categories 3) Check that there is a new warning displaying next to the Authorized value field stating "The authorized value field in the X category must be a one-digit numeric value" 4) Check that this same warning appears when modifying the same authorised values 5) Check that the warning doesn't appear in any other authorized value category. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24288 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #2 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Sorry! I gave the wrong name for the Nor For Loan auth value in my bug and that mistake followed into the patch. It should be NOT_LOAN. Otherwise this does a good job of adding some guidance. Part of me feels like we should go a step further and actually block folks from saving a value that's not valid, but that's a whole other thing. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24288 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103060|0 |1 is obsolete| | --- Comment #3 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 103083 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103083&action=edit Bug 24288: Add wording to authorized value interface to indicate valid code length Chnged NOTFORLOAN to NOT_LOAN This patch adds a warning that the authorized value field needs to be a single numeric character, where appropriate To test: 1) Apply the patch 2) Add a new authorised value policy in the LOST, NOTFORLOAN, DAMAGED, RESTRICTED, and WITHDRAWN categories 3) Check that there is a new warning displaying next to the Authorized value field stating "The authorized value field in the X category must be a one-digit numeric value" 4) Check that this same warning appears when modifying the same authorised values 5) Check that the warning doesn't appear in any other authorized value category. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24288 Marco Abi-Ramia <marco.abi-ramia@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103083|0 |1 is obsolete| | --- Comment #5 from Marco Abi-Ramia <marco.abi-ramia@inlibro.com> --- Created attachment 108536 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108536&action=edit Bug 24288: Add wording to authorized value interface to indicate valid code length Chnged NOTFORLOAN to NOT_LOAN This patch adds a warning that the authorized value field needs to be a single numeric character, where appropriate To test: 1) Apply the patch 2) Add a new authorised value policy in the LOST, NOTFORLOAN, DAMAGED, RESTRICTED, and WITHDRAWN categories 3) Check that there is a new warning displaying next to the Authorized value field stating "The authorized value field in the X category must be a one-digit numeric value" 4) Check that this same warning appears when modifying the same authorised values 5) Check that the warning doesn't appear in any other authorized value category. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24288 Ava <liav@wgc.school.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liav@wgc.school.nz Assignee|david.roberts@ptfs-europe.c |liav@wgc.school.nz |om | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24288 Ava <liav@wgc.school.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108536|0 |1 is obsolete| | --- Comment #7 from Ava <liav@wgc.school.nz> --- Created attachment 115498 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115498&action=edit Bug 24288: Add wording to authorized value interface to indicate valid code length TEST PLAN: 1) Apply the patch 2) Add a new authorised value policy in the LOST, NOTFORLOAN, DAMAGED, RESTRICTED, and WITHDRAWN categories 3) Check that there is a new warning displaying next to the Authorized value field stating "The authorized value field in the X category must be a one-digit numeric value" 4) Check that this same warning appears when modifying the same authorised values 5) Check that the warning doesn't appear in any other authorized value category. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24288 Barbara Johnson <barbara.johnson@bedfordtx.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |barbara.johnson@bedfordtx.g | |ov --- Comment #9 from Barbara Johnson <barbara.johnson@bedfordtx.gov> --- The patch worked as described. I could see the "must be a one-digit numeric value" warning. I was able to add two and three digit values and alpha values as well. So I agree that it would be great to add functionality to block adding anything that is not a one digit numeric value. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24288 --- Comment #10 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Wording is a great start, though! Filed a new bug to actually prevent invalid values: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27512 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24288 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24288 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Status|Passed QA |In Discussion --- Comment #12 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- 1. Maybe also YES_NO? 2. NOT_LOAN can be negative. I don't think negative numbers are "one-digit" numbers (being pedantic I suppose but that may be confusing?) 3. Shouldn't we then add a check inputmode="numeric" and pattern when appropriate? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24288 --- Comment #14 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Andrew Fuerste-Henry from comment #13)

(In reply to Jonathan Druart from comment #12)

...

1. Maybe also YES_NO? Makes sense to me to include this.

...

2. NOT_LOAN can be negative. I don't think negative numbers are "one-digit" numbers (being pedantic I suppose but that may be confusing?)

I see your point, technically. Would it be more clear an understandable to say something like "whole number between -9 and 9"?

All those tinyint(1) columns can be any value between -128 and 127. The 1 only specifies the default column display width and does not affect the size of the number that can be held within. Given that, maybe we should write -128 to 127, since they are valid values. Should we go a step further and explain the different behaviors between negative and positive values for a given category?

...

3. Shouldn't we then add a check inputmode="numeric" and pattern when appropriate?

Sounds good to me!

Sounds good!

-- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24288 Aude Charillon <aude.charillon@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aude.charillon@ptfs-europe. | |com --- Comment #15 from Aude Charillon <aude.charillon@ptfs-europe.com> --- Is this still "in discussion"? It would be really useful when creating an authorized value category and when creating / editing authorized values, to have any kind of message indicating what format (length, no spaces, which characters are allowed) it needs to take. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24288 Ray Delahunty <raymund.delahunty@outlook.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23861 CC| |raymund.delahunty@outlook.c | |om --- Comment #16 from Ray Delahunty <raymund.delahunty@outlook.com> --- As part of signing off Bug 41730 I was thinking about this feature. It would a good step on the way to a bigger fix as per Bug 23861. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24288 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Patch doesn't apply CC| |lucas@bywatersolutions.com --- Comment #17 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- I see no reason to leave this 'In discussion', patch doesn't apply currently. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24288 --- Comment #18 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 206579 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206579&action=edit Bug 24288: Add wording to authorized value interface to indicate valid code length TEST PLAN: 1) Apply the patch 2) Add a new authorised value policy in the LOST, NOTFORLOAN, DAMAGED, RESTRICTED, and WITHDRAWN categories 3) Check that there is a new warning displaying next to the Authorized value field stating "The authorized value field in the X category must be a one-digit numeric value" 4) Check that this same warning appears when modifying the same authorised values 5) Check that the warning doesn't appear in any other authorized value category. Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24288 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35990 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35990 [Bug 35990] [OMNIBUS] Improvements for using tinyint authorised values -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24288 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|kyle@bywatersolutions.com |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24288 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24288 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Signed Off QA Contact|lucas@bywatersolutions.com |testopia@bugs.koha-communit | |y.org --- Comment #22 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Now I've done too much here and am excusing myself from QA. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24288 Jason Robb <jrobb@sekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #23 from Jason Robb <jrobb@sekls.org> --- For NOT_LOAN, the positive/negative hints do not appear to be accurate. It states that positive values will mark things as "Available for reference" in the OPAC search results but that functionality is controlled by the Reference_NFL_Statuses syspref, so not all positive values cause that label and negative values can also cause that label. From testing, any NOT_LOAN value not defined in Reference_NFL_Statuses gets the "Not available" label. For negative numbers, it states an "On order" availability message will display in OPAC search results but I wasn't able to replicate that behavior. Additionally, it states "Koha will not prompt staff to capture that hold until the item no longer has a not for loan value." which isn't entirely true. If you check in an item with a negative NOT_LOAN value the hold will trigger and try to trap. The hold does not appear on the holds queue, though, so maybe that's what's meant here? -- You are receiving this mail because: You are watching all bug changes.