[Bug 24288] New: Add wording to authorized value interface to indicate valid code length
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24288 Bug ID: 24288 Summary: Add wording to authorized value interface to indicate valid code length Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs@lists.koha-community.org Reporter: andrew@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Several standard authorized values feed into fields that require a single character code (LOST, NOTFORLOAN, DAMAGED, RESTRICTED, WITHDRAWN). It'd be good to have some wording in the authorized value interface that would indicate this. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24288 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kelly@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24288 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Keywords| |Academy -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24288 David Roberts <david.roberts@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david.roberts@ptfs-europe.c | |om Assignee|koha-bugs@lists.koha-commun |david.roberts@ptfs-europe.c |ity.org |om -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24288 David Roberts <david.roberts@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24288 --- Comment #1 from David Roberts <david.roberts@ptfs-europe.com> --- Created attachment 103060 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103060&action=edit Bug 24288: Add wording to authorized value interface to indicate valid code length This patch adds a warning that the authorized value field needs to be a single numeric character, where appropriate To test: 1) Apply the patch 2) Add a new authorised value policy in the LOST, NOTFORLOAN, DAMAGED, RESTRICTED, and WITHDRAWN categories 3) Check that there is a new warning displaying next to the Authorized value field stating "The authorized value field in the X category must be a one-digit numeric value" 4) Check that this same warning appears when modifying the same authorised values 5) Check that the warning doesn't appear in any other authorized value category. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24288 David Roberts <david.roberts@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24288 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #2 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Sorry! I gave the wrong name for the Nor For Loan auth value in my bug and that mistake followed into the patch. It should be NOT_LOAN. Otherwise this does a good job of adding some guidance. Part of me feels like we should go a step further and actually block folks from saving a value that's not valid, but that's a whole other thing. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24288 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24288 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103060|0 |1 is obsolete| | --- Comment #3 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 103083 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103083&action=edit Bug 24288: Add wording to authorized value interface to indicate valid code length Chnged NOTFORLOAN to NOT_LOAN This patch adds a warning that the authorized value field needs to be a single numeric character, where appropriate To test: 1) Apply the patch 2) Add a new authorised value policy in the LOST, NOTFORLOAN, DAMAGED, RESTRICTED, and WITHDRAWN categories 3) Check that there is a new warning displaying next to the Authorized value field stating "The authorized value field in the X category must be a one-digit numeric value" 4) Check that this same warning appears when modifying the same authorised values 5) Check that the warning doesn't appear in any other authorized value category. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24288 --- Comment #4 from David Roberts <david.roberts@ptfs-europe.com> --- Sorry, I should have noticed that myself! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24288 Marco Abi-Ramia <marco.abi-ramia@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103083|0 |1 is obsolete| | --- Comment #5 from Marco Abi-Ramia <marco.abi-ramia@inlibro.com> --- Created attachment 108536 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108536&action=edit Bug 24288: Add wording to authorized value interface to indicate valid code length Chnged NOTFORLOAN to NOT_LOAN This patch adds a warning that the authorized value field needs to be a single numeric character, where appropriate To test: 1) Apply the patch 2) Add a new authorised value policy in the LOST, NOTFORLOAN, DAMAGED, RESTRICTED, and WITHDRAWN categories 3) Check that there is a new warning displaying next to the Authorized value field stating "The authorized value field in the X category must be a one-digit numeric value" 4) Check that this same warning appears when modifying the same authorised values 5) Check that the warning doesn't appear in any other authorized value category. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24288 Kelly McElligott <kelly@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #6 from Kelly McElligott <kelly@bywatersolutions.com> --- Hi, I tested this and did not receive any warning / or see any text to indicate that these values needed to be a single digit numeric value. I was able to create a a new value for both NOT_LOAN and LOST with letters and was successful. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24288 Ava <liav@wgc.school.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liav@wgc.school.nz Assignee|david.roberts@ptfs-europe.c |liav@wgc.school.nz |om | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24288 Ava <liav@wgc.school.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24288 Ava <liav@wgc.school.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108536|0 |1 is obsolete| | --- Comment #7 from Ava <liav@wgc.school.nz> --- Created attachment 115498 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115498&action=edit Bug 24288: Add wording to authorized value interface to indicate valid code length TEST PLAN: 1) Apply the patch 2) Add a new authorised value policy in the LOST, NOTFORLOAN, DAMAGED, RESTRICTED, and WITHDRAWN categories 3) Check that there is a new warning displaying next to the Authorized value field stating "The authorized value field in the X category must be a one-digit numeric value" 4) Check that this same warning appears when modifying the same authorised values 5) Check that the warning doesn't appear in any other authorized value category. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24288 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115498|0 |1 is obsolete| | --- Comment #8 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 115569 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115569&action=edit Bug 24288: Add wording to authorized value interface to indicate valid code length TEST PLAN: 1) Apply the patch 2) Add a new authorised value policy in the LOST, NOTFORLOAN, DAMAGED, RESTRICTED, and WITHDRAWN categories 3) Check that there is a new warning displaying next to the Authorized value field stating "The authorized value field in the X category must be a one-digit numeric value" 4) Check that this same warning appears when modifying the same authorised values 5) Check that the warning doesn't appear in any other authorized value category. Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24288 Barbara Johnson <barbara.johnson@bedfordtx.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |barbara.johnson@bedfordtx.g | |ov --- Comment #9 from Barbara Johnson <barbara.johnson@bedfordtx.gov> --- The patch worked as described. I could see the "must be a one-digit numeric value" warning. I was able to add two and three digit values and alpha values as well. So I agree that it would be great to add functionality to block adding anything that is not a one digit numeric value. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24288 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27512 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24288 --- Comment #10 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Wording is a great start, though! Filed a new bug to actually prevent invalid values: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27512 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24288 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |kyle@bywatersolutions.com |y.org | CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24288 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24288 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115569|0 |1 is obsolete| | --- Comment #11 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 115581 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115581&action=edit Bug 24288: Add wording to authorized value interface to indicate valid code length TEST PLAN: 1) Apply the patch 2) Add a new authorised value policy in the LOST, NOTFORLOAN, DAMAGED, RESTRICTED, and WITHDRAWN categories 3) Check that there is a new warning displaying next to the Authorized value field stating "The authorized value field in the X category must be a one-digit numeric value" 4) Check that this same warning appears when modifying the same authorised values 5) Check that the warning doesn't appear in any other authorized value category. Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24288 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Status|Passed QA |In Discussion --- Comment #12 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- 1. Maybe also YES_NO? 2. NOT_LOAN can be negative. I don't think negative numbers are "one-digit" numbers (being pedantic I suppose but that may be confusing?) 3. Shouldn't we then add a check inputmode="numeric" and pattern when appropriate? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24288 --- Comment #13 from Andrew Fuerste-Henry <andrewfh@dubcolib.org> --- (In reply to Jonathan Druart from comment #12)
1. Maybe also YES_NO? Makes sense to me to include this.
2. NOT_LOAN can be negative. I don't think negative numbers are "one-digit" numbers (being pedantic I suppose but that may be confusing?)
I see your point, technically. Would it be more clear an understandable to say something like "whole number between -9 and 9"?
3. Shouldn't we then add a check inputmode="numeric" and pattern when appropriate?
Sounds good! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24288 --- Comment #14 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Andrew Fuerste-Henry from comment #13)
(In reply to Jonathan Druart from comment #12)
1. Maybe also YES_NO? Makes sense to me to include this.
2. NOT_LOAN can be negative. I don't think negative numbers are "one-digit" numbers (being pedantic I suppose but that may be confusing?)
I see your point, technically. Would it be more clear an understandable to say something like "whole number between -9 and 9"?
All those tinyint(1) columns can be any value between -128 and 127. The 1 only specifies the default column display width and does not affect the size of the number that can be held within. Given that, maybe we should write -128 to 127, since they are valid values. Should we go a step further and explain the different behaviors between negative and positive values for a given category?
3. Shouldn't we then add a check inputmode="numeric" and pattern when appropriate?
Sounds good to me!
Sounds good!
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24288 Laura O'Neil <laura@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |laura@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24288 Aude Charillon <aude.charillon@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aude.charillon@ptfs-europe. | |com --- Comment #15 from Aude Charillon <aude.charillon@ptfs-europe.com> --- Is this still "in discussion"? It would be really useful when creating an authorized value category and when creating / editing authorized values, to have any kind of message indicating what format (length, no spaces, which characters are allowed) it needs to take. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24288 Marion Durand <marion.durand@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marion.durand@biblibre.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24288 Ray Delahunty <raymund.delahunty@outlook.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23861 CC| |raymund.delahunty@outlook.c | |om --- Comment #16 from Ray Delahunty <raymund.delahunty@outlook.com> --- As part of signing off Bug 41730 I was thinking about this feature. It would a good step on the way to a bigger fix as per Bug 23861. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24288 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=40117 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24288 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Patch doesn't apply CC| |lucas@bywatersolutions.com --- Comment #17 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- I see no reason to leave this 'In discussion', patch doesn't apply currently. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24288 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115581|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24288 --- Comment #18 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 206579 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206579&action=edit Bug 24288: Add wording to authorized value interface to indicate valid code length TEST PLAN: 1) Apply the patch 2) Add a new authorised value policy in the LOST, NOTFORLOAN, DAMAGED, RESTRICTED, and WITHDRAWN categories 3) Check that there is a new warning displaying next to the Authorized value field stating "The authorized value field in the X category must be a one-digit numeric value" 4) Check that this same warning appears when modifying the same authorised values 5) Check that the warning doesn't appear in any other authorized value category. Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24288 --- Comment #19 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Rebased for current main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24288 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35990 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35990 [Bug 35990] [OMNIBUS] Improvements for using tinyint authorised values -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24288 --- Comment #20 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 206582 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206582&action=edit Bug 24288: (follow-up) Adjust language to be more specific Patch from commit 3597be5 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24288 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|kyle@bywatersolutions.com |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24288 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24288 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24288 --- Comment #21 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 206583 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206583&action=edit Bug 24288: (follow-up) Add explaination of positive vs negative nfl values Patch from commit 969f3d8 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24288 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Signed Off QA Contact|lucas@bywatersolutions.com |testopia@bugs.koha-communit | |y.org --- Comment #22 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Now I've done too much here and am excusing myself from QA. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24288 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |jrobb@sekls.org |y.org | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org