[Bug 19068] New: OPAC purchase suggestion doesn' t allow users to enter quantity of items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19068 Bug ID: 19068 Summary: OPAC purchase suggestion doesn't allow users to enter quantity of items Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: J.P.Knight@lboro.ac.uk QA Contact: testopia@bugs.koha-community.org Created attachment 65767 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65767&action=edit One line addition to opac-suggestions.tt to allow quantities to be entered Our librarians commented that the Koha purchase suggestions form doesn't allow the quantity of items to be suggested. In an academic library, sometimes the academics will make suggestions for reading material and have an idea how popular it may be, even for modules/courses that aren't yet running so don't (officially) have any students allocated to them. This enhancement just exposes the quantity field to the OPAC suggestions form to permit the end user to enter this if they wish. The librarians can of course override this quantity when they process the suggestion. Test Plan (assuming using kohadevbox VM): 1) apply patch and turn on purchase suggestions 2) Go to http://localhost:8080/cgi-bin/koha/opac-suggestions.pl?op=add and notice that there is now a quantity field available. 3) Make a purchasing suggestion using this form, including a quantity. 4) Log in as a member of library staff and go to Home › Acquisitions › Suggestions 5) Confirm that the previously entered suggestion is there, and that the correct quantity appears in the "Acquisition information" section. 6) Edit the purchasing suggestion, change the quantity, save it and check that the new quantity appears in the suggestion. I've popped an ID attribute of "opac-suggestion-quantity" to the surrounding <li> so that CSS can easily make this optional field disappear (as suggested by cait on IRC). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19068 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Jon, there is some information missing from your patch so that it doesn't apply cleanly with git commands. It's missing the "header" on top, that includes your authorship etc. How did you create the patch? You can create formatted patch files with "git format-patch" Or you could use git bz (https://wiki.koha-community.org/wiki/Git_bz_configuration). If you are using a kohadevbox this will already be preinstalled, but requires some settings in your configuration file to work right. Please let us know if we can help! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19068 --- Comment #2 from Jon Knight <J.P.Knight@lboro.ac.uk> --- I created the patch using "git diff". I'll create a formatted patch next week (I'm not at the machine that has the kohadevbox VM on it at the moment). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19068 --- Comment #3 from Jon Knight <J.P.Knight@lboro.ac.uk> --- Created attachment 66281 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66281&action=edit Add quantity field to the opac suggestions form. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19068 Jon Knight <J.P.Knight@lboro.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65767|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19068 Jon Knight <J.P.Knight@lboro.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #4 from Jon Knight <J.P.Knight@lboro.ac.uk> --- New version of the patch uploaded, hopefully this time in the correct format. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19068 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Jon, patch def looks better! One more small but important thing. In the second line of the patch it reads: From: Your Full Name <your_email> That means you haven't set up your git completely yet. The name and address there will be visible in git and also will make your name show up in the release notes. I think you will just need to run those 2 commands with your correct information, before rerunning the format-patch command again: git config --global user.name "Your NAME" git config --global user.email "your@mail.com" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19068 --- Comment #6 from Jon Knight <J.P.Knight@lboro.ac.uk> --- Ah thanks - those lines weren't in the git bz config set up on https://wiki.koha-community.org/wiki/Git_bz_configuration#Configure_git-bz that I followed to set up the kohadevbox git bz set up. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19068 Jon Knight <J.P.Knight@lboro.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66281|0 |1 is obsolete| | --- Comment #7 from Jon Knight <J.P.Knight@lboro.ac.uk> --- Created attachment 66339 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66339&action=edit Add quantity field to the opac suggestions form. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19068 --- Comment #8 from Jon Knight <J.P.Knight@lboro.ac.uk> --- Created attachment 66340 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66340&action=edit Add quantity field to the opac suggestions form (with correct username and email) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19068 Jon Knight <J.P.Knight@lboro.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66339|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19068 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think the git bz instructions might have originally been written with developers switching to it in mind - I'll try to take a look. New patch looks perfect, will try to test and thx for your patience so far! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19068 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19068 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66340|0 |1 is obsolete| | --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 66371 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66371&action=edit [SIGNED OFF] Add quantity field to the opac suggestions form (with correct username and email) https://bugs.koha-community.org/show_bug.cgi?id=19068 Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19068 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19068 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66371|0 |1 is obsolete| | --- Comment #11 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 66755 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66755&action=edit Add quantity field to the opac suggestions form (with correct username and email) https://bugs.koha-community.org/show_bug.cgi?id=19068 Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19068 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |nick@bywatersolutions.com |y.org | CC| |nick@bywatersolutions.com Assignee|oleonard@myacpl.org |J.P.Knight@lboro.ac.uk --- Comment #12 from Nick Clemens <nick@bywatersolutions.com> --- Looks good, includes id so easy to hide if unwanted -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19068 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #13 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19068 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolin.somers@biblibre.co | |m --- Comment #14 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 17.05.x, will be in 17.05.06. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19068 --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This won't get ported back to 16.11.x as it is an enhancement. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19068 Niamh <niamh.walker-headon@it-tallaght.ie> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |niamh.walker-headon@it-tall | |aght.ie -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19068 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Stable |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org