https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33293 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 148483 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148483&action=edit Bug 33293: Use template wrapper for tabs: Holds This patch updates the holds template so that it uses the new WRAPPER directive to build tabbed navigation. Note: this patch includes indentation changes, so check the diff accordingly. To test, apply the patch and locate a bibliographic record which can be placed on hold. - Start the process of placing a hold. - If you have any patron clubs defined, there should be two tabs: Patrons and Clubs. Both should look correct and work correctly. - If you have no patron clubs you should see only the Patrons tab. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33293 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148483|0 |1 is obsolete| | --- Comment #2 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 148753 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148753&action=edit Bug 33293: Use template wrapper for tabs: Holds This patch updates the holds template so that it uses the new WRAPPER directive to build tabbed navigation. Note: this patch includes indentation changes, so check the diff accordingly. To test, apply the patch and locate a bibliographic record which can be placed on hold. - Start the process of placing a hold. - If you have any patron clubs defined, there should be two tabs: Patrons and Clubs. Both should look correct and work correctly. - If you have no patron clubs you should see only the Patrons tab. Works as advertised. Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33293 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148753|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 149320 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149320&action=edit Bug 33293: Use template wrapper for tabs: Holds This patch updates the holds template so that it uses the new WRAPPER directive to build tabbed navigation. Note: this patch includes indentation changes, so check the diff accordingly. To test, apply the patch and locate a bibliographic record which can be placed on hold. - Start the process of placing a hold. - If you have any patron clubs defined, there should be two tabs: Patrons and Clubs. Both should look correct and work correctly. - If you have no patron clubs you should see only the Patrons tab. Works as advertised. Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33293 --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33293 Jacob O'Mara <jacob.omara@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.05 released in| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33293 Slava Shishkin <slavashishkin@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33885 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33885 [Bug 33885] Get HTTP 500 when retrieving orders created by a non-existent (deleted) user -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33293 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|33885 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33885 [Bug 33885] Get HTTP 500 when retrieving orders created by a non-existent (deleted) user -- You are receiving this mail because: You are watching all bug changes.