https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18913 --- Comment #1 from Pongtawat <pongtawat@punsarn.asia> --- Created attachment 64935 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64935&action=edit Allow symbolic link in /etc/koha/sites Test Plan: Before patch: 1) Create a Koha site called demo 2) mv /etc/koha/sites/demo /srv/demo 3) ln -s /srv/demo /etc/koha/sites/ 4) koha-list will not show demo as one of the site 5) koha-list --enabled will not show demo as one of the site After patch: 1) Create a Koha site called demo 2) mv /etc/koha/sites/demo /srv/demo 3) ln -s /srv/demo /etc/koha/sites/ 4) koha-list will show demo as one of the site 5) koha-list --enabled will show demo as one of the site -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18913 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18913 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset@hotmail.com --- Comment #3 from M. Tompsett <mtompset@hotmail.com> --- Had to adapt test plan, because you need to copy the script file into place. perl /home/vagrant/misc4dev/do_all_you_can_do.pl --instance test --userid admin --password admin But other than that, seems to work. -L basically says to follow symbolic links, so this doesn't break anything as far as I can tell. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18913 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64935|0 |1 is obsolete| | --- Comment #4 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 68511 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68511&action=edit Bug 18913 - Allows symbolic link in /etc/koha/sites Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18913 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Should this be targetted for master? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18913 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68511|0 |1 is obsolete| | --- Comment #7 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 71939 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71939&action=edit Bug 18913: Allow symbolic link in /etc/koha/sites This patch makes the koha-* scripts follow symbolic links when querying for Koha instances. Without it, it is not possible to define instances outside the /etc/koha/sites directory, To test: - Create a symlink in /etc/koha/sites: $ sudo ln -s /tmp /etc/koha/sites/test - Test the original is_instance function: $ . /usr/share/koha/bin/koha-functions.sh $ is_instance test && echo success || echo failure => FAIL: symlinks are not considered instance names (i.e. failure is printed) - Apply this patch - Update the koha-functions.sh file: $ perl misc4dev/cp_debian_files.pl - Test is_instance again: $ . /usr/share/koha/bin/koha-functions.sh $ is_instance test && echo success || echo failure => SUCCESS: symlinks are considered instance names (i.e. success is printed) - Sign off :-D Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18913 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Patch pushed to master for 18.05 Congratulations Pongtawat for your first patch in! -- You are receiving this mail because: You are watching all bug changes.