[Bug 20037] New: Switch single-column templates to Bootstrap grid: Serials
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20037 Bug ID: 20037 Summary: Switch single-column templates to Bootstrap grid: Serials Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Keywords: Academy Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: testopia@bugs.koha-community.org Blocks: 19980 There are several single-column Circulation templates which can be updated to use the Bootstrap grid. - serials\acqui-search-result.tt - serials\acqui-search.tt - serials\result.tt - serials\subscription-bib-search.tt Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19980 [Bug 19980] Omnibus: Update single-column templates to use Bootstrap grid -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20037 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20037 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 70707 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70707&action=edit Bug 20037: Switch single-column templates to Bootstrap grid: Serials This patch updates several single-column Serials module templates to use the Bootstrap grid. In addition to grid changes, some templates have been modified to include the footer with the correct popup parameter. - serials\acqui-search.tt - Go to Serials -> New subscription. Click "Search for a vendor." - serials\acqui-search-result.tt - Vendor search results - serials\result.tt - Click "Search for record." - serials\subscription-bib-search.tt - Catalog search results. Each of these pages should look correct. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20037 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |claire_gravely@hotmail.com --- Comment #2 from Claire Gravely <claire_gravely@hotmail.com> --- hiya, acqui-search.tt is mising the bootstrap grid. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20037 --- Comment #3 from Claire Gravely <claire_gravely@hotmail.com> --- (In reply to Claire Gravely from comment #2)
hiya, acqui-search.tt is mising the bootstrap grid.
Ignore that. Everything is lovely! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20037 --- Comment #4 from Claire Gravely <claire_gravely@hotmail.com> --- (In reply to Claire Gravely from comment #3)
(In reply to Claire Gravely from comment #2)
hiya, acqui-search.tt is mising the bootstrap grid.
Ignore that. Everything is lovely!
Sorry, double checked the wrong bit :| It does seem to be missing. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20037 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20037 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20037 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70707|0 |1 is obsolete| | --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 71269 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71269&action=edit Bug 20037: Switch single-column templates to Bootstrap grid: Serials This patch updates several single-column Serials module templates to use the Bootstrap grid. In addition to grid changes, some templates have been modified to include the footer with the correct popup parameter. - serials\acqui-search.tt - Go to Serials -> New subscription. Click "Search for a vendor." - serials\acqui-search-result.tt - Vendor search results - serials\result.tt - Click "Search for record." - serials\subscription-bib-search.tt - Catalog search results. Each of these pages should look correct. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20037 --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- I submitted a follow-up to make this patch more consistent, but: It's not that acqui-search.tt was missing the Bootstrap grid, it's that it has minimal Bootstrap markup because it's a very simple template. It's not really necessary to define columns and rows when there aren't multiples of either. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20037 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20037 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71269|0 |1 is obsolete| | --- Comment #7 from Claire Gravely <claire_gravely@hotmail.com> --- Created attachment 71350 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71350&action=edit Bug 20037: Switch single-column templates to Bootstrap grid: Serials This patch updates several single-column Serials module templates to use the Bootstrap grid. In addition to grid changes, some templates have been modified to include the footer with the correct popup parameter. - serials\acqui-search.tt - Go to Serials -> New subscription. Click "Search for a vendor." - serials\acqui-search-result.tt - Vendor search results - serials\result.tt - Click "Search for record." - serials\subscription-bib-search.tt - Catalog search results. Each of these pages should look correct. Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20037 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20037 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71350|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 71908 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71908&action=edit Bug 20037: Switch single-column templates to Bootstrap grid: Serials This patch updates several single-column Serials module templates to use the Bootstrap grid. In addition to grid changes, some templates have been modified to include the footer with the correct popup parameter. - serials\acqui-search.tt - Go to Serials -> New subscription. Click "Search for a vendor." - serials\acqui-search-result.tt - Vendor search results - serials\result.tt - Click "Search for record." - serials\subscription-bib-search.tt - Catalog search results. Each of these pages should look correct. Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20037 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20037 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Master |RESOLVED CC| |nick@bywatersolutions.com --- Comment #10 from Nick Clemens <nick@bywatersolutions.com> --- Enhancement, not backported for 17.11 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org