[Bug 28914] New: Wording in authentication forms is confusing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28914 Bug ID: 28914 Summary: Wording in authentication forms is confusing Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Authentication Assignee: koha-bugs@lists.koha-community.org Reporter: fridolin.somers@biblibre.com QA Contact: testopia@bugs.koha-community.org CC: dpavlin@rot13.org In most authentication forms we see : Fields "Login:" and "Password:" with a submit button "Log in". In some places submit button contains "Login", which is confusing for translation. Also in opac-user.pl semicolon are missing. I propose we always use : Fields "Login:", "Password:" with a submit button "Log in". It will generate less translation entries. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28914 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28914 --- Comment #1 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 124196 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124196&action=edit Bug 28914: Uniform wording in authentication forms In most authentication forms we see : Fields "Login:" and "Password:" with a submit button "Log in". In some places submit button contains "Login", which is confusing for translation. Also in opac-user.pl ":" is missing. I propose we always use : Fields "Login:", "Password:" with a submit button "Log in". It will generate less translation entries. Test plan: 1) Log out if you are logged in 2) Go to staff interface 3) Check you see field "Login:" and button "Log in" 4) Same for webinstaller 5) Go to OPAC page /cgi-bin/koha/opac-user.pl 6) Check you see fields "Login:" and "Password:" -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28914 e.betemps <e.betemps@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |e.betemps@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28914 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28914 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124196|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 124216 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124216&action=edit Bug 28914: Uniform wording in authentication forms In most authentication forms we see : Fields "Login:" and "Password:" with a submit button "Log in". In some places submit button contains "Login", which is confusing for translation. Also in opac-user.pl ":" is missing. I propose we always use : Fields "Login:", "Password:" with a submit button "Log in". It will generate less translation entries. Test plan: 1) Log out if you are logged in 2) Go to staff interface 3) Check you see field "Login:" and button "Log in" 4) Same for webinstaller 5) Go to OPAC page /cgi-bin/koha/opac-user.pl 6) Check you see fields "Login:" and "Password:" Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28914 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |fridolin.somers@biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28914 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28914 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124216|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 124218 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124218&action=edit Bug 28914: Uniform wording in authentication forms In most authentication forms we see : Fields "Login:" and "Password:" with a submit button "Log in". In some places submit button contains "Login", which is confusing for translation. Also in opac-user.pl ":" is missing. I propose we always use : Fields "Login:", "Password:" with a submit button "Log in". It will generate less translation entries. Test plan: 1) Log out if you are logged in 2) Go to staff interface 3) Check you see field "Login:" and button "Log in" 4) Same for webinstaller 5) Go to OPAC page /cgi-bin/koha/opac-user.pl 6) Check you see fields "Login:" and "Password:" Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28914 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I didn't dig deep, but I believe we already had agreed on that wording before and made changes. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28914 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |In Discussion CC| |jonathan.druart+koha@gmail. | |com --- Comment #5 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Katrin Fischer from comment #4)
I didn't dig deep, but I believe we already had agreed on that wording before and made changes.
I don't find it either. Can we find it before we push this please? Does the change make sense even if the error says "Invalid username or password"? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28914 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Actually, not resolved, "In Discussion": bug 7867 Can't read the bug right now, so not sure where/why we got stuck. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28914 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=7867 --- Comment #7 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- I had in mind something more recent. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28914 --- Comment #8 from Fridolin Somers <fridolin.somers@biblibre.com> --- Is it at least OK to change submit button "Login" to "Log in" ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28914 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #9 from David Nind <david@davidnind.com> --- (In reply to Fridolin Somers from comment #8)
Is it at least OK to change submit button "Login" to "Log in" ?
It is for the submit button (log in where it as an action (verb), for example: Log in with your user id; login when you are referring to the details they use (noun or adjective), for example: Your login details are <username> and <password>, Enter your credentials in the login page. https://wiki.koha-community.org/wiki/Terminology#L -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28914 --- Comment #10 from Fridolin Somers <fridolin.somers@biblibre.com> --- Thanks for the info David :) I mean here : https://git.koha-community.org/Koha-community/Koha/src/commit/a5a3a330cfc7c7... <p class="submit"><input id="submit-button" type="submit" value="Login" tabindex="4" /></p> We must replace with "Log in" right ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28914 --- Comment #11 from David Nind <david@davidnind.com> --- (In reply to Fridolin Somers from comment #10)
We must replace with "Log in" right ?
Agreed! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28914 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Wording in authentication |Wrong wording in |forms is confusing |authentication forms -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28914 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28914 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124218|0 |1 is obsolete| | --- Comment #12 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 124872 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124872&action=edit Bug 28914: Fix wording in authentication forms In most authentication forms we see : Fields "Login:" and "Password:" with a submit button "Log in". In some places submit button contains "Login", which is confusing for translation. It is not correct according to terminology https://wiki.koha-community.org/wiki/Terminology#L Also in opac-user.pl ":" is missing, it generates new translation entries. Test plan: 1) Log out if you are logged in 2) Go to staff interface 3) Check you see button "Log in" 4) Go to OPAC page /cgi-bin/koha/opac-user.pl 5) Check you see fields "Login:" and "Password:" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28914 --- Comment #13 from Fridolin Somers <fridolin.somers@biblibre.com> --- Ok now patch only fixes a submit button wording and adds ":" to inputs. Back to need signoff. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28914 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28914 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124872|0 |1 is obsolete| | --- Comment #14 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 124882 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124882&action=edit Bug 28914: Fix wording in authentication forms In most authentication forms we see : Fields "Login:" and "Password:" with a submit button "Log in". In some places submit button contains "Login", which is confusing for translation. It is not correct according to terminology https://wiki.koha-community.org/wiki/Terminology#L Also in opac-user.pl ":" is missing, it generates new translation entries. Test plan: 1) Log out if you are logged in 2) Go to staff interface 3) Check you see button "Log in" 4) Go to OPAC page /cgi-bin/koha/opac-user.pl 5) Check you see fields "Login:" and "Password:" Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28914 Joonas Kylmälä <joonas.kylmala@iki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28914 Joonas Kylmälä <joonas.kylmala@iki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124882|0 |1 is obsolete| | --- Comment #15 from Joonas Kylmälä <joonas.kylmala@iki.fi> --- Created attachment 125023 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125023&action=edit Bug 28914: Fix wording in authentication forms In most authentication forms we see : Fields "Login:" and "Password:" with a submit button "Log in". In some places submit button contains "Login", which is confusing for translation. It is not correct according to terminology https://wiki.koha-community.org/wiki/Terminology#L Also in opac-user.pl ":" is missing, it generates new translation entries. Test plan: 1) Log out if you are logged in 2) Go to staff interface 3) Check you see button "Log in" 4) Go to OPAC page /cgi-bin/koha/opac-user.pl 5) Check you see fields "Login:" and "Password:" Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28914 Joonas Kylmälä <joonas.kylmala@iki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |joonas.kylmala@iki.fi |y.org | CC| |joonas.kylmala@iki.fi -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28914 --- Comment #16 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- In my opinion it would have been better to continue and finish the work started on bug 7867. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28914 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28914 --- Comment #17 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28914 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|21.11.00 |21.11.00,21.05.05 released in| | CC| |kyle@bywatersolutions.com --- Comment #18 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to 21.05.x for 21.05.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28914 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.11.00,21.05.05 |21.11.00,21.05.05,20.11.11 released in| | Status|Pushed to stable |Pushed to oldstable --- Comment #19 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 20.11.x for 20.11.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28914 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED CC| |victor@tuxayo.net Resolution|--- |FIXED --- Comment #20 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Not backported to oldoldstable (20.05.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org