[Bug 28829] New: Useless single quote escaping in value_builder/unimarc_field_4XX.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28829 Bug ID: 28829 Summary: Useless single quote escaping in value_builder/unimarc_field_4XX.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: fridolin.somers@biblibre.com QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl Since Bug 23777 added To.json, single quote escaping in value_builder/unimarc_field_4XX.pl is useless. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28829 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |fridolin.somers@biblibre.co |ity.org |m Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28829 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |23777 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23777 [Bug 23777] Text converted to html entity codes in cataloguing edit form -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28829 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28828 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28829 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28829 --- Comment #1 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 123593 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123593&action=edit Bug 28829: Remove single quote escaping in value_builder/unimarc_field_4XX.pl Since Bug 23777 added To.json, single quote escaping in value_builder/unimarc_field_4XX.pl is useless. Test plan: 1) Use UNIMARC database 2) Define value builder unimarc_field_4XX on 463$t 3) Create a record B1 with 200$a : L'avion 4) Create a record B2 5) Click on value builder in 463$t 6) Search for record B1 7) Click on "Choose" => Without patch 463$t contains : L\'avion => With patch 463$t contains : L'avion -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28829 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28829 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123593|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 123598 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123598&action=edit Bug 28829: Remove single quote escaping in value_builder/unimarc_field_4XX.pl Since Bug 23777 added To.json, single quote escaping in value_builder/unimarc_field_4XX.pl is useless. Test plan: 1) Use UNIMARC database 2) Define value builder unimarc_field_4XX on 463$t 3) Create a record B1 with 200$a : L'avion 4) Create a record B2 5) Click on value builder in 463$t 6) Search for record B1 7) Click on "Choose" => Without patch 463$t contains : L\'avion => With patch 463$t contains : L'avion Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28829 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28829 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123598|0 |1 is obsolete| | --- Comment #3 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 124783 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124783&action=edit Bug 28829: Remove single quote escaping in value_builder/unimarc_field_4XX.pl Since Bug 23777 added To.json, single quote escaping in value_builder/unimarc_field_4XX.pl is useless. Test plan: 1) Use UNIMARC database 2) Define value builder unimarc_field_4XX on 463$t 3) Create a record B1 with 200$a : L'avion 4) Create a record B2 5) Click on value builder in 463$t 6) Search for record B1 7) Click on "Choose" => Without patch 463$t contains : L\'avion => With patch 463$t contains : L'avion Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28829 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28829 --- Comment #4 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28829 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Pushed to master |Pushed to stable Version(s)|21.11.00 |21.11.00,21.05.05 released in| | --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to 21.05.x for 21.05.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28829 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.11.00,21.05.05 |21.11.00,21.05.05,20.11.11 released in| | Status|Pushed to stable |Pushed to oldstable --- Comment #6 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 20.11.x for 20.11.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28829 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |victor@tuxayo.net Status|Pushed to oldstable |RESOLVED --- Comment #7 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Not backported to oldoldstable (20.05.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org