[Bug 10523] New: Remove two obsolete routines from Installer.pm
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10523 Bug ID: 10523 Summary: Remove two obsolete routines from Installer.pm Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Installation and upgrade (web-based installer) Assignee: m.de.rooy@rijksmuseum.nl Reporter: m.de.rooy@rijksmuseum.nl CC: gmcharlt@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10523 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10523 --- Comment #1 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 19314 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19314&action=edit Bug 10523: Remove two obsolete routines from Installer.pm The routines sql_file_list and marcflavour_list in Installer.pm are not used. There are some references to them in probably obsolete '/lib' test units. I changed these test units for the record too. Also: removed the not-existing marcflavour parameter of sample_data_sql_list in its call in install.pl. Test plan: Run a new install. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10523 --- Comment #2 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- There could be a small clash with bug 10509 in a POD section. Easy conflict to resolve. Does not really matter which bug goes first. (This is the easy one) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10523 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19314|0 |1 is obsolete| | --- Comment #3 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 19323 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19323&action=edit Bug 10523: Remove two obsolete routines from Installer.pm The routines sql_file_list and marcflavour_list in Installer.pm are not used. There are some references to them in probably obsolete '/lib' test units. I changed these test units for the record too. Also: removed the not-existing marcflavour parameter of sample_data_sql_list in its call in install.pl. Test plan: Run a new install. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10523 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |paola.rossi@cineca.it Assignee|m.de.rooy@rijksmuseum.nl |paola.rossi@cineca.it --- Comment #4 from Paola Rossi <paola.rossi@cineca.it> --- Created attachment 21012 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21012&action=edit this is the patch after rebasing it. I also signed off it -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10523 --- Comment #5 from Paola Rossi <paola.rossi@cineca.it> --- I rebased the patch after deleting three *.pm from test section, because the corresponding *.pm modules were already deleted in HEAD. I removed from the patch the following *.pm: t/db_dependent/lib/KohaTest/Installer/SqlScripts.pm t/db_dependent/lib/KohaTest/Installer.pm t/db_dependent/lib/KohaTest.pm Then I signed off the rebased patch. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10523 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19323|0 |1 is obsolete| | Attachment #21012|0 |1 is obsolete| | --- Comment #6 from Paola Rossi <paola.rossi@cineca.it> --- Created attachment 21013 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21013&action=edit Bug 10523: Remove two obsolete routines from Installer.pm -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10523 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com QA Contact| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10523 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21013|0 |1 is obsolete| | --- Comment #7 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 21015 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21015&action=edit Bug 10523: Remove two obsolete routines from Installer.pm The routines sql_file_list and marcflavour_list in Installer.pm are not used. There are some references to them in probably obsolete '/lib' test units. I changed these test units for the record too. Also: removed the not-existing marcflavour parameter of sample_data_sql_list in its call in install.pl. Test plan: Run a new install. Signed-off-by: Paola Rossi <paola.rossi@cineca.it> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10523 --- Comment #8 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 21016 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21016&action=edit Bug 10523: QA Followup - Remove unused variable Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10523 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10523 Zeno Tajoli <z.tajoli@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |z.tajoli@cineca.it Assignee|paola.rossi@cineca.it |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10523 Zeno Tajoli <z.tajoli@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|paola.rossi@cineca.it, | |z.tajoli@cineca.it | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10523 --- Comment #9 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Thanks for QA, Kyle. But I am not sure about the qa followup. It is just theoretical, because it only touches lines in pod section. But load_sql_in_order still needs a second parameter. So I think you should not remove it. Can we do without the second patch? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10523 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21016|0 |1 is obsolete| | --- Comment #10 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Comment on attachment 21016 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21016 Bug 10523: QA Followup - Remove unused variable Obsoleting this patch in light of the earlier comment. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10523 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #11 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Marcel! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org