http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11142 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 22474 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22474&action=edit [PATCH] Bug 11142 - Update Bootstrap theme's place hold form to match the new version in prog The update to the prog theme's place hold page (Bug 10836) happened after the Bootstrap theme's place hold form had already been converted, so it lags behind. This patch applies the changes made to prog to Bootstrap. To test, switch to the Bootstrap theme and follow the test plan from Bug 10836: Place single and multiple holds under various conditions: - Items which are not available to be place on hold - With OpacHoldNotes on and off - With OPACItemHolds on and off - With OPACAllowHoldDateInFuture on and off - With IndependentBranches on and off - With JavaScript disabled Test setting hold notes, holding specific copies, and setting hold start dates. When setting a hold start date and hold expiration date, the two datepickers should work together to prevent invalid date combinations (dates after today, expiration dates which precede the start date). -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11142 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22474|0 |1 is obsolete| | --- Comment #2 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 22531 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22531&action=edit [SIGNED-OFF] Bug 11142 - Update Bootstrap theme's place hold form to match the new version in prog The update to the prog theme's place hold page (Bug 10836) happened after the Bootstrap theme's place hold form had already been converted, so it lags behind. This patch applies the changes made to prog to Bootstrap. To test, switch to the Bootstrap theme and follow the test plan from Bug 10836: Place single and multiple holds under various conditions: - Items which are not available to be place on hold - With OpacHoldNotes on and off - With OPACItemHolds on and off - With OPACAllowHoldDateInFuture on and off - With IndependentBranches on and off - With JavaScript disabled Test setting hold notes, holding specific copies, and setting hold start dates. When setting a hold start date and hold expiration date, the two datepickers should work together to prevent invalid date combinations (dates after today, expiration dates which precede the start date). Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> No koha-qa errors. Works as described, very well. Tested all situations, all syspref, and without JavaScript. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11142 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |gmcharlt@gmail.com --- Comment #3 from Galen Charlton <gmcharlt@gmail.com> --- Electing to push this to master now so that Bootstrap becoming the default theme does not effectively cause a regression of bug 10836. Thanks, Owen! -- You are receiving this mail because: You are watching all bug changes.