[Bug 20284] New: ILL: Adding a 'new request' from OPAC fails with template error if text exists in ILLModuleCopyrightClearance
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20284 Bug ID: 20284 Summary: ILL: Adding a 'new request' from OPAC fails with template error if text exists in ILLModuleCopyrightClearance Change sponsored?: --- Product: Koha Version: 17.11 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: ILL Assignee: koha-bugs@lists.koha-community.org Reporter: jonathan.field@ptfs-europe.com If text is added to the system preference ILLModuleCopyrightClearance then you are unable to place an ILL request in the OPAC. You get a list of the backends but, upon selecting any of them, you get an internal server error. Error log shows: Template process failed: file error - : not found at /usr/share/koha/lib/C4/Templates.pm line 122. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20284 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|minor |major CC| |jonathan.druart@bugs.koha-c | |ommunity.org Version|17.11 |master --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Upping severity as the feature is broken at the OPAC. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20284 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |7317 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20284 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20284 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20284 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |20536 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20536 [Bug 20536] ILL: authnotrequired not explicitly unset -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20284 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|20536 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20536 [Bug 20536] ILL: authnotrequired not explicitly unset -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20284 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20548 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20548 [Bug 20548] Remove copyright clearance workflow from staff created ILL requests -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20284 --- Comment #2 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 73870 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73870&action=edit Bug [20284] - [ILL: Adding a 'new request' from ..] This patch fixes the display of the copyright notice text that is defined in ILLModuleCopyrightClearance preference when placing ILL requests from the OPAC. Handling of the copyrightclearance stage was missing, this has been added. Test plan: - Ensure you have at least one ILL backend available: https://wiki.koha-community.org/wiki/ILL_backends - Ensure you have the "ILLModule" preference enabled - Add some text to the "ILLModuleCopyrightClearance" preference - Navigate to a search results page in the catalog - Click the "Make an Interlibrary Loan request" link at the bottom - Choose "Create a new request", then select a backend - TEST: Check the text you added earlier is displayed with buttons for agreeing or disagreeing (prior to this patch, this screen displayed an error) - TEST: Check that clicking "Yes" takes you to the form for adding request details - TEST: Check that clicking "No" takes you back to the "Interlibrary loan requests" page -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20284 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |andrew.isherwood@ptfs-europ | |e.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20284 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |andrew.isherwood@ptfs-europ |ity.org |e.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20284 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20284 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73870|0 |1 is obsolete| | --- Comment #3 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 74156 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74156&action=edit Bug 20284: ILLModuleCopyrightClearance text breaks This patch fixes the display of the copyright notice text that is defined in ILLModuleCopyrightClearance preference when placing ILL requests from the OPAC. Handling of the copyrightclearance stage was missing, this has been added. To test: 1) Ensure you have at least one ILL backend available: https://wiki.koha-community.org/wiki/ILL_backends 2) Ensure you have the "ILLModule" preference enabled 3) Add some text to the "ILLModuleCopyrightClearance" preference 4) Navigate to a search results page in the catalog 5) Click the "Make an Interlibrary Loan request" link at the bottom 6) Choose "Create a new request", then select a backend 7) Observe the text you added earlier is displayed with buttons for agreeing or disagreeing (prior to this patch, this screen displayed an error) 8) Observe that clicking "Yes" takes you to the form for adding request details 9) Observe that clicking "No" takes you back to the "Interlibrary loan requests" page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20284 --- Comment #4 from Barry Cannon <bc@interleaf.ie> --- Created attachment 74426 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74426&action=edit Bug 11674: DBRev 17.12.00.031 Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20284 Barry Cannon <bc@interleaf.ie> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bc@interleaf.ie --- Comment #5 from Barry Cannon <bc@interleaf.ie> --- ummm, really not sure what happened here. I have signed this patch off but I seem to have contaminated it with a completely different bug. Suggestions welcome! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20284 Barry Cannon <bc@interleaf.ie> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #6 from Barry Cannon <bc@interleaf.ie> --- Signed off as previous comment -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20284 --- Comment #7 from Josef Moravec <josef.moravec@gmail.com> --- (In reply to Barry Cannon from comment #5)
ummm, really not sure what happened here. I have signed this patch off but I seem to have contaminated it with a completely different bug. Suggestions welcome!
Hi Barry, you just attached the last commit from top of master, not from branch with this patch applied. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20284 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74426|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20284 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #8 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Barry Cannon from comment #5)
ummm, really not sure what happened here. I have signed this patch off but I seem to have contaminated it with a completely different bug. Suggestions welcome!
Will add your signoff line (for this time ;) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20284 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74156|0 |1 is obsolete| | --- Comment #9 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 74599 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74599&action=edit Bug 20284: ILLModuleCopyrightClearance text breaks This patch fixes the display of the copyright notice text that is defined in ILLModuleCopyrightClearance preference when placing ILL requests from the OPAC. Handling of the copyrightclearance stage was missing, this has been added. To test: 1) Ensure you have at least one ILL backend available: https://wiki.koha-community.org/wiki/ILL_backends 2) Ensure you have the "ILLModule" preference enabled 3) Add some text to the "ILLModuleCopyrightClearance" preference 4) Navigate to a search results page in the catalog 5) Click the "Make an Interlibrary Loan request" link at the bottom 6) Choose "Create a new request", then select a backend 7) Observe the text you added earlier is displayed with buttons for agreeing or disagreeing (prior to this patch, this screen displayed an error) 8) Observe that clicking "Yes" takes you to the form for adding request details 9) Observe that clicking "No" takes you back to the "Interlibrary loan requests" page Signed-off-by: Barry Cannon <bc@interleaf.ie> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20284 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |m.de.rooy@rijksmuseum.nl Status|Signed Off |Failed QA --- Comment #10 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Redirect without exit. See other bug? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20284 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20284 --- Comment #11 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 74652 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74652&action=edit Bug 20284: (follow-up) Added missing 'exit's This patch adds the exits that were missing after the redirects -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20284 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #12 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Skipping SO for the follow-up. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20284 Joe McGlynn <joe.mcglynn@educampus.ie> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joe.mcglynn@educampus.ie -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20284 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74599|0 |1 is obsolete| | --- Comment #13 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 75079 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75079&action=edit Bug 20284: ILLModuleCopyrightClearance text breaks This patch fixes the display of the copyright notice text that is defined in ILLModuleCopyrightClearance preference when placing ILL requests from the OPAC. Handling of the copyrightclearance stage was missing, this has been added. To test: 1) Ensure you have at least one ILL backend available: https://wiki.koha-community.org/wiki/ILL_backends 2) Ensure you have the "ILLModule" preference enabled 3) Add some text to the "ILLModuleCopyrightClearance" preference 4) Navigate to a search results page in the catalog 5) Click the "Make an Interlibrary Loan request" link at the bottom 6) Choose "Create a new request", then select a backend 7) Observe the text you added earlier is displayed with buttons for agreeing or disagreeing (prior to this patch, this screen displayed an error) 8) Observe that clicking "Yes" takes you to the form for adding request details 9) Observe that clicking "No" takes you back to the "Interlibrary loan requests" page Signed-off-by: Barry Cannon <bc@interleaf.ie> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20284 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74652|0 |1 is obsolete| | --- Comment #14 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 75080 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75080&action=edit Bug 20284: (follow-up) Added missing 'exit's This patch adds the exits that were missing after the redirects Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20284 --- Comment #15 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 75081 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75081&action=edit Bug 20284: (QA follow-up) superlibrarian has ill permissions Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20284 --- Comment #16 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 75082 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75082&action=edit Bug 20284: Fix minor compilation errors Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20284 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20284 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|m.de.rooy@rijksmuseum.nl |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20284 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #17 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20284 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #18 from M. Tompsett <mtompset@hotmail.com> --- *** Bug 20646 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20284 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20284 Bug 20284 depends on bug 7317, which changed state. Bug 7317 Summary: Add an Interlibrary Loan Module to Circulation and OPAC https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20284 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_17_11_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20284 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20284 Andrew Isherwood <bugzilla@warmlight.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|bugzilla@warmlight.co.uk | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org