[Bug 6278] New: Funny translation bug with XSLT subfieldSelect parameters
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6278 Bug #: 6278 Summary: Funny translation bug with XSLT subfieldSelect parameters Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Platform: All OS/Version: All Status: NEW Severity: normal Priority: P5 Component: I18N/L10N AssignedTo: frederic@tamil.fr ReportedBy: m.de.rooy@rijksmuseum.nl QAContact: koha-bugs@lists.koha-community.org English XSLT contains constructs as: <xsl:call-template name="subfieldSelect"> <xsl:with-param name="codes">at</xsl:with-param> </xsl:call-template> The translated Dutch XSLT contains: <xsl:call-template name="subfieldSelect"> <xsl:with-param name="codes">bij</xsl:with-param> </xsl:call-template> Since at is not a word here, but just two subfields a and t, they should not have been translated of course. Incidentally, bij is the Dutch translation of the English at. The word gets translated and so subfields a and t are replaced by b, i and j. In most cases resulting in no information. Note: Occurs 5 times in MARC21slim2OPACDetail.xsl. And affects display of fields 490/8XX, 773, 780/785. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6278 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-05-03 08:37:21 UTC --- I have run into this exact problem too. The problem is not solved by just not translating it, because other files include an 'at' that you want to have translated. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6278 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz --- Comment #2 from Chris Cormack <chris@bigballofwax.co.nz> 2011-05-03 08:59:14 UTC --- Yes, it is very hard for the script to know that at is not a word, but 2 subfields. I dont have a solution, maybe Frederic does. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6278 --- Comment #3 from Frédéric Demians <frederic@tamil.fr> 2011-05-03 09:31:05 UTC --- (In reply to comment #1)
I have run into this exact problem too. The problem is not solved by just not translating it, because other files include an 'at' that you want to have translated.
Where exactly? I have just one msgid "at" extracted from .xsl files. No extraction from .tt files. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6278 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-05-03 10:09:18 UTC --- Ah, I am sorry. I noticed this in one of the older versions, probably 3.2.x and forgot to check 3.4. Perhaps this has been solved by a change to the templates. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6278 --- Comment #5 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2011-09-01 10:23:13 UTC --- Sending a patch: This patch resolves the situation of translating the parameters at (meaning subfield a and t) of subfieldSelect by replacing at with a_t. This string will not be translated and the xslt function subfieldSelect just ignores the underscore. It is a pragmatic and easy solution. Theoretically, we should look for a solution in the translation parser. This is much harder and would probably not result in better code in those modules. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6278 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|frederic@tamil.fr |m.de.rooy@rijksmuseum.nl --- Comment #6 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2011-09-01 10:24:46 UTC --- Test this patch with the following remarks in mind: 1) This patch deals with XSLT. So you should enable XSLT at OPAC detail. 2) In English or any language not translating the word at: Just check if the links for a MARC 490, 773, 780 or 785 still work at the opac detail page. 3) For a language translating the word at (like Dutch where at becomes bij), you should first rerun your translation process (at least for the OPAC). 4) In that language: Check the results on the vernacular opac detail page for MARC 490, 773, 780 or 785. Without the patch, you would not see a link following e.g. the Series label (with 490 first indicator set to 1). With the patch, you should see a link now. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6278 --- Comment #7 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2011-09-01 10:27:25 UTC --- Created attachment 5248 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5248 Patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6278 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6278 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5248|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-09-21 05:13:17 UTC --- Created attachment 5488 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5488 [SIGNED-OFF] 6278 Funny translation bug with XSLT subfieldSelect parameters This patch resolves the situation of translating the parameters at (meaning subfield a and t) of subfieldSelect by replacing at with a_t. This string will not be translated and the xslt function subfieldSelect just ignores the underscore. It is a pragmatic and easy solution. Theoretically, we should look for a solution in the translation parser. This is much harder and would probably not result in better code in those modules. Test this patch with the following remarks in mind: 1) This patch deals with XSLT. So you should enable XSLT at OPAC detail. 2) In English or any language not translating the word at: Just check if the links for a MARC 490, 773, 780 or 785 still work at the opac detail page. 3) For a language translating the word at (like Dutch where at becomes bij), you should first rerun your translation process (at least for the OPAC). 4) In that language: Check the results on the vernacular opac detail page for MARC 490, 773, 780 or 785. Without the patch, you would not see a link following e.g. the Series label (with 490 first indicator set to 1). With the patch, you should see a link now. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Pragmatic solution for an annoying problem. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6278 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6278 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain@biblibre.com --- Comment #9 from Paul Poulain <paul.poulain@biblibre.com> 2011-10-07 13:33:55 UTC --- QA comment: well, this is a very small patch, that circumvent a "funny" problem, I agree. This is a workaround, but I agree with katrin it's an easy & pragmatic solution. I vote for "passed QA", but i let ian/chris the "final cut" on this matter, as it's a workaround. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6278 --- Comment #10 from Chris Cormack <chris@bigballofwax.co.nz> 2011-10-08 06:38:21 UTC --- I have no issues if you want to push this through QA. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6278 --- Comment #11 from Paul Poulain <paul.poulain@biblibre.com> 2011-10-10 07:09:39 UTC --- Ian, please, confirm you agree with chris & me about accepting this workaround -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6278 Ian Walls <ian.walls@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Signed Off |Passed QA --- Comment #12 from Ian Walls <ian.walls@bywatersolutions.com> 2011-10-12 15:20:03 UTC --- If the subfieldSelect routine ignores underscore and that'll prevent translation, this seems like a very easy and acceptable workaround. Marking as Passed QA. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6278 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Passed QA |Patch Pushed --- Comment #13 from Chris Cormack <chris@bigballofwax.co.nz> 2011-10-13 02:47:29 UTC --- Changes templates, but actually reduces translation needed, pushing -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6278 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |FIXED -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org