[Bug 6747] New: Additional check in opac-export
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6747 Bug #: 6747 Summary: Additional check in opac-export Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Platform: All OS/Version: All Status: ASSIGNED Severity: trivial Priority: PATCH-Sent Component: OPAC AssignedTo: m.de.rooy@rijksmuseum.nl ReportedBy: m.de.rooy@rijksmuseum.nl QAContact: koha-bugs@lists.koha-community.org If GetMarcBiblio function returns undef, the opac-export script does not handle it properly. Trivial patch sent. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6747 --- Comment #1 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2011-08-18 10:44:31 UTC --- Created attachment 5053 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5053 Patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6747 --- Comment #2 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2011-08-18 10:49:44 UTC --- Simple test: Run <yourserver>/cgi-bin/koha/opac-export.pl?format=utf8&op=export&bib=99999999 with the bib number not existing in your db (without this patch). You will get a 500 error. Apply the patch and do it again. Do you get the error message Record not found in your browser now? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6747 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6747 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> 2011-08-18 14:40:27 UTC --- It's hard to imagine how this might happen in the real world, but all error-checking is a good thing. What I'm wondering is whether we should redirect to the 404 page instead of sending a plain error page? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6747 --- Comment #4 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2011-08-22 12:24:37 UTC --- (In reply to comment #3)
It's hard to imagine how this might happen in the real world, but all error-checking is a good thing. What I'm wondering is whether we should redirect to the 404 page instead of sending a plain error page?
Found several 500 errors on deleted records; they are generated by Googlebot. Sending revised patch with 404 and some additional revisions now. While testing, I noticed that formats ris and endnote did not generate something useful. But that is not the point of this report.. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6747 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5053|0 |1 is obsolete| | --- Comment #5 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2011-08-22 12:25:46 UTC --- Created attachment 5083 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5083 Revised patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6747 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|trivial |minor -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6747 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5083|0 |1 is obsolete| | --- Comment #6 from Owen Leonard <oleonard@myacpl.org> 2011-08-24 16:31:30 UTC --- Created attachment 5120 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5120 Signed-off patch Thanks for making that change. I think it's more consistent to use the existing 404 error. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6747 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6747 Ian Walls <ian.walls@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ian.walls@bywatersolutions. | |com --- Comment #7 from Ian Walls <ian.walls@bywatersolutions.com> 2011-08-25 17:26:20 UTC --- Mostly spacing changes, with some default values added to potentially undefined values. Marking as Passed QA. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6747 Ian Walls <ian.walls@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Signed Off |Passed QA -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6747 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Patch Status|Passed QA |Patch Pushed --- Comment #8 from Chris Cormack <chris@bigballofwax.co.nz> 2011-08-26 19:18:33 UTC --- Pushed to master, please test -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6747 --- Comment #9 from Chris Nighswonger <cnighswonger@foundations.edu> 2011-10-26 18:02:27 UTC --- The fix for this bug was published in the 3.4.5 release. If you were the reporter of this bug, please take time to verify the fix and update the status of this bug report accordingly. If the bug is fixed to your satisfaction, please close this report. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6747 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |FIXED -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org