[Bug 16968] New: Remove the use of "onclick" from serial patron and vendor search templates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16968 Bug ID: 16968 Summary: Remove the use of "onclick" from serial patron and vendor search templates Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Serials Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: colin.campbell@ptfs-europe.com, testopia@bugs.koha-community.org There are a few instances of "onclick" in the templates for serial patron and vendor search templates. These should be removed in favor of events defined in the JavaScript. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16968 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16968 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 53684 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53684&action=edit Bug 16968 - Remove the use of "onclick" from serial patron and vendor search templates This patch removes instances of "onclick" from the serials templates for patron and vendor search. To test, go to Serials and click "New subscription." - In the new subscription form, click the "Search for a vendor" link. - In the popup, search for a vendor. Confirm that clicking "Choose" selects the correct vendor. - From the detail page of an existing subscription, click "Create routing list." - Search for a patron and test that the "Add" button in search results works correctly to add patrons to the routing list. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16968 Claire Gravely <c.gravely@arts.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16968 Claire Gravely <c.gravely@arts.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53684|0 |1 is obsolete| | --- Comment #2 from Claire Gravely <c.gravely@arts.ac.uk> --- Created attachment 53722 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53722&action=edit Bug 16968 - Remove the use of "onclick" from serial patron and vendor search templates This patch removes instances of "onclick" from the serials templates for patron and vendor search. To test, go to Serials and click "New subscription." - In the new subscription form, click the "Search for a vendor" link. - In the popup, search for a vendor. Confirm that clicking "Choose" selects the correct vendor. - From the detail page of an existing subscription, click "Create routing list." - Search for a patron and test that the "Add" button in search results works correctly to add patrons to the routing list. Signed-off-by: Claire Gravely <c.gravely@arts.ac.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16968 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16968 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53722|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 53839 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53839&action=edit Bug 16968 - Remove the use of "onclick" from serial patron and vendor search templates This patch removes instances of "onclick" from the serials templates for patron and vendor search. To test, go to Serials and click "New subscription." - In the new subscription form, click the "Search for a vendor" link. - In the popup, search for a vendor. Confirm that clicking "Choose" selects the correct vendor. - From the detail page of an existing subscription, click "Create routing list." - Search for a patron and test that the "Add" button in search results works correctly to add patrons to the routing list. Signed-off-by: Claire Gravely <c.gravely@arts.ac.uk> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16968 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 16.11, thanks Owen! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16968 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Serials |Templates CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org