[Bug 16967] New: Remove the use of "onclick" from serial frequency and numbering management
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16967 Bug ID: 16967 Summary: Remove the use of "onclick" from serial frequency and numbering management Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Serials Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: colin.campbell@ptfs-europe.com, testopia@bugs.koha-community.org There are several instances of "onclick" in the templates for managing serial numbering patterns and serial frequencies. These should be removed in favor of events defined in the JavaScript. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16967 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16967 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 53663 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53663&action=edit Bug 16967 - Remove the use of "onclick" from serial frequency and numbering management This patch removes instance of "onclick" from the templates for serial frequency and numbering management. Events are now defined in the JavaScript. To test, apply the patch and go to Serials -> Manage frequencies. - In the list of frequencies, click the "Delete" button for a frequency which is in use by at least one subscription. In the confirmation dialog, clicking the "Show subscriptions" link should display a list of titles. - Edit or create a frequency. - To test that the form submission validation is still working correctly, enter non-numeric data in the "issues per unit" field and submit the form. This should trigger an error. In Serials -> Manage numbering patterns: - In the list of numbering patterns, click the "Delete" button for a pattern which is in use by at least one subscription. In the confirmation dialog, clicking the "Show subscriptions" link should display a list of titles. - Edit or create a numbering pattern. - Confirm that the "Test pattern" button works correctly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16967 Aliki Pavlidou <pavlidoualiki@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pavlidoualiki@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16967 --- Comment #2 from Aliki Pavlidou <pavlidoualiki@gmail.com> --- Dear Owen, I've tested -> Manage frequencies: - Everything works just fine. When I've selected to "Delete" a frequency, there was this message: This frequency is still used by 2 subscription(s). Do you still want to delete it? The list of titles it was also there, after clicking the "Show subscriptions" link. - The form submission validation is still working correctly, as I've entered a non-numeric data (the word: two) in the "issues per unit" field and after submitting the form, I got back as a result this message: Some fields are not valid. Issues per unit is required (must be a number greater than 0). -> Manage numbering patterns: - Like before, I tried to "Delete" "Back up pattern1", and the following message appeared: This pattern is still used by 2 subscription(s). Do you still want to delete it? The list of titles it was also there, after clicking the "Show subscriptions" link. - Regarding creating a new numbering pattern, I was trying to create one yearly subscription that has 11 issues per year. Do you have any idea how could I set this pattern? For example 2015 was the 18th year of this journal publication, and July and August was merged into one issue. Kind regards Aliki -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16967 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53663|0 |1 is obsolete| | --- Comment #3 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Created attachment 55199 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55199&action=edit [SIGNED-OFF]Bug 16967: Remove the use of "onclick" from serial frequency and numbering management This patch removes instance of "onclick" from the templates for serial frequency and numbering management. Events are now defined in the JavaScript. To test, apply the patch and go to Serials -> Manage frequencies. - In the list of frequencies, click the "Delete" button for a frequency which is in use by at least one subscription. In the confirmation dialog, clicking the "Show subscriptions" link should display a list of titles. - Edit or create a frequency. - To test that the form submission validation is still working correctly, enter non-numeric data in the "issues per unit" field and submit the form. This should trigger an error. In Serials -> Manage numbering patterns: - In the list of numbering patterns, click the "Delete" button for a pattern which is in use by at least one subscription. In the confirmation dialog, clicking the "Show subscriptions" link should display a list of titles. - Edit or create a numbering pattern. - Confirm that the "Test pattern" button works correctly. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as advertised -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16967 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |hector.hecaxmmx@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16967 --- Comment #4 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- (In reply to Aliki Pavlidou from comment #2) Hi Aliki I will answer your question
- Regarding creating a new numbering pattern, I was trying to create one yearly subscription that has 11 issues per year. Do you have any idea how could I set this pattern? For example 2015 was the 18th year of this journal publication, and July and August was merged into one issue.
Name: 11 volums per year Description: 11 volums per year X Y Label Year No Add 1 1 Every 11 1 Setback 1 1 When.. 9999 11 Test prediction pattern Frequency: 1/month First issue publication date: 01/01/2015 Subscription length: issues 11 Beggins 2015 1 with Inner couter 1 1 You will get: Number Publication date Year 2015, No. 1 01/01/2015 Year 2015, No. 2 01/02/2015 Year 2015, No. 3 01/03/2015 Year 2015, No. 4 01/04/2015 Year 2015, No. 5 01/05/2015 Year 2015, No. 6 01/06/2015 Year 2015, No. 7 01/07/2015 Year 2015, No. 8 01/08/2015 Year 2015, No. 9 01/09/2015 Year 2015, No. 10 01/10/2015 Year 2016, No. 11 01/11/2015 If this does not always happen, i.e., just one year and the another year came with 12 issues You just delete the number not published when you add a new subscription in the "Prediction pattern" learn more about this here: <http://manual.koha-community.org/16.05/en/newsubscription.html> Maybe this isn't the best place to ask, please use the mailing list at <https://koha-community.org/support/koha-mailing-lists/> or the IRC <https://koha-community.org/get-involved/irc/> I hope this helps Regards -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16967 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16967 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55199|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 55511 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55511&action=edit Bug 16967: Remove the use of "onclick" from serial frequency and numbering management This patch removes instance of "onclick" from the templates for serial frequency and numbering management. Events are now defined in the JavaScript. To test, apply the patch and go to Serials -> Manage frequencies. - In the list of frequencies, click the "Delete" button for a frequency which is in use by at least one subscription. In the confirmation dialog, clicking the "Show subscriptions" link should display a list of titles. - Edit or create a frequency. - To test that the form submission validation is still working correctly, enter non-numeric data in the "issues per unit" field and submit the form. This should trigger an error. In Serials -> Manage numbering patterns: - In the list of numbering patterns, click the "Delete" button for a pattern which is in use by at least one subscription. In the confirmation dialog, clicking the "Show subscriptions" link should display a list of titles. - Edit or create a numbering pattern. - Confirm that the "Test pattern" button works correctly. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as advertised Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16967 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle@bywatersolutions.com --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 16.11, thanks Owen! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16967 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Component|Serials |Templates -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org