http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9926 --- Comment #1 from Mason James <mtj@kohaaloha.com> --- Created attachment 16879 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16879&action=edit Bug 9926 - Missing perl modules in Koha -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9926 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- This patch lacks a commit message and a test plan. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9926 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16879|0 |1 is obsolete| | --- Comment #3 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 16881 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16881&action=edit [SIGNED-OFF] Bug 9926 - Missing perl modules in Koha Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Coment: Owen is right, no commit message, no test plan. Please, don't forget. No errors. Test 1) before applying, koha_perl_deps.pl -a do not list File::Slurp as requirement 2) after applying patch, now it list File::Slurp as requirement. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9926 --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- (In reply to comment #3)

2) after applying patch, now it list File::Slurp as requirement.

My objection is to the lack of a description of the problem caused by the missing dependency and a way to test that the problem has gone away. Testing that the requirement shows up is only part of the process IMO. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9926 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16918|0 |1 is obsolete| | --- Comment #6 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 16920 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16920&action=edit [SIGNED-OFF] Bug 9926 - Missing perl modules in Koha to test… 1) check perl syntax on file $ perl -cw ./misc/migration_tools/koha-svc.pl you should *not* get 'syntax OK' returned from command 2) apply patch, and install File::Slurp module $ sudo cpanm File::Slurp 3) check perl syntax on file $ perl -cw ./misc/migration_tools/koha-svc.pl you should now get 'syntax OK' returned from command Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Without File:Slurp 1) complains of missing module, with module then sintax Ok. No errors. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9926 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16920|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 16983 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16983&action=edit Bug 9926 - Missing perl modules in Koha to test… 1) check perl syntax on file $ perl -cw ./misc/migration_tools/koha-svc.pl you should *not* get 'syntax OK' returned from command 2) apply patch, and install File::Slurp module $ sudo cpanm File::Slurp 3) check perl syntax on file $ perl -cw ./misc/migration_tools/koha-svc.pl you should now get 'syntax OK' returned from command Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Without File:Slurp 1) complains of missing module, with module then sintax Ok. No errors. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.