[Bug 29156] New: File missing warning in Koha::UploadedFile should be for permanent files only
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29156 Bug ID: 29156 Summary: File missing warning in Koha::UploadedFile should be for permanent files only Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Tools Assignee: koha-bugs@lists.koha-community.org Reporter: fridolin.somers@biblibre.com QA Contact: testopia@bugs.koha-community.org When an uploaded file is deleted, when file does not exist there is a warning : "Removing record for file.txt within category koha_upload, but file was missing." For temporary files, this warning is noisy. For example when they are in /tmp, system reboot deleted them. I propose to remove this warning for temporary files. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29156 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29156 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29156 --- Comment #1 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 125645 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125645&action=edit Bug 29156: File missing warning in Koha::UploadedFile for permanent files only When an uploaded file is deleted, when file does not exist there is a warning : "Removing record for file.txt within category koha_upload, but file was missing." For temporary files, this warning is noisy. For example when they are in /tmp, system reboot deleted them. I propose to remove this warning for temporary files. Test plan : 1) Upload a temporary and a permanent file via Tools > Upload 2) Delete the file on server 3) Delete the two files from Tools > Upload 4) Look at warning in log files => You see only warning for permanent file -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29156 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #2 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Please enter assignee, future RM :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29156 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |fridolin.somers@biblibre.co |ity.org |m --- Comment #3 from Fridolin Somers <fridolin.somers@biblibre.com> --- Oups, corrected :D -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29156 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29156 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125645|0 |1 is obsolete| | --- Comment #4 from David Nind <david@davidnind.com> --- Created attachment 128101 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128101&action=edit Bug 29156: File missing warning in Koha::UploadedFile for permanent files only When an uploaded file is deleted, when file does not exist there is a warning : "Removing record for file.txt within category koha_upload, but file was missing." For temporary files, this warning is noisy. For example when they are in /tmp, system reboot deleted them. I propose to remove this warning for temporary files. Test plan : 1) Upload a temporary and a permanent file via Tools > Upload 2) Delete the file on server 3) Delete the two files from Tools > Upload 4) Look at warning in log files => You see only warning for permanent file Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29156 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Text to go in the| |This removes the warning release notes| |from the log files when | |temporarily uploaded files | |are deleted and the file no | |longer exists (for example, | |when the temporary files | |are in /tmp directory and | |the system is rebooted they | |are deleted). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29156 --- Comment #5 from David Nind <david@davidnind.com> --- Testing notes using koha-testing-docker (KTD): - Location for temporary files in KTD is /var/lib/koha/kohadev/tmp/koha_kohadev_upload/ - Location for permanent files in KTD is /var/lib/koha/kohadev/uploads/ -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29156 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128101|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 129597 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129597&action=edit Bug 29156: File missing warning in Koha::UploadedFile for permanent files only When an uploaded file is deleted, when file does not exist there is a warning : "Removing record for file.txt within category koha_upload, but file was missing." For temporary files, this warning is noisy. For example when they are in /tmp, system reboot deleted them. I propose to remove this warning for temporary files. Test plan : 1) Upload a temporary and a permanent file via Tools > Upload 2) Delete the file on server 3) Delete the two files from Tools > Upload 4) Look at warning in log files => You see only warning for permanent file Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29156 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Signed Off |Passed QA --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Always good to reduce noise.. this makes sense. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29156 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29156 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29156 --- Comment #8 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29156 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.05.00 |22.05.00,21.11.03 released in| | Status|Pushed to master |Pushed to stable CC| |kyle@bywatersolutions.com --- Comment #9 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to 21.11.x for 21.11.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29156 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.05.00,21.11.03 |22.05.00,21.11.03,21.05.11 released in| | Status|Pushed to stable |Pushed to oldstable CC| |andrew@bywatersolutions.com --- Comment #10 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Pushed to 21.05.x for 21.05.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29156 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED CC| |victor@tuxayo.net Resolution|--- |FIXED --- Comment #11 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Not backported to oldoldstable (20.11.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org