[Bug 29054] New: Stop warns from advance_notices.pl if not running in verbose mode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29054 Bug ID: 29054 Summary: Stop warns from advance_notices.pl if not running in verbose mode Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs@lists.koha-community.org Reporter: hayleypelham@catalyst.net.nz QA Contact: testopia@bugs.koha-community.org CC: robin@catalyst.net.nz When the advance_notices.pl cronjob is run and the EnhancedMessagingPreferences syspref is set to don't allow, we get the following warning: The "EnhancedMessagingPreferences" syspref is off. Therefore, it is unlikely that this script will actually produce any messages to be sent. To change this, edit the "EnhancedMessagingPreferences" syspref. The advance_notices.pl script help says: -v Verbose. Without this flag set, only fatal errors are reported. However, the above warning is shown regardless of whether the script is run with the verbose flag. We need to add a verbosity check to this warn -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29054 Hayley Pelham <hayleypelham@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |hayleypelham@catalyst.net.n |ity.org |z Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29054 Hayley Pelham <hayleypelham@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29054 --- Comment #1 from Hayley Pelham <hayleypelham@catalyst.net.nz> --- Created attachment 125086 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125086&action=edit Bug 29054: Add verbose check for warn in advance_notices.pl To test: 1) Set EnhancedMessagingPreferences to Don't allow 2) In the koha-shell, run misc/cronjobs/advance_notices.pl -c 3) Note that you see the warning "The "EnhancedMessagingPreferences" syspref is off... etc." 4) Apply the patch and restart services 5) In the koha-shell, run misc/cronjobs/advance_notices.pl -c and note the warning no longer shows 6) Still in the shell, run misc/cronjobs/advance_notices.pl -c -v and note the warning does show Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29054 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #2 from Fridolin Somers <fridolin.somers@biblibre.com> --- I agree with that -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29054 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29054 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125086|0 |1 is obsolete| | --- Comment #3 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 127680 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127680&action=edit Bug 29054: Add verbose check for warn in advance_notices.pl To test: 1) Set EnhancedMessagingPreferences to Don't allow 2) In the koha-shell, run misc/cronjobs/advance_notices.pl -c 3) Note that you see the warning "The "EnhancedMessagingPreferences" syspref is off... etc." 4) Apply the patch and restart services 5) In the koha-shell, run misc/cronjobs/advance_notices.pl -c and note the warning no longer shows 6) Still in the shell, run misc/cronjobs/advance_notices.pl -c -v and note the warning does show Sponsored-by: Catalyst IT Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29054 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |m.de.rooy@rijksmuseum.nl --- Comment #4 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Hayley Pelham from comment #0)
When the advance_notices.pl cronjob is run and the EnhancedMessagingPreferences syspref is set to don't allow, we get the following warning:
The "EnhancedMessagingPreferences" syspref is off. Therefore, it is unlikely that this script will actually produce any messages to be sent. To change this, edit the "EnhancedMessagingPreferences" syspref.
The advance_notices.pl script help says:
-v Verbose. Without this flag set, only fatal errors are reported.
Not sure if we should remove a warn here or edit the above description? Removing fatal or replacing it by a less severe term? Needs feedback. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29054 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I agree with only giving this note with -v as at the moment if you have scheduled this on a server with multiple instances where the pref is turned off intentionally, it creates quite a bit of noise. It's not a fatal one I think, so would fit the description of -v, just referring to a configuration issue. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29054 Hayley Pelham <hayleypelham@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #6 from Hayley Pelham <hayleypelham@catalyst.net.nz> --- Setting back to Signed off after feedback from Katrin - thanks Katrin! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29054 --- Comment #7 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Katrin Fischer from comment #5)
I agree with only giving this note with -v as at the moment if you have scheduled this on a server with multiple instances where the pref is turned off intentionally, it creates quite a bit of noise.
It's not a fatal one I think, so would fit the description of -v, just referring to a configuration issue.
I dont oppose pushing it for the sake of multiple instances (where some instances would have enhanced messaging and others might not). But suppressing a warn that tells you that you are running a script that wouldnt do anything, is imo generally not what we should do. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29054 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29054 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127680|0 |1 is obsolete| | --- Comment #8 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 129242 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129242&action=edit Bug 29054: Add verbose check for warn in advance_notices.pl To test: 1) Set EnhancedMessagingPreferences to Don't allow 2) In the koha-shell, run misc/cronjobs/advance_notices.pl -c 3) Note that you see the warning "The "EnhancedMessagingPreferences" syspref is off... etc." 4) Apply the patch and restart services 5) In the koha-shell, run misc/cronjobs/advance_notices.pl -c and note the warning no longer shows 6) Still in the shell, run misc/cronjobs/advance_notices.pl -c -v and note the warning does show Sponsored-by: Catalyst IT Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29054 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29054 --- Comment #9 from Fridolin Somers <fridolin.somers@biblibre.com> --- (In reply to Marcel de Rooy from comment #7)
(In reply to Katrin Fischer from comment #5)
I agree with only giving this note with -v as at the moment if you have scheduled this on a server with multiple instances where the pref is turned off intentionally, it creates quite a bit of noise.
It's not a fatal one I think, so would fit the description of -v, just referring to a configuration issue.
I dont oppose pushing it for the sake of multiple instances (where some instances would have enhanced messaging and others might not). But suppressing a warn that tells you that you are running a script that wouldnt do anything, is imo generally not what we should do.
We have other examples of script. membership_expiry.pl and preference MembershipExpiryDaysNotice: https://git.koha-community.org/Koha-community/Koha/src/commit/e653effe5783e1... Using -v is a very common way to know what a script does ;) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29054 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29928 --- Comment #10 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created Bug 29928 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29054 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor --- Comment #11 from Fridolin Somers <fridolin.somers@biblibre.com> --- This isnt enhancement, I change to minor to encourage backport -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29054 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29054 --- Comment #12 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29054 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.05.00 |22.05.00,21.11.03 released in| | Status|Pushed to master |Pushed to stable CC| |kyle@bywatersolutions.com --- Comment #13 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to 21.11.x for 21.11.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29054 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.05.00,21.11.03 |22.05.00,21.11.03,21.05.11 released in| | Status|Pushed to stable |Pushed to oldstable CC| |andrew@bywatersolutions.com --- Comment #14 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Pushed to 21.05.x for 21.05.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29054 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net Resolution|--- |FIXED Status|Pushed to oldstable |RESOLVED --- Comment #15 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Not backported to oldoldstable (20.11.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org