https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23957 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23957 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Owen Leonard from comment #0)

This should be done for the inputs as well.

Why not on the same patch? $ yarn build Message: koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss Error: Invalid CSS after "...hadow: 0 -1px 0": expected expression (e.g. 1px, bold), was "#00000059;" on line 1794 of koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss

...

text-shadow: 0 -1px 0 #00000059;

----------------------------------^

The hex code color is not valid. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23957 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94989|0 |1 is obsolete| | --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 95027 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95027&action=edit Bug 23957: Remove button style with famfamfam icon background and replace with Font Awesome The patch modifies the markup and CSS related to the holds template in the staff client when holds policy override is necessary. The CSS background image is replaced with a Font Awesome icon. <input>s are replaced with <button>s to allow for the icon markup. To test, apply the patch and regenerate the staff client CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). - Enable the AllowHoldPolicyOverride system preference. - Start the process of placing a hold for a patron on a title which would not normally be available for hold. For instance: The patron already has too many holds. - On the hold confirmation screen the "Place hold" buttons should appear with a little yellow "warning" icon. - Clicking either of the two "Place hold" buttons should trigger a confirmation dialog. Test both the "Confirm" and "Cancel" options. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23957 Maryse Simard <maryse.simard@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95027|0 |1 is obsolete| | --- Comment #5 from Maryse Simard <maryse.simard@inlibro.com> --- Created attachment 95244 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95244&action=edit Bug 23957: Remove button style with famfamfam icon background and replace with Font Awesome The patch modifies the markup and CSS related to the holds template in the staff client when holds policy override is necessary. The CSS background image is replaced with a Font Awesome icon. <input>s are replaced with <button>s to allow for the icon markup. To test, apply the patch and regenerate the staff client CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). - Enable the AllowHoldPolicyOverride system preference. - Start the process of placing a hold for a patron on a title which would not normally be available for hold. For instance: The patron already has too many holds. - On the hold confirmation screen the "Place hold" buttons should appear with a little yellow "warning" icon. - Clicking either of the two "Place hold" buttons should trigger a confirmation dialog. Test both the "Confirm" and "Cancel" options. Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23957 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Status|Signed Off |Failed QA --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Owen, I have some difficulties with this bug. The second "Place hold" button on the end of the page does no longer 'lock' when it should. Example: - override is not active - try to place a hold on a record with only 'not for loan' itemtypes - the first 'place hold' button is locked, but the second after the item table is not. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23957 --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 96156 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96156&action=edit Bug 23957: (follow-up) Disable both place hold buttons This follow-up adds the correct markup to the second of two "Place hold" buttons so that it is disabled when the first is disabled. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23957 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95244|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 96578 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96578&action=edit Bug 23957: Remove button style with famfamfam icon background and replace with Font Awesome The patch modifies the markup and CSS related to the holds template in the staff client when holds policy override is necessary. The CSS background image is replaced with a Font Awesome icon. <input>s are replaced with <button>s to allow for the icon markup. To test, apply the patch and regenerate the staff client CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). - Enable the AllowHoldPolicyOverride system preference. - Start the process of placing a hold for a patron on a title which would not normally be available for hold. For instance: The patron already has too many holds. - On the hold confirmation screen the "Place hold" buttons should appear with a little yellow "warning" icon. - Clicking either of the two "Place hold" buttons should trigger a confirmation dialog. Test both the "Confirm" and "Cancel" options. Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23957 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23957 --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23957 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #12 from Lucas Gass <lucas@bywatersolutions.com> --- there is many merge conflicts when applying this to 19.05.x, I am going to skip backporting it. -- You are receiving this mail because: You are watching all bug changes.