[Bug 23261] New: RecordedBooks - notify patron of need to login / register to see availability
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23261 Bug ID: 23261 Summary: RecordedBooks - notify patron of need to login / register to see availability Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23261 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23261 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 91233 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91233&action=edit Bug 23261: Add notice for login/registering to RBdigital results To test: 1 - You will need a valid library RBDigital account 2 - Fill in the RecordedBooks system preferences 3 - Open the catalog, perform a search with RBDigtal resuls, 'love' often works 4 - Click to the results 5 - Note if not logged you don't see availability 6 - Log in with a patron with no email, note you do not see any notice that you must register your email with RBDigital 7 - Apply patch 8 - Reload results, you now see a notice to register with rbdigital, do so unless you already have an account 9 - Add your associated email to the koha account 10 - Reload results, note you see availability 11 - Log out, reload results 12 - Note you see a promp to login to see availability -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23261 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23261 Jessie Zairo <jzairo@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jzairo@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23261 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91233|0 |1 is obsolete| | --- Comment #2 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 94773 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94773&action=edit Bug 23261: Add notice for login/registering to RBdigital results To test: 1 - You will need a valid library RBDigital account 2 - Fill in the RecordedBooks system preferences 3 - Open the catalog, perform a search with RBDigtal resuls, 'love' often works 4 - Click to the results 5 - Note if not logged you don't see availability 6 - Log in with a patron with no email, note you do not see any notice that you must register your email with RBDigital 7 - Apply patch 8 - Reload results, you now see a notice to register with rbdigital, do so unless you already have an account 9 - Add your associated email to the koha account 10 - Reload results, note you see availability 11 - Log out, reload results 12 - Note you see a promp to login to see availability Signed-off-by: Jessica Zairo <jzairo@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23261 Jessie Zairo <jzairo@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #3 from Jessie Zairo <jzairo@bywatersolutions.com> --- Works as described. Screencast available at: https://drive.google.com/file/d/14y5GfGtpt4IUClkKmlnhkFPaSCfyMr2s/view -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23261 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23261 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94773|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 96038 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96038&action=edit Bug 23261: Add notice for login/registering to RBdigital results To test: 1 - You will need a valid library RBDigital account 2 - Fill in the RecordedBooks system preferences 3 - Open the catalog, perform a search with RBDigtal resuls, 'love' often works 4 - Click to the results 5 - Note if not logged you don't see availability 6 - Log in with a patron with no email, note you do not see any notice that you must register your email with RBDigital 7 - Apply patch 8 - Reload results, you now see a notice to register with rbdigital, do so unless you already have an account 9 - Add your associated email to the koha account 10 - Reload results, note you see availability 11 - Log out, reload results 12 - Note you see a promp to login to see availability Signed-off-by: Jessica Zairo <jzairo@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23261 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Note: I did not test this patch, trusting author and tester. Nick, it is better to use "logged_in_user" instead of other loggedin* variables, which should be remove in the future. Not blocker however, and did not want to amend a patch I am not able to test. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23261 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96038|0 |1 is obsolete| | --- Comment #6 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 96356 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96356&action=edit Bug 23261: Add notice for login/registering to RBdigital results To test: 1 - You will need a valid library RBDigital account 2 - Fill in the RecordedBooks system preferences 3 - Open the catalog, perform a search with RBDigtal resuls, 'love' often works 4 - Click to the results 5 - Note if not logged you don't see availability 6 - Log in with a patron with no email, note you do not see any notice that you must register your email with RBDigital 7 - Apply patch 8 - Reload results, you now see a notice to register with rbdigital, do so unless you already have an account 9 - Add your associated email to the koha account 10 - Reload results, note you see availability 11 - Log out, reload results 12 - Note you see a promp to login to see availability Signed-off-by: Jessica Zairo <jzairo@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23261 --- Comment #7 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 96357 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96357&action=edit Bug 23261: (follow-up) Use logged_in_user and move test -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23261 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |The enhancement makes the release notes| |RBDigital Recorded Books | |subscription more | |discoverable to library | |patrons by adding a notice | |to the OPAC for patrons to | |register and login with | |RBDigital if they have not | |already done so. CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23261 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|The enhancement makes the |This enhancement makes the release notes|RBDigital Recorded Books |RBDigital Recorded Books |subscription more |subscription more |discoverable to library |discoverable to library |patrons by adding a notice |patrons by adding a notice |to the OPAC for patrons to |to the OPAC for patrons to |register and login with |register and login with |RBDigital if they have not |RBDigital if they have not |already done so. |already done so. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23261 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23261 --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23261 --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23261 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.05.00 |20.05.00, 19.11.02 released in| | Status|Pushed to master |Pushed to stable CC| |joy@bywatersolutions.com --- Comment #10 from Joy Nelson <joy@bywatersolutions.com> --- Pushed to 19.11.x branch for 19.11.02 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23261 --- Comment #11 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Joy Nelson from comment #10)
Pushed to 19.11.x branch for 19.11.02
Hi Joy, there was a RM follow-up that was not attach to this bug report: commit 42d40e372e25cc4790290dcd0bb31c50f237f5fe Bug 23261: (RM follow-up) Add missing uri filter It will fix the failure for xt/find-missing-filters.t on 19.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23261 --- Comment #12 from Joy Nelson <joy@bywatersolutions.com> --- Thanks Jonathan. Last commit pushed to 19.11.x branch for 19.11.02 (In reply to Jonathan Druart from comment #11)
(In reply to Joy Nelson from comment #10)
Pushed to 19.11.x branch for 19.11.02
Hi Joy, there was a RM follow-up that was not attach to this bug report: commit 42d40e372e25cc4790290dcd0bb31c50f237f5fe Bug 23261: (RM follow-up) Add missing uri filter It will fix the failure for xt/find-missing-filters.t on 19.11
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23261 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #13 from Lucas Gass <lucas@bywatersolutions.com> --- enhancement will not be backported to 19.05.x series -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org