[Bug 12535] New: PROG/CCSR Deprecation: Make opac translation theme independent
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12535 Bug ID: 12535 Summary: PROG/CCSR Deprecation: Make opac translation theme independent Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs@lists.koha-community.org Reporter: bgkriegel@gmail.com QA Contact: testopia@bugs.koha-community.org CC: frederic@tamil.fr Translation scripts have 'prog' hardcoded for OPAC -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12535 --- Comment #1 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 29534 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29534&action=edit Bug 12535 - PROG/CCSR Deprecation: Make opac translation theme independent This patch makes opac translation files theme independent A side effect is that current prog translation file is renamed. But the renaming is not added, that gives a patch of ~60M! Current list of languages are now obtained from pref files. To test: 1) Apply the patch 2) For your preferred language, rename opac prog file from 'xx-YY-i-opac-t-prog-v-3006000.po' to 'xx-YY-opac-prog.po' 3) Update that language, there must be no errors cd misc/translation ./translate update xx-YY [-v] Check updated po files 4) Install any language, there must be no errors ./translate install xx-YY Check prog theme for that language 5) Create translation files. Remove a language or create new lang files ./translate create zz-WW ls -l po/zz-WW*po check there are 3 files (and *~) for opac 6) Check updated pod for LangInstaler.pm and translate script When PROG/CCSR themes are removed, I'll add a Bug to remove corresponding files. Perhaps RM could add a followup to rename all files, cd misc/translator/po for old in $(ls *opac-t*); do new=$(echo $old | sed 's/-i-opac-t-prog-v-3006000/-opac-prog/'); git mv $old $new; done -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12535 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs@lists.koha-commun |bgkriegel@gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12535 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Blocks| |11346 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12535 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29534|0 |1 is obsolete| | --- Comment #2 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 30084 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30084&action=edit Bug 12535 - PROG/CCSR Deprecation: Make opac translation theme independent This patch makes opac translation files theme independent A side effect is that current prog translation file is renamed. But the renaming is not added, that gives a patch of ~60M! Current list of languages are now obtained from pref files. To test: 1) Apply the patch 2) For your preferred language, rename opac prog file from 'xx-YY-i-opac-t-prog-v-3006000.po' to 'xx-YY-opac-prog.po' 3) Update that language, there must be no errors cd misc/translation ./translate update xx-YY [-v] Check updated po files 4) Install any language, there must be no errors ./translate install xx-YY Check prog theme for that language 5) Create translation files. Remove a language or create new lang files ./translate create zz-WW ls -l po/zz-WW*po check there are 3 files (and *~) for opac 6) Check updated pod for LangInstaler.pm and translate script When PROG/CCSR themes are removed, I'll add a Bug to remove corresponding files. Perhaps RM could add a followup to rename all files, cd misc/translator/po for old in $(ls *opac-t*); do new=$(echo $old | sed 's/-i-opac-t-prog-v-3006000/-opac-prog/'); git mv $old $new; done Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12535 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12535 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12535 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30084|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 30517 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30517&action=edit [PASSED QA] Bug 12535 - PROG/CCSR Deprecation: Make opac translation theme independent This patch makes opac translation files theme independent A side effect is that current prog translation file is renamed. But the renaming is not added, that gives a patch of ~60M! Current list of languages are now obtained from pref files. To test: 1) Apply the patch 2) For your preferred language, rename opac prog file from 'xx-YY-i-opac-t-prog-v-3006000.po' to 'xx-YY-opac-prog.po' 3) Update that language, there must be no errors cd misc/translation ./translate update xx-YY [-v] Check updated po files 4) Install any language, there must be no errors ./translate install xx-YY Check prog theme for that language 5) Create translation files. Remove a language or create new lang files ./translate create zz-WW ls -l po/zz-WW*po check there are 3 files (and *~) for opac 6) Check updated pod for LangInstaler.pm and translate script When PROG/CCSR themes are removed, I'll add a Bug to remove corresponding files. Perhaps RM could add a followup to rename all files, cd misc/translator/po for old in $(ls *opac-t*); do new=$(echo $old | sed 's/-i-opac-t-prog-v-3006000/-opac-prog/'); git mv $old $new; done Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works as described, no problems found. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12535 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed by Module Maintainer CC| |chris@bigballofwax.co.nz --- Comment #4 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to MM-OPAC/theme_dep -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12535 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed by Module Maintainer |Pushed to Master --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch merged into master. Thanks Bernardo! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12535 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org