[Bug 42850] New: ILL requests stylesheet is not installed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42850 Bug ID: 42850 Summary: ILL requests stylesheet is not installed Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Installation and upgrade (command-line installer) Assignee: koha-bugs@lists.koha-community.org Reporter: nugged@gmail.com QA Contact: testopia@bugs.koha-community.org CC: tomascohen@gmail.com Target Milestone: --- The ILL requests page includes css/ill-requests.css. This stylesheet is generated from koha-tmpl/intranet-tmpl/prog/css/src/ill-requests.scss and ignored by git. On a package/source install, the generated file is not copied into blib because Makefile.PL does not list it in the generated asset map. Asset.css cannot resolve it, warns "File not found : css/ill-requests.css", and returns no link tag. Steps to reproduce: 1. Use a clean package or source-style install built from current main. 2. Open /cgi-bin/koha/ill/ill-requests.pl in the staff interface. 3. Inspect the page source/head and the intranet log. Expected result: The page includes a link tag for css/ill-requests.css and the intranet log has no missing-asset warning for that file. Actual result: No css/ill-requests.css link tag is emitted and the intranet log warns: File not found : css/ill-requests.css. Technical note: This follows the generated asset install mapping pattern from bug 32609 and bug 38779. Bug 30200 added the generated stylesheet and template include, but the generated CSS was not added to Makefile.PL. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42850 Andrii Nugged <nugged@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=30200, | |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=32609, | |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=38779 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42850 Andrii Nugged <nugged@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |nugged@gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42850 --- Comment #1 from Andrii Nugged <nugged@gmail.com> --- Created attachment 200492 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200492&action=edit Bug 42850: Install generated ILL requests CSS The ILL requests page loads css/ill-requests.css from the staff template. The stylesheet is generated by build-resources.PL and ignored by git, but Makefile.PL does not list it in the generated asset map. As a result package installs do not copy the generated stylesheet into blib, so Asset.css cannot find it and no link tag is emitted. Add ill-requests.css to the generated staff CSS file map so it is installed with the other generated staff stylesheets. Test plan: 1. perl -c Makefile.PL 2. prove -v t/Makefile.t 3. Confirm that /cgi-bin/koha/ill/ill-requests.pl includes a link tag for css/ill-requests.css on a package/source-style install. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42850 Andrii Nugged <nugged@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42850 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |dcook@prosentient.com.au |y.org | CC| |dcook@prosentient.com.au --- Comment #2 from David Cook <dcook@prosentient.com.au> --- Looking good overall, although it looks like ill-requests-rtl.css is also needed. I can add a patch for that quick. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42850 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #200492|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42850 --- Comment #3 from David Cook <dcook@prosentient.com.au> --- Created attachment 200493 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200493&action=edit Bug 42850: Install generated ILL requests CSS The ILL requests page loads css/ill-requests.css from the staff template. The stylesheet is generated by build-resources.PL and ignored by git, but Makefile.PL does not list it in the generated asset map. As a result package installs do not copy the generated stylesheet into blib, so Asset.css cannot find it and no link tag is emitted. Add ill-requests.css to the generated staff CSS file map so it is installed with the other generated staff stylesheets. Test plan: 1. perl -c Makefile.PL 2. prove -v t/Makefile.t 3. Confirm that /cgi-bin/koha/ill/ill-requests.pl includes a link tag for css/ill-requests.css on a package/source-style install. Signed-off-by: David Cook <dcook@prosentient.com.au> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42850 --- Comment #4 from David Cook <dcook@prosentient.com.au> --- Created attachment 200494 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200494&action=edit Bug 42850: Add ill-requests-rtl.css to Makefile Signed-off-by: David Cook <dcook@prosentient.com.au> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42850 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |30200 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30200 [Bug 30200] Add customizable tabs to interlibrary loan requests list -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42850 --- Comment #5 from David Cook <dcook@prosentient.com.au> --- Once someone signs this off, I'd be happy to mark it Passed QA. Good catch, Andrii! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42850 --- Comment #6 from David Cook <dcook@prosentient.com.au> --- The test plan I used: 0a. Apply patch 0b. perl Makefile.PL (and choose "single" install to /opt/koha") 1. make 2. Observe the following two files exist: blib/INTRANET_TMPL_DIR/prog/css/ill-requests.css blib/INTRANET_TMPL_DIR/prog/css/ill-requests-rtl.css 3. make install 4. Observe the following two files exist: /opt/koha/intranet/htdocs/intranet-tmpl/prog/css/ill-requests.css /opt/koha/intranet/htdocs/intranet-tmpl/prog/css/ill-requests-rtl.css -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42850 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42850 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #200493|0 |1 is obsolete| | Attachment #200494|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42850 --- Comment #7 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 200666 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200666&action=edit Bug 42850: Install generated ILL requests CSS The ILL requests page loads css/ill-requests.css from the staff template. The stylesheet is generated by build-resources.PL and ignored by git, but Makefile.PL does not list it in the generated asset map. As a result package installs do not copy the generated stylesheet into blib, so Asset.css cannot find it and no link tag is emitted. Add ill-requests.css to the generated staff CSS file map so it is installed with the other generated staff stylesheets. Test plan: 1. perl -c Makefile.PL 2. prove -v t/Makefile.t 3. Confirm that /cgi-bin/koha/ill/ill-requests.pl includes a link tag for css/ill-requests.css on a package/source-style install. Signed-off-by: David Cook <dcook@prosentient.com.au> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42850 --- Comment #8 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 200667 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200667&action=edit Bug 42850: Add ill-requests-rtl.css to Makefile Signed-off-by: David Cook <dcook@prosentient.com.au> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42850 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@gmail.com --- Comment #9 from Jonathan Druart <jonathan.druart@gmail.com> --- I've started to write an xt test to catch such problems, but it's actually less trivial than expected. I might open a follow-up bug report later. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42850 --- Comment #10 from Jonathan Druart <jonathan.druart@gmail.com> --- I think there are more to add. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42850 --- Comment #11 from Jonathan Druart <jonathan.druart@gmail.com> --- koha-tmpl/intranet-tmpl/prog/css/bookings.css -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42850 --- Comment #12 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 200668 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200668&action=edit Bug 42850: Add xt test to prevent future omission of css files in Makefile Note that t/Makefile.t and xt/check_makefile.t were doing the same test. Merging them. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42850 --- Comment #13 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 200669 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200669&action=edit Bug 42850: Add bookings.css and edifact_interchange.css Patch from commit 615c697 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42850 --- Comment #14 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 200670 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200670&action=edit But 42850: Add missing rtl Patch from commit a678432 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42850 --- Comment #15 from Jonathan Druart <jonathan.druart@gmail.com> --- Sorry, end of the day here. I think I've been too far, but it seems that there are way more missing the just the ill files. Feel free to drop the follow-ups if they don't make sense. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42850 --- Comment #16 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 200671 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200671&action=edit Bug 42850: Add missing rtl Patch from commit a83c62c -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42850 --- Comment #17 from David Cook <dcook@prosentient.com.au> --- I think we probably could've kept this one to ill-requests.*css. Are these ready to go? I'm guessing so since they're marked Signed Off? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42850 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |42886 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42886 [Bug 42886] CSS files not installed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42850 --- Comment #18 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to David Cook from comment #17)
I think we probably could've kept this one to ill-requests.*css.
Split, see bug 42886. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42850 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #200671|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42850 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #200670|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42850 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #200669|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42850 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #200668|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42850 --- Comment #19 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 201839 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201839&action=edit Bug 42850: Install generated ILL requests CSS The ILL requests page loads css/ill-requests.css from the staff template. The stylesheet is generated by build-resources.PL and ignored by git, but Makefile.PL does not list it in the generated asset map. As a result package installs do not copy the generated stylesheet into blib, so Asset.css cannot find it and no link tag is emitted. Add ill-requests.css to the generated staff CSS file map so it is installed with the other generated staff stylesheets. Test plan: 1. perl -c Makefile.PL 2. prove -v t/Makefile.t 3. Confirm that /cgi-bin/koha/ill/ill-requests.pl includes a link tag for css/ill-requests.css on a package/source-style install. Signed-off-by: David Cook <dcook@prosentient.com.au> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42850 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #200666|0 |1 is obsolete| | Attachment #200667|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42850 --- Comment #20 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 201840 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201840&action=edit Bug 42850: Add ill-requests-rtl.css to Makefile Signed-off-by: David Cook <dcook@prosentient.com.au> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42850 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org