[Bug 33129] New: Use template wrapper for breadcrumbs: Administration part 6
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33129 Bug ID: 33129 Summary: Use template wrapper for breadcrumbs: Administration part 6 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: testopia@bugs.koha-community.org Depends on: 32507 To continue the process started by Bug 32507, this patch will update several more templates in administration so that they use the new template wrapper for breadcrumbs. - admin/share_content.tt - admin/smart-rules.tt - admin/sms_providers.tt - admin/smtp_servers.tt - admin/systempreferences.tt - admin/transfer_limits.tt - admin/transport-cost-matrix.tt - admin/usage_statistics.tt - admin/z3950servers.tt - admin/searchengine/elasticsearch/mappings.tt Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32507 [Bug 32507] Use template wrapper to build breadcrumb navigation -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33129 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33129 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 147719 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147719&action=edit Bug 33129: Use template wrapper for breadcrumbs: Administration part 6 This patch updates several administration templates so that they use the new WRAPPER for displaying breadcrumbs. To test, apply the patch and test each page and its variations. Breadcrumbs should look correct, and each link should be correct. Administration -> - Search engine configuration (Elasticsearch) - Share content with Mana KB - Circulation and fine rules - SMS cellular providers (SMSSendDriver preference must be set) - System preferences -> Local use (list, add, edit, confirm delete) - Library transfer limits (Advanced editor) - Transport cost matrix - Usage statistics - Z39.50/SRU servers administration (list, add, edit, both Z39.50 and SRU servers) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33129 Bug 33129 depends on bug 32507, which changed state. Bug 32507 Summary: Use template wrapper to build breadcrumb navigation https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32507 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33129 Andrew Auld <andrew.auld@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew.auld@ptfs-europe.com --- Comment #2 from Andrew Auld <andrew.auld@ptfs-europe.com> --- In testing this, everything works as it should. However, for the SMS cellular providers, when I click 'New SMS Provider' the breadcrumb doesn't add another crumb 'New SMS Provider'. This means that I can't easily use the breadcrumb to go back to the SMS Provider list page. Similarly, when I edit an SMS Provider that I have added, the breadcrumb also doesn't add another crumb eg 'Modify SMS Provider <SMS Provider name>'. Again, this makes it difficult to exit the edit page back to the list page using the breadcrumb links. I am not sure whether this should be fixed as part of this bug or added as a new bug. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33129 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Andrew Auld from comment #2)
However, for the SMS cellular providers, when I click 'New SMS Provider' the breadcrumb doesn't add another crumb 'New SMS Provider'
Since the behavior you describe is in master as well I would prefer that this be addressed in another bug. Currently we don't have an established method of updating elements like breadcrumbs and page titles when the content of the page changes without a page reload -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33129 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147719|0 |1 is obsolete| | --- Comment #4 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 148920 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148920&action=edit Bug 33129: Use template wrapper for breadcrumbs: Administration part 6 This patch updates several administration templates so that they use the new WRAPPER for displaying breadcrumbs. To test, apply the patch and test each page and its variations. Breadcrumbs should look correct, and each link should be correct. Administration -> - Search engine configuration (Elasticsearch) - Share content with Mana KB - Circulation and fine rules - SMS cellular providers (SMSSendDriver preference must be set) - System preferences -> Local use (list, add, edit, confirm delete) - Library transfer limits (Advanced editor) - Transport cost matrix - Usage statistics - Z39.50/SRU servers administration (list, add, edit, both Z39.50 and SRU servers) Signed-off-by: Andrew Auld <andrew.auld@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33129 Andrew Auld <andrew.auld@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33129 --- Comment #5 from Andrew Auld <andrew.auld@ptfs-europe.com> --- OK I have signed this off and reached out to Martin to help me create a bug relating to the SMS breadcrumb thing. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33129 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33129 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33129 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148920|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 149330 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149330&action=edit Bug 33129: Use template wrapper for breadcrumbs: Administration part 6 This patch updates several administration templates so that they use the new WRAPPER for displaying breadcrumbs. To test, apply the patch and test each page and its variations. Breadcrumbs should look correct, and each link should be correct. Administration -> - Search engine configuration (Elasticsearch) - Share content with Mana KB - Circulation and fine rules - SMS cellular providers (SMSSendDriver preference must be set) - System preferences -> Local use (list, add, edit, confirm delete) - Library transfer limits (Advanced editor) - Transport cost matrix - Usage statistics - Z39.50/SRU servers administration (list, add, edit, both Z39.50 and SRU servers) Signed-off-by: Andrew Auld <andrew.auld@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33129 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33129 --- Comment #7 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33129 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.05 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33129 --- Comment #8 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33129 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org