[Bug 27196] New: Waiting title level hold checked in at wrong location via SIP leaves hold in a broken state and drops connection
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27196 Bug ID: 27196 Summary: Waiting title level hold checked in at wrong location via SIP leaves hold in a broken state and drops connection Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: SIP2 Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: colin.campbell@ptfs-europe.com The problem occurs when we find a hold during SIP checkin - we check the message form AddReturn for the hold value - but for a waiting hold at wrong location the hold has been reverted and, in the case of a title level hold, has no itemnumber We partially succeed in setting the hold to transit and leave the hold in limbo This is due to passing $messages->{ResFound}->{itemnumber} to ModReserveAffect rather than $item->itemnumber which we have available To recreate: 1 - Place a next available hold for delivery at library A 2 - Check the item in at library A to set it waiting 3 - Check the item in via SIP at library B perl misc/sip_cli_emulator.pl -a localhost -p 6001 -su term1 -sp term1 --item BARCODE -l FPL -m checkin 4 - The SIP emulator dies: Use of uninitialized value $data in concatenation (.) or string at misc/sip_cli_emulator.pl line 344, <GEN0> chunk 1. READ: 5 - Check the hold in the db: SELECT * FROM reserves WHERE itemnumber IS NULL and found IS NOT NULL; 5 - Try to load the biblio - ISE Can't call method holdingbranch on an undefined object -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27196 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=21020, | |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27166 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27196 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Internal server error mentioned is: Can't call method "holdingbranch" on an undefined value at /kohadevbox/koha/reserve/request.pl line 654 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27196 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- What's the expected behaviour? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27196 --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 114387 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114387&action=edit Bug 27196: Don't explode if item that is waiting if checked in by SIP -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27196 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Can you detail what's the expected behaviour, Nick? I am not sure this fix is correct (ie. do we want to start the transfer on a SIP operation?) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27196 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27196 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27196 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114387|0 |1 is obsolete| | --- Comment #5 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 114392 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114392&action=edit Bug 27196: Don't explode if item that is waiting if checked in by SIP Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27196 --- Comment #6 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #4)
Can you detail what's the expected behaviour, Nick? I am not sure this fix is correct (ie. do we want to start the transfer on a SIP operation?)
I believe this is the expected behaviour, it should mimic what happens when a hold is found in general via sip - all you have done is prevent an error, not changed behaviour -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27196 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jonathan.druart@bugs.koha-c |ity.org |ommunity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27196 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114392|0 |1 is obsolete| | --- Comment #7 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 114622 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114622&action=edit Bug 27196: Don't explode if item that is waiting if checked in by SIP Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27196 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net --- Comment #8 from Victor Grousset/tuxayo <victor@tuxayo.net> --- As a step towards QA, here is another signoff :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27196 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #9 from David Cook <dcook@prosentient.com.au> --- My test plan: 0. koha-sip --restart kohadev 1. Go to http://localhost:8081/cgi-bin/koha/reserve/request.pl?borrowernumber=51&biblionumber=29 2. Click "Place hold" 3. koha-shell kohadev 4. perl misc/sip_cli_emulator.pl -a localhost -p 6001 -su term1 -sp term1 --item 39999000001310 -l FPL -m checkin 5. Note that SIP emulator does not die and you get the following output: Attempting socket connection to localhost:6001...connected! SEND: 9300CNterm1|COterm1|CPFPL| READ: 941 Trying 'checkin' SEND: 09N20201223 23152620201223 231526APFPL|AOFPL|AB39999000001310|ACterm1|BIN| READ: 101YNY20201223 231526AOFPL|AB39999000001310|AQCPL|AJGairm.|CY42|CTCPL|DAkoha|CRREF|CV02| 6. Go to http://localhost:8081/cgi-bin/koha/members/moremember.pl?borrowernumber=51 7. Note that the hold displays normally as in transit from Fairview 8. Go to http://localhost:8081/cgi-bin/koha/reserve/request.pl?biblionumbers=29/ 9. Note that the hold displays normally as being transferred to Centerville -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27196 --- Comment #10 from David Cook <dcook@prosentient.com.au> --- prove t/db_dependent/SIP/Transaction.t t/db_dependent/SIP/Transaction.t .. ok All tests successful. Files=1, Tests=11, 5 wallclock secs ( 0.04 usr 0.00 sys + 3.66 cusr 0.40 csys = 4.10 CPU) Result: PASS -- qa -c 2 -v 2 testing 2 commit(s) (applied to 470c760 '69 Bug 26941: Fix OPAC password recov') Processing files before patches |========================>| 2 / 2 (100.00%) Processing files after patches |========================>| 2 / 2 (100.00%) OK C4/SIP/ILS/Transaction/Checkin.pm OK t/db_dependent/SIP/Transaction.t Processing additional checks OK! -- Code review looks good to me. Sensible change. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27196 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27196 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114622|0 |1 is obsolete| | --- Comment #11 from David Cook <dcook@prosentient.com.au> --- Created attachment 114693 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114693&action=edit Bug 27196: Don't explode if item that is waiting if checked in by SIP Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: David Cook <dcook@prosentient.com.au> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27196 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |dcook@prosentient.com.au |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27196 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27196 --- Comment #12 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27196 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #13 from Fridolin Somers <fridolin.somers@biblibre.com> --- Patch removes a # in C4/SIP/ILS/Transaction/Checkin.pm : https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114693&action=diff#a/C4/SIP/ILS/Transaction/Checkin.pm_sec1 Is this on purpose ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27196 --- Comment #14 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Fridolin Somers from comment #13)
Patch removes a # in C4/SIP/ILS/Transaction/Checkin.pm :
https://bugs.koha-community.org/bugzilla3/attachment. cgi?id=114693&action=diff#a/C4/SIP/ILS/Transaction/Checkin.pm_sec1
Is this on purpose ?
It was not, but shouldn't hurt anything -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27196 --- Comment #15 from Fridolin Somers <fridolin.somers@biblibre.com> --- (In reply to Nick Clemens from comment #14)
(In reply to Fridolin Somers from comment #13)
Patch removes a # in C4/SIP/ILS/Transaction/Checkin.pm :
https://bugs.koha-community.org/bugzilla3/attachment. cgi?id=114693&action=diff#a/C4/SIP/ILS/Transaction/Checkin.pm_sec1
Is this on purpose ?
It was not, but shouldn't hurt anything
OK no pb. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27196 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.05.00 |21.05.00,20.11.01 released in| | Status|Pushed to master |Pushed to stable --- Comment #16 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 20.11.x for 20.11.01 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27196 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com --- Comment #17 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Gives some errors on 20.05, please rebase. qa -c 1 -v 2 testing 1 commit(s) (applied to 4d16cdd '7c Bug 27256: Update click handler fo') Processing files before patches |========================>| 2 / 2 (100.00%) Processing files after patches |========================>| 2 / 2 (100.00%) FAIL C4/SIP/ILS/Transaction/Checkin.pm FAIL valid Global symbol "$item" requires explicit package name (did you forget to declare "my $item"?) Global symbol "$item" requires explicit package name (did you forget to declare "my $item"?) C4/SIP/ILS/Transaction/Checkin.pm had compilation errors. FAIL t/db_dependent/SIP/Transaction.t FAIL valid Global symbol "$item" requires explicit package name (did you forget to declare "my $item"?) Global symbol "$item" requires explicit package name (did you forget to declare "my $item"?) Compilation failed in require Compilation failed in require BEGIN failed--compilation aborted -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27196 --- Comment #18 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 115711 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115711&action=edit Bug 27196:[20.05.x] Don't explode if item that is waiting if checked in by SIP Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: David Cook <dcook@prosentient.com.au> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27196 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.05.00,20.11.01 |21.05.00,20.11.01,20.05.08 released in| | Status|Pushed to stable |Pushed to oldstable --- Comment #19 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Pushed to 20.05.x for 20.05.08 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27196 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to oldstable |RESOLVED --- Comment #20 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Can't backport to 19.11.x, a test is failing, help needed if this patch is wanted in 19.11.x # Failed test 'No tests run for subtest "Checkin an in transit item"' # at t/db_dependent/SIP/Transaction.t line 338. # Looks like you failed 1 test of 12. t/db_dependent/SIP/Transaction.t .. 8/10 # Failed test 'do_checkin' # at t/db_dependent/SIP/Transaction.t line 339. DBIx::Class::Row::store_column(): No such column 'biblionumber' on Koha::Schema::Result::Branch at /kohadevbox/koha/Koha/Object.pm line 77 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27196 --- Comment #21 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 115757 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115757&action=edit Bug 27196:[19.11.x] Don't explode if item that is waiting if checked in by SIP AddReserve doesn't take a hash in 19.11 - amended the call in the tests Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: David Cook <dcook@prosentient.com.au> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27196 --- Comment #22 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Thanks Nick :D Backported: Pushed to 19.11.x branch for 19.11.15 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27196 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.05.00,20.11.01,20.05.08 |21.05.00,20.11.01,20.05.08, released in| |19.11.15 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27196 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org