https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27196 Bug ID: 27196 Summary: Waiting title level hold checked in at wrong location via SIP leaves hold in a broken state and drops connection Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: SIP2 Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: colin.campbell@ptfs-europe.com The problem occurs when we find a hold during SIP checkin - we check the message form AddReturn for the hold value - but for a waiting hold at wrong location the hold has been reverted and, in the case of a title level hold, has no itemnumber We partially succeed in setting the hold to transit and leave the hold in limbo This is due to passing $messages->{ResFound}->{itemnumber} to ModReserveAffect rather than $item->itemnumber which we have available To recreate: 1 - Place a next available hold for delivery at library A 2 - Check the item in at library A to set it waiting 3 - Check the item in via SIP at library B perl misc/sip_cli_emulator.pl -a localhost -p 6001 -su term1 -sp term1 --item BARCODE -l FPL -m checkin 4 - The SIP emulator dies: Use of uninitialized value $data in concatenation (.) or string at misc/sip_cli_emulator.pl line 344, <GEN0> chunk 1. READ: 5 - Check the hold in the db: SELECT * FROM reserves WHERE itemnumber IS NULL and found IS NOT NULL; 5 - Try to load the biblio - ISE Can't call method holdingbranch on an undefined object -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.