[Bug 15029] New: Tests fail if launched after 23:00
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15029 Bug ID: 15029 Summary: Tests fail if launched after 23:00 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: major Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart@bugs.koha-community.org Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org % sudo date -s "2015-10-19 23:50:00";prove t/db_dependent/Members/IssueSlip.t Mon 19 Oct 23:50:00 BST 2015 t/db_dependent/Members/IssueSlip.t .. # Child (Hourly loans) exited without calling finalize() # Failed test 'Hourly loans' # at /home/koha/perl5/lib/perl5/Test/Builder.pm line 276. The 'hour' parameter ("24") to DateTime::set did not pass the 'an integer between 0 and 23' callback at /usr/lib/i386-linux-gnu/perl5/5.20/DateTime.pm line 1944. DateTime::set(undef, "hour", 24) called at t/db_dependent/Members/IssueSlip.t line 200 main::__ANON__() called at /home/koha/perl5/lib/perl5/Test/Builder.pm line 258 Test::Builder::__ANON__() called at /home/koha/perl5/lib/perl5/Test/Builder.pm line 263 eval {...} called at /home/koha/perl5/lib/perl5/Test/Builder.pm line 263 Test::Builder::subtest(Test::Builder=HASH(0x9dd4818), "Hourly loans", CODE(0xd30bc20)) called at /home/koha/perl5/lib/perl5/Test/More.pm line 770 Test::More::subtest("Hourly loans", CODE(0xd30bc20)) called at t/db_dependent/Members/IssueSlip.t line 259 main::__ANON__() called at /home/koha/perl5/lib/perl5/Test/Builder.pm line 258 Test::Builder::__ANON__() called at /home/koha/perl5/lib/perl5/Test/Builder.pm line 263 eval {...} called at /home/koha/perl5/lib/perl5/Test/Builder.pm line 263 Test::Builder::subtest(Test::Builder=HASH(0x9dd4818), "Issue slip", CODE(0xd13eb1c)) called at /home/koha/perl5/lib/perl5/Test/More.pm line 770 Test::More::subtest("Issue slip", CODE(0xd13eb1c)) called at t/db_dependent/Members/IssueSlip.t line 261 # Child (Issue slip) exited without calling finalize() t/db_dependent/Members/IssueSlip.t .. 1/3 # Failed test 'Issue slip' # at /home/koha/perl5/lib/perl5/Test/Builder.pm line 276. # Looks like you planned 3 tests but ran 1. # Looks like you failed 1 test of 1 run. # Looks like your test exited with 29 just after 1. t/db_dependent/Members/IssueSlip.t .. Dubious, test returned 29 (wstat 7424, 0x1d00) Failed 3/3 subtests Test Summary Report ------------------- t/db_dependent/Members/IssueSlip.t (Wstat: 7424 Tests: 1 Failed: 1) Failed test: 1 Non-zero exit status: 29 Parse errors: Bad plan. You planned 3 tests but ran 1. Files=1, Tests=1, 2 wallclock secs ( 0.02 usr 0.00 sys + 1.60 cusr 0.04 csys = 1.66 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15029 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15029 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 43597 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43597&action=edit Bug 15029: Make the IssueSlip tests pass even if launched after 23:00 Prior to this patch, the tests did not pass if they were launched after 23:00. DateTime complains if you ask for creating a date with hour => 24 (which is logical so far). Test plan: 0/ Don't apply this patch 1/ sudo date -s "2015-10-19 23:50:00";prove t/db_dependent/Members/IssueSlip.t 2/ Apply this patch and repeat 1. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15029 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz, | |liz@catalyst.net.nz, | |tomascohen@gmail.com --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Ccing RM & RMaints -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15029 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15029 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43597|0 |1 is obsolete| | --- Comment #3 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 43629 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43629&action=edit Bug 15029: Make the IssueSlip tests pass even if launched after 23:00 Prior to this patch, the tests did not pass if they were launched after 23:00. DateTime complains if you ask for creating a date with hour => 24 (which is logical so far). Test plan: 0/ Don't apply this patch 1/ sudo date -s "2015-10-19 23:50:00";prove t/db_dependent/Members/IssueSlip.t 2/ Apply this patch and repeat 1. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15029 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15029 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43629|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 43660 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43660&action=edit [PASSED QA] Bug 15029: Make the IssueSlip tests pass even if launched after 23:00 Prior to this patch, the tests did not pass if they were launched after 23:00. DateTime complains if you ask for creating a date with hour => 24 (which is logical so far). Test plan: 0/ Don't apply this patch 1/ sudo date -s "2015-10-19 23:50:00";prove t/db_dependent/Members/IssueSlip.t 2/ Apply this patch and repeat 1. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15029 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15029 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #6 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.20.x will be in 3.20.5 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15029 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de QA Contact|testopia@bugs.koha-communit |gmcharlt@gmail.com |y.org | Component|Architecture, internals, |Test Suite |and plumbing | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org