[Bug 11269] New: Latest MARC::Record makes visible some wrong usage of field->subfield in C4::Search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11269 Bug ID: 11269 Summary: Latest MARC::Record makes visible some wrong usage of field->subfield in C4::Search Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt@gmail.com Reporter: tomascohen@gmail.com QA Contact: testopia@bugs.koha-community.org To reproduce: - Run prove -v t/db_dependent/Search.t - There will be warnings about "Use of uninitialized value $code_wanted in string" in MARC::Field. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11269 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11269 --- Comment #1 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 23008 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23008&action=edit Bug 11269 - Latest MARC::Record makes visible some wrong usage of field->subfield in C4::Search To test: - Run prove -v t/db_dependent/Search.t - There will be warnings about "Use of uninitialized value $code_wanted in string" in MARC::Field. - Apply the patch. - Those warnings are gone. Regards To+ -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11269 Liz Rea <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11269 Liz Rea <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23008|0 |1 is obsolete| | --- Comment #2 from Liz Rea <liz@catalyst.net.nz> --- Created attachment 23009 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23009&action=edit Bug 11269 - Latest MARC::Record makes visible some wrong usage of field->subfield in C4::Search To test: - Run prove -v t/db_dependent/Search.t - There will be warnings about "Use of uninitialized value $code_wanted in string" in MARC::Field. - Apply the patch. - Those warnings are gone. Regards To+ Signed-off-by: Liz Rea <liz@catalyst.net.nz> Tests now pass -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11269 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11269 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #3 from Galen Charlton <gmcharlt@gmail.com> --- I've pushed this to master and 3.14.x. Thanks, Tomás! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11269 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- This patch has been pushed to 3.12.x, will be in 3.12.7. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11269 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset@hotmail.com See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11183 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11269 --- Comment #5 from M. Tompsett <mtompset@hotmail.com> --- I added bug 11269 and bug 11183 into their respective see also's, because I believe the second patch in 11183 may solve the same thing this patch does, just at a later point in the code. If so, I believe the second patch to 11183 should be obsoleted. Could someone else check that please? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11269 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolyn.somers@biblibre.co | |m --- Comment #6 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- @Galen, The module MARC::Record should also be fixed no ? Test if $code_wanted is not undef in subfield(). -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org