[Bug 17483] New: Forgiving charge should apply to item's last fine.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17483 Bug ID: 17483 Summary: Forgiving charge should apply to item's last fine. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: philippe.blouin@inlibro.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com When returning an item with a fine, if the Forgive checkbox is clicked, this forgives the first accountline associated to the item/user, not the current/latest as it should. Scenario (Real world): - A patron returns a book late, ensuring a 5$ fine. Does not pay it. - The patron borrows the book again 3 months later. Gets late again, and fined 2$. - Great timing: The library offers amnesty for a week. Bring back your book and we'll forget that they're late. - On checkin, the librarian clicks "Forgive overdue charges" and scan the book. - Koha cancels the 3-months-ago 5$ fine. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17483 Blou <philippe.blouin@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eric.begin@inLibro.com, | |francois.charbonnier@inlibr | |o.com, | |philippe.blouin@inlibro.com Assignee|koha-bugs@lists.koha-commun |philippe.blouin@inlibro.com |ity.org | Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17483 --- Comment #1 from Blou <philippe.blouin@inlibro.com> --- Created attachment 56725 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56725&action=edit Bug 17483 - Forgiving charge should apply to item's last fine. When returning an item with a fine, if the Forgive checkbox is clicked, this forgives the first accountline associated to the item/user, not the current/latest as it should. Scenario (Real world): - A patron returns a book late, ensuring a 5$ fine. Does not pay it. - The patron borrows the book again 3 months later. Gets late again, and fined 2$. - Great timing: The library offers amnesty for a week. Bring back your book and we'll forget that they're late. - On checkin, the librarian clicks "Forgive overdue charges" and scan the book. - Koha cancels the 3-months-ago 5$ fine. Test scenario: - Find a user with an unpaid fine (accounttype = 'FU' in db) on a returned item. - Checkout the same item for the same user. - CHOICE 1: - Force it being late by modifying the date_due to last year. - Run fines.pl to generate another fine. - CHOICE 2: - Create directly another accountlines entry in the DB with the same info - You may change the amounts to help differentiate - Go to the returns.pl screen, check the Forgive checkbox. Return the item. - Look at the DB, the first line got paid. Not the latest one. - APPLY THE PATCH - Redo scenario, this time the latest entry (by the timestamp column) is paid. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17483 Blou <philippe.blouin@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17483 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17483 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alexbuckley@catalyst.net.nz Status|Needs Signoff |In Discussion --- Comment #2 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Hi Blou I ran through your test plan and your patch works fine, however I notice on the current master branch the latest overdue fine gets paid correctly as well, and so I wonder if this patch is necessary? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17483 Maryse Simard <maryse.simard@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17483 Maryse Simard <maryse.simard@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56725|0 |1 is obsolete| | --- Comment #3 from Maryse Simard <maryse.simard@inlibro.com> --- Created attachment 77311 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77311&action=edit Bug 17483: Forgiving charge should apply to item's last fine. When returning an item with a fine, if the Forgive checkbox is clicked, this forgives the first accountline associated to the item/user, not the current/latest as it should. Scenario (Real world): - A patron returns a book late, ensuring a 5$ fine. Does not pay it. - The patron borrows the book again 3 months later. Gets late again, and fined 2$. - Great timing: The library offers amnesty for a week. Bring back your book and we'll forget that they're late. - On checkin, the librarian clicks "Forgive overdue charges" and scan the book. - Koha cancels the 3-months-ago 5$ fine. Test scenario: - Find a user with an unpaid fine (accounttype = 'FU' in db) on a returned item. - Checkout the same item for the same user. - CHOICE 1: - Force it being late by modifying the date_due to last year. - Run fines.pl to generate another fine. - CHOICE 2: - Create directly another accountlines entry in the DB with the same info - You may change the amounts to help differentiate - Go to the returns.pl screen, check the Forgive checkbox. Return the item. - Look at the DB, the first line got paid. Not the latest one. - APPLY THE PATCH - Redo scenario, this time the latest entry (by the timestamp column) is paid. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17483 Maryse Simard <maryse.simard@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |maryse.simard@inlibro.com --- Comment #4 from Maryse Simard <maryse.simard@inlibro.com> --- I tested on the current master and the error still occurs, which means this patch is still needed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17483 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I can't replicate this... I can't see how one can manage to get two 'FU' state fines on the item to be able to come up with the scenario where the older fine would be picked. Could you clarify what settings you are using for fines so we can more accurately replicate this before I signoff on it. (at this point it's a case of 'does no harm, does no good' for me) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17483 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17483 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|philippe.blouin@inlibro.com |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17483 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22200 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17483 hannah.co@northwestu.edu changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hannah.co@northwestu.edu -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17483 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |18.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17483 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Component|Circulation |Fines and fees -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17483 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |RESOLVED Resolution|--- |WORKSFORME --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- OK, tried again and still can't replicate this one.. I'm going to close it with WORKSFORME.. if you can still replicate it please open a new bug with a reproducible test plan. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org