[Bug 15168] New: Remove C4::Serials::ItemizeSerials which is not used anymore
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15168 Bug ID: 15168 Summary: Remove C4::Serials::ItemizeSerials which is not used anymore Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart@bugs.koha-community.org Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15168 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15168 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 44724 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44724&action=edit Bug 15168: Remove C4:Serials::ItemizeSerials This subroutine has been introduced in 2006, when C4::Serials has been added to the codebase. If you checkout this commit commit 18d2cd099085e443d713a1546e029faa81481814 Date: Fri Jul 7 08:45:47 2006 +0000 this file replace C4/Bull.pm You won't find any occurrences of this subroutine neither. Interesting module's name by the way. Test plan: git grep ItemizeSerials should not return any result -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15168 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14969 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14969 [Bug 14969] Remove C4::Dates from serials/*.pl files -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15168 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44724|0 |1 is obsolete| | --- Comment #2 from Marc Véron <veron@veron.ch> --- Created attachment 44733 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44733&action=edit Bug 15168: Remove C4:Serials::ItemizeSerials This subroutine has been introduced in 2006, when C4::Serials has been added to the codebase. If you checkout this commit commit 18d2cd099085e443d713a1546e029faa81481814 Date: Fri Jul 7 08:45:47 2006 +0000 this file replace C4/Bull.pm You won't find any occurrences of this subroutine neither. Interesting module's name by the way. Test plan: git grep ItemizeSerials should not return any result Followed test plan, no results found. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15168 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15168 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15168 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44733|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 44778 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44778&action=edit [PASSED QA] Bug 15168: Remove C4:Serials::ItemizeSerials This subroutine has been introduced in 2006, when C4::Serials has been added to the codebase. If you checkout this commit commit 18d2cd099085e443d713a1546e029faa81481814 Date: Fri Jul 7 08:45:47 2006 +0000 this file replace C4/Bull.pm You won't find any occurrences of this subroutine neither. Interesting module's name by the way. Test plan: git grep ItemizeSerials should not return any result Followed test plan, no results found. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15168 --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 44935 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44935&action=edit Bug 15168: (followup) remove useless diags While testing this bug I noticed the tests printed useless diags. This patch removes them for good. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15168 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Status|Passed QA |Pushed to Master --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org