http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14969 --- Comment #1 from Marc Véron <veron@veron.ch> --- Created attachment 43182 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43182&action=edit Bug 14969 - Remove C4::Dates from serials/*.pl files Bug to remove C4::Dates from files: - serials/acqui-search-result.pl - serials/checkexpiration.pl - serials/routing-preview.pl - serials/routing.pl - serials/serial-issues.pl - serials/serials-collection.pl - serials/serials-edit.pl - serials/showpredictionpattern.pl - serials/subscription-add.pl - serials/subscription-detail.pl - serials/subscription-history.pl - serials/subscription-renew.pl To test: - Go to Home > Serials - Add, edit serials and routing lists with focus on date entry and display - Verify that information for serials on item detail pages look fine in OPAC and staff client as well - Try to find regressions -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14969 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14969 --- Comment #2 from Marc Véron <veron@veron.ch> --- Still applies -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14969 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43182|0 |1 is obsolete| | --- Comment #4 from Marc Véron <veron@veron.ch> --- Created attachment 44441 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44441&action=edit Bug 14969 - Remove C4::Dates from serials/*.pl files Bug to remove C4::Dates from files: - serials/acqui-search-result.pl - serials/checkexpiration.pl - serials/routing-preview.pl - serials/routing.pl - serials/serial-issues.pl - serials/serials-collection.pl - serials/serials-edit.pl - serials/showpredictionpattern.pl - serials/subscription-add.pl - serials/subscription-detail.pl - serials/subscription-history.pl - serials/subscription-renew.pl To test: - Go to Home > Serials - Add, edit serials and routing lists with focus on date entry and display - Verify that information for serials on item detail pages look fine in OPAC and staff client as well - Try to find regressions Amended to make it apply ( serials/checkexpiration.pl ) 04.11.2015 / mv -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14969 --- Comment #6 from Marc Véron <veron@veron.ch> --- Without the patch, invalid dates like 33/33/2099 produced some fantays dates in the future. It is rather difficult to introduce a good date validation here. I'm trying, but if in the meantime soebody presents a valid solution I would not oppose :-) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14969 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44526|0 |1 is obsolete| | --- Comment #8 from Marc Véron <veron@veron.ch> --- Created attachment 44527 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44527&action=edit Bug 14969: (followup) Handle invalid date input This patch fixes software errors if invalid dates are given while adding or editing a subscription (see comment #5). Subscriptions with invalid dates will be saved with empty dates. A warning will appear on the subscription detail page. This will be a rare case because normally datepickers are used for date entry. Notes: - Before C4::Dates removal, wrong dates like 33/33/2033 did not complain, they created valid but fantasy dates in the future. - A more sophisticated date validation can be implemented in a separate bug after completion of C4::Dates removal. To test: - Create and edit subscriptions with valid dates, verify that subscriptions are correctly defined - Bypass datepickers by manually entering dates like 00/00/0000 or 33/33/2999, verify that subscriptions are saved, but a warning appears on the subscription's detail page. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14969 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44527|0 |1 is obsolete| | --- Comment #10 from Marc Véron <veron@veron.ch> --- Created attachment 44528 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44528&action=edit Bug 14969: (followup) Handle invalid date input This patch fixes software errors if invalid dates are given while adding or editing a subscription (see comment #5). Subscriptions with invalid dates will be saved with empty dates. A warning will appear on the subscription detail page. This will be a rare case because normally datepickers are used for date entry. Notes: - Before C4::Dates removal, wrong dates like 33/33/2033 did not complain, they created valid but fantasy dates in the future, e.g. 32/22/2099 resulted in 03/11/2100 - A more sophisticated date validation can be implemented in a separate bug after completion of C4::Dates removal. To test: - Create and edit subscriptions with valid dates, verify that subscriptions are correctly defined - Bypass datepickers by manually entering dates like 00/00/0000 or 33/33/2999, verify that subscriptions are saved, but a warning appears on the subscription's detail page. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14969 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44528|0 |1 is obsolete| | --- Comment #12 from Mirko Tietgen <mirko@abunchofthings.net> --- Created attachment 44550 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44550&action=edit Bug 14969: (followup) Handle invalid date input This patch fixes software errors if invalid dates are given while adding or editing a subscription (see comment #5). Subscriptions with invalid dates will be saved with empty dates. A warning will appear on the subscription detail page. This will be a rare case because normally datepickers are used for date entry. Notes: - Before C4::Dates removal, wrong dates like 33/33/2033 did not complain, they created valid but fantasy dates in the future, e.g. 32/22/2099 resulted in 03/11/2100 - A more sophisticated date validation can be implemented in a separate bug after completion of C4::Dates removal. To test: - Create and edit subscriptions with valid dates, verify that subscriptions are correctly defined - Bypass datepickers by manually entering dates like 00/00/0000 or 33/33/2999, verify that subscriptions are saved, but a warning appears on the subscription's detail page. Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14969 --- Comment #13 from Marc Véron <veron@veron.ch> --- Created attachment 44617 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44617&action=edit Bug 14969: (followup) Remove C4::Dates from C4/Serials.pm This is a follow-up removing stray C4::Dates The patch removes C4::Dates from file C4/Serials.pm. To test: - Go to Home > Serials - Add, edit serials and routing lists with focus on date entry and display - Verify that information for serials on item detail pages look fine in OPAC and staff client as well - Try to find regressions -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14969 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #15 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- 1/ " = " => Useless spaces. 2/ $tmpPlannedDate is not necessary, don't use this tmp var. 3/ my $date = ''; my $date; #is enough 4/ + $expirationdate = eval { output_pref( { dt => dt_from_string( $expirationdate ), dateonly => 1, dateformat => 'iso' }); } + if ( $expirationdate ); + + next unless ( $expirationdate ); + $subscription->{expirationdate} = $expirationdate; - next if $expirationdate !~ /\d{4}-\d{2}-\d{2}/; # next if not in ISO format. This change is not needed. 5/ - Date_to_Days(split "-",$expirationdate) > Date_to_Days(&Today) && I don't understand why you removed this line. There are still other some inconsistencies, I would like to know what methodology you use to replace these occurrences. For instance format_date always expect an iso formatted date, but you replace these occurrences with output_pref( { dt => dt_from_string( $date ), dateonly => 1 }) you should specify the dateformat param to dt_from_string. And sometimes you replace them with $date = eval { dt_from_string( $date ) } if $date; $date = output_pref( { dt => $date, dateonly => 1 } ) if $date; The changes are coming complicated and more and more errors are found on the QA step. I would like to see a migration plan with a test file to highlight the changes you are doing. If I remember correctly, I have attached a file doing that some weeks ago (but don't find it anymore). We need to test several values: undef, empty string, valid date, invalid date -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14969 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14969 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|veron@veron.ch |jonathan.druart@bugs.koha-c | |ommunity.org Status|Signed Off |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14969 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15171 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15171 [Bug 15171] Searching serials expiring after today should be allowed -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14969 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44549|0 |1 is obsolete| | Attachment #44550|0 |1 is obsolete| | Attachment #44618|0 |1 is obsolete| | Attachment #44694|0 |1 is obsolete| | --- Comment #19 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 44735 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44735&action=edit Bug 14969: Remove C4::Dates from serials/*.pl files Warning: This area is a mess, especially with date management. For the same reasons as other "Remove C4::Dates from*" patches, this one will deal with the serials module. Note that this patch add the datepicker on 3 input fields (on serials/subscription-detail.tt and serials/subscription-renew.tt). There was also weird behavior when the dates were invalid. Now default to undefined. But with the datepicker it will reduce the number of cases even if the user is still allowed to fill invalid dates. Test plan: 1/ Create a subscription, fill the first issue pub date and the subscription start date. You can fill or not the end date. Play with the numbering pattern and confirm that there are generated as before this patch. 2/ On the check expiration page, confirm that the dates are correctly displayed. 3/ Renew the subscription and confirm that the behavior is correct. 4/ Go on the subscription history page and confirm you have now the datepicker plugin set on the 2 date fields. QA notes: The startdate, histstartdate and enddate are not used in the serials-collection template, this patch removes them from the pl script. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14969 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15166 --- Comment #21 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I have missed bug 15166 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15166 [Bug 15166] Make output_pref accept a string as parameter -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14969 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44735|0 |1 is obsolete| | --- Comment #23 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 44763 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44763&action=edit Bug 14969: Remove C4::Dates from serials/*.pl files Warning: This area is a mess, especially with date management. For the same reasons as other "Remove C4::Dates from*" patches, this one will deal with the serials module. Note that this patch add the datepicker on 3 input fields (on serials/subscription-detail.tt and serials/subscription-renew.tt). There was also weird behavior when the dates were invalid. Now default to undefined. But with the datepicker it will reduce the number of cases even if the user is still allowed to fill invalid dates. Test plan: 1/ Create a subscription, fill the first issue pub date and the subscription start date. You can fill or not the end date. Play with the numbering pattern and confirm that there are generated as before this patch. 2/ On the check expiration page, confirm that the dates are correctly displayed. 3/ Renew the subscription and confirm that the behavior is correct. 4/ Go on the subscription history page and confirm you have now the datepicker plugin set on the 2 date fields. QA notes: The startdate, histstartdate and enddate are not used in the serials-collection template, this patch removes them from the pl script. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14969 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|15167 | See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15167 --- Comment #25 from Marc Véron <veron@veron.ch> --- Moved 15167 from "Depends on" to "See also" Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15167 [Bug 15167] Remove unused script serials/acqui-search-result.pl -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14969 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14969 --- Comment #28 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Ah, and I tested this one on top of 15166 and 15171 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14969 --- Comment #30 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think I found a real, but tiny bug now: - When switching the issue status from expected to arrived from the serials-edit page, today's page is shown including the time - but should only be a date. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14969 --- Comment #32 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Marc Véron from comment #31)

Created attachment 44794 [details] [review] Bug 14969: (followup) Today's date withoute time when receiving

To test: Change status of a serial from Expected to Received, today's date in column "Expected" should appear without time.

I was going to submit exactly the same patch. Thanks Marc. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14969 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #34 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Sorry Marc - a recent change causes a merge conflict in checkexpiration.pl. Can you please take a look and fix? -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14969 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14969 --- Comment #37 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 44931 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44931&action=edit [PASSED QA] Bug 14969: (followup) Today's date withoute time when receiving To test: Change status of a serial from Expected to Received, today's date in column "Expected" should appear without time. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.