[Bug 30868] New: Modifying a patron - page not found error after fixing validation errors where the message is displayed at the top of the page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30868 Bug ID: 30868 Summary: Modifying a patron - page not found error after fixing validation errors where the message is displayed at the top of the page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P1 - high Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: david@davidnind.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com A page not found error message is generated after fixing validation errors when editing a patron - where the validation/error message is shown at the top of the page (below the patron name, but before the Save and Cancel buttons). To replicate: 1. Edit a patron record (for example: Henry Acevedo). 2. Note that the URL is http://127.0.0.1:8081/cgi-bin/koha/members/memberentry.pl?op=modify&destination=circ&borrowernumber=19 3. Change date of birth to yesterday. 4. Save. 5. Error message displayed above the Save and Cancel buttons: The following fields are wrong. Please fix them. - Patron's age is incorrect for their category. Ages allowed are 18-999. 6. Note that the URL is now http://127.0.0.1:8081/cgi-bin/koha/members/memberentry.pl 7. Fix date of birth (for example: change year to 2000). 8. Select Save. 9. Message displayed: "Patron not found. Return to search." Inline validation errors (such as for required fields) don't cause this issue. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30868 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com Assignee|koha-bugs@lists.koha-commun |jonathan.druart+koha@gmail. |ity.org |com Severity|normal |major Status|NEW |ASSIGNED Depends on| |29684 --- Comment #1 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- I think it has been introduced by bug 29684 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29684 [Bug 29684] Warning File not found: js/locale_data.js -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30868 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30868 --- Comment #2 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 135465 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135465&action=edit Bug 30868: (bug 29684 follow-up) Fix borrowernumber var in template borrower_data does not contain the borrowernumber, it is sent separately. Test plan: 1. Edit a patron record (for example: Henry Acevedo). 2. Note that the URL is http://127.0.0.1:8081/cgi-bin/koha/members/memberentry.pl?op=modify&destination=circ&borrowernumber=19 3. Change date of birth to yesterday. 4. Save. 5. Error message displayed above the Save and Cancel buttons: The following fields are wrong. Please fix them. - Patron's age is incorrect for their category. Ages allowed are 18-999. 6. Note that the URL is now http://127.0.0.1:8081/cgi-bin/koha/members/memberentry.pl 7. Fix date of birth (for example: change year to 2000). 8. Select Save. => Without this patch you get: "Patron not found. Return to search." => With this patch applied the patron's data is saved -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30868 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30868 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135465|0 |1 is obsolete| | --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 135466 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135466&action=edit Bug 30868: (bug 29684 follow-up) Fix borrowernumber var in template borrower_data does not contain the borrowernumber, it is sent separately. Test plan: 1. Edit a patron record (for example: Henry Acevedo). 2. Note that the URL is http://127.0.0.1:8081/cgi-bin/koha/members/memberentry.pl?op=modify&destination=circ&borrowernumber=19 3. Change date of birth to yesterday. 4. Save. 5. Error message displayed above the Save and Cancel buttons: The following fields are wrong. Please fix them. - Patron's age is incorrect for their category. Ages allowed are 18-999. 6. Note that the URL is now http://127.0.0.1:8081/cgi-bin/koha/members/memberentry.pl 7. Fix date of birth (for example: change year to 2000). 8. Select Save. => Without this patch you get: "Patron not found. Return to search." => With this patch applied the patron's data is saved Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30868 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30868 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30868 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135466|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 135719 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135719&action=edit Bug 30868: (bug 29684 follow-up) Fix borrowernumber var in template borrower_data does not contain the borrowernumber, it is sent separately. Test plan: 1. Edit a patron record (for example: Henry Acevedo). 2. Note that the URL is http://127.0.0.1:8081/cgi-bin/koha/members/memberentry.pl?op=modify&destination=circ&borrowernumber=19 3. Change date of birth to yesterday. 4. Save. 5. Error message displayed above the Save and Cancel buttons: The following fields are wrong. Please fix them. - Patron's age is incorrect for their category. Ages allowed are 18-999. 6. Note that the URL is now http://127.0.0.1:8081/cgi-bin/koha/members/memberentry.pl 7. Fix date of birth (for example: change year to 2000). 8. Select Save. => Without this patch you get: "Patron not found. Return to search." => With this patch applied the patron's data is saved Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30868 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30868 --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30868 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00 |22.11.00, 22.05.01 released in| | CC| |lucas@bywatersolutions.com Status|Pushed to master |Pushed to stable --- Comment #6 from Lucas Gass <lucas@bywatersolutions.com> --- Pushed to 22.05.x for 22.05.01 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30868 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable CC| |arthur.suzuki@biblibre.com Version(s)|22.11.00, 22.05.01 |22.11.00, 22.05.01, released in| |21.11.07 --- Comment #7 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- thx pushed to 21.11.x for 21.11.07 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30868 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes a page not found release notes| |error message generated | |after fixing validation | |errors when editing a | |patron (where the | |validation/error message is | |shown at the top of the | |page - below the patron | |name, but before the Save | |and Cancel buttons). (This | |was introduced by bug | |29684: Fix warn about | |js/locale_data.js in | |22.05.) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30868 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to oldstable |RESOLVED CC| |victor@tuxayo.net --- Comment #8 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Missing dependencies for 21.05.x, it shouldn't be affected, no backport. Nothing to document, marking resolved. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org