[Bug 30523] New: Quiet console warning about missing shortcut-buttons map file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30523 Bug ID: 30523 Summary: Quiet console warning about missing shortcut-buttons map file Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org The Flatpickr addon shortcut-buttons-flatpickr includes a line referring to a non-existent map file: //# sourceMappingURL=shortcut-buttons-flatpickr.min.js.map I propose removing this line, and updating the addon to the latest version while I'm at it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30523 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30523 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 133305 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133305&action=edit Bug 30523: Quiet console warning about missing shortcut-buttons map file This patch updates the Flatpickr plugin shortcut-buttons which adds the "Yesterday," "Today," and "Tomorrow" links to Flatpickr widgets. This updates it to the latest version, 0.4.0. The file is modified in two ways: The version information is added to the top of the file, and the sourceMappingURL line is removed from the bottom. This quiets browser console warnings about a missing map file. To test, apply the patch and clear your browser cache. - Go to Circulation -> Check out and check out to a patron. - Click "Checkout settings" and click the "Specify due date" field. - In the pop-up calendar, test all controls, including the shortcut links, to confirm that everything works as before. - In the browser console there should be no warning related to shortcut-buttons-flatpickr. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30523 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30523 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133305|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 135009 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135009&action=edit Bug 30523: Quiet console warning about missing shortcut-buttons map file This patch updates the Flatpickr plugin shortcut-buttons which adds the "Yesterday," "Today," and "Tomorrow" links to Flatpickr widgets. This updates it to the latest version, 0.4.0. The file is modified in two ways: The version information is added to the top of the file, and the sourceMappingURL line is removed from the bottom. This quiets browser console warnings about a missing map file. To test, apply the patch and clear your browser cache. - Go to Circulation -> Check out and check out to a patron. - Click "Checkout settings" and click the "Specify due date" field. - In the pop-up calendar, test all controls, including the shortcut links, to confirm that everything works as before. - In the browser console there should be no warning related to shortcut-buttons-flatpickr. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30523 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135009|0 |1 is obsolete| | --- Comment #3 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 135012 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135012&action=edit Bug 30523: Quiet console warning about missing shortcut-buttons map file This patch updates the Flatpickr plugin shortcut-buttons which adds the "Yesterday," "Today," and "Tomorrow" links to Flatpickr widgets. This updates it to the latest version, 0.4.0. The file is modified in two ways: The version information is added to the top of the file, and the sourceMappingURL line is removed from the bottom. This quiets browser console warnings about a missing map file. To test: - apply the patch and clear your browser cache. - Go to Circulation -> Check out and check out to a patron. - Click "Checkout settings" and click the "Specify due date" field. - In the pop-up calendar, test all controls, including the shortcut links, to confirm that everything works as before. - In the browser console there should be no warning related to shortcut-buttons-flatpickr. (Firefox didn't have the warning, Chromium can be used. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30523 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net Status|Signed Off |Passed QA --- Comment #4 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Works, qa script happy, code looks good, passing QA :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30523 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com QA Contact|testopia@bugs.koha-communit |victor@tuxayo.net |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30523 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30523 --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30523 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |lucas@bywatersolutions.com Version(s)|22.11.00 |22.11.00, 22.05.01 released in| | --- Comment #6 from Lucas Gass <lucas@bywatersolutions.com> --- Pushed to 22.05.x for 22.05.01 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30523 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00, 22.05.01 |22.11.00, 22.05.01, released in| |21.11.07 CC| |arthur.suzuki@biblibre.com Status|Pushed to stable |Pushed to oldstable --- Comment #7 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Thx! pushed to 21.11.x for 21.11.07 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30523 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to oldstable |RESOLVED --- Comment #8 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. Nothing to document, marking resolved. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org