[Bug 40959] New: LOC classification display broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40959 Bug ID: 40959 Summary: LOC classification display broken Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: MARC Bibliographic data support Assignee: koha-bugs@lists.koha-community.org Reporter: tomascohen@gmail.com QA Contact: testopia@bugs.koha-community.org To reproduce: 1. Open a record to edit it 2. Add 050 like this: ``` 050 4 $aE337.5 $b.O54 2025 050 4 $aE415.7 $b.A44 2025 ``` 3. Save => FAIL On the staff interface it displays: ``` LOC classification: E337.5 | .O54 2025 E415.7 | .A44 2025 ``` 4. In the OPAC, it renders correctly -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40959 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |tomascohen@gmail.com |ity.org | CC| |tomascohen@gmail.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40959 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40959 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40959 --- Comment #1 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 187481 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187481&action=edit Bug 40959: Fix LOC classification display (staff interface) This patch fixes the display logic for the LOC classification field (050). The current issue is that the inner components (each subfield) gets separated with the pipe symbol (|) instead of grouping the components together and using the separator for the outer 050 occurences. To test: 1. Open a record to edit it 2. Add 050 like this: ``` 050 4 $aE337.5 $b.O54 2025 050 4 $aE415.7 $b.A44 2025 ``` 3. Save => FAIL On the staff interface it displays: ``` LOC classification: E337.5 | .O54 2025 E415.7 | .A44 2025 ``` 4. Apply this patch 5. Run: $ ktd --shell k$ restart_all 6. Reload the detail page => SUCCESS: Things display correctly! 7. Sign off :-D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40959 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |30148 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30148 [Bug 30148] Pipe separated contents are hard to customize (staff interface) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40959 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40959 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187481|0 |1 is obsolete| | --- Comment #2 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 187496 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187496&action=edit Bug 40959: Fix LOC classification display (staff interface) This patch fixes the display logic for the LOC classification field (050). The current issue is that the inner components (each subfield) gets separated with the pipe symbol (|) instead of grouping the components together and using the separator for the outer 050 occurences. To test: 1. Open a record to edit it 2. Add 050 like this: ``` 050 4 $aE337.5 $b.O54 2025 050 4 $aE415.7 $b.A44 2025 ``` 3. Save => FAIL On the staff interface it displays: ``` LOC classification: E337.5 | .O54 2025 E415.7 | .A44 2025 ``` 4. Apply this patch 5. Run: $ ktd --shell k$ restart_all 6. Reload the detail page => SUCCESS: Things display correctly! 7. Sign off :-D Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40959 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |23731 CC| |nick@bywatersolutions.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23731 [Bug 23731] Display LC call number in OPAC and staff detail pages -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40959 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40959 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187496|0 |1 is obsolete| | --- Comment #3 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 188036 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188036&action=edit Bug 40959: Fix LOC classification display (staff interface) This patch fixes the display logic for the LOC classification field (050). The current issue is that the inner components (each subfield) gets separated with the pipe symbol (|) instead of grouping the components together and using the separator for the outer 050 occurences. To test: 1. Open a record to edit it 2. Add 050 like this: ``` 050 4 $aE337.5 $b.O54 2025 050 4 $aE415.7 $b.A44 2025 ``` 3. Save => FAIL On the staff interface it displays: ``` LOC classification: E337.5 | .O54 2025 E415.7 | .A44 2025 ``` 4. Apply this patch 5. Run: $ ktd --shell k$ restart_all 6. Reload the detail page => SUCCESS: Things display correctly! 7. Sign off :-D Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40959 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |nick@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40959 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40959 --- Comment #4 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40959 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Text to go in the| |This fixes the display release notes| |logic for the Library of | |Congress classification | |field (050) in the staff | |interface for MARC21. The | |separator was being shown | |between subfields $a and | |$b, instead of between | |additional 050 entries. | | | |Example: | | | |For an 050 with two | |entries: | | | | 050 4 $aE337.5 $b.O54 | |2025 | | 050 4 $aE415.7 $b.A44 | |2025 | | | |This was incorrectly shown | |in the staff interface as: | | | | LOC classification: E337.5 | || .O54 2025 E415.7 | .A44 | |2025 | | | |It should have been shown | |as: | | | | LOC classification: | |E337.5 O54 2025 | E415.7 | |A44 2025 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40959 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|25.11.00 |25.11.00,25.05.05 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40959 --- Comment #5 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Nice work everyone! Pushed to 25.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40959 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Version(s)|25.11.00,25.05.05 |25.11.00,25.05.05,24.11.11 released in| | Status|Pushed to stable |Pushed to oldstable --- Comment #6 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 24.11.x for 24.11.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40959 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Needs documenting --- Comment #7 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11.x as it wasn't backported to 24.05.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org