[Bug 9076] New: Add ability to delete borrowers by expiration date and category code to cleanborrowers.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9076 Priority: P5 - low Change sponsored?: --- Bug ID: 9076 CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Assignee: koha-bugs@lists.koha-community.org Summary: Add ability to delete borrowers by expiration date and category code to cleanborrowers.pl Severity: enhancement Classification: Unclassified OS: All Reporter: kyle@bywatersolutions.com Hardware: All Status: NEW Version: master Component: Patrons Product: Koha -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9076 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 13449 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13449&action=edit Bug 9076 - Add ability to delete borrowers by expiration date and category code to cleanborrowers.pl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9076 --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 13450 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13450&action=edit Bug 9076 - Followup - Perltidy cleanborrowers.pl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9076 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9076 --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- Test plan: 1) Apply patch 2) Attempt to delete borrowers using each combination of criteria: a) Hasn't borrowed since b) Expiration date c) Category code d) a & b e) a & c f) b & c g) a & b & c -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9076 Liz Rea (CatalystIT) <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion CC| |liz@catalyst.net.nz --- Comment #4 from Liz Rea (CatalystIT) <liz@catalyst.net.nz> --- With the sample data, there are 5 staff patrons defined (or so - I had 6 but I believe I added one more). This tool, when asked to delete staff patrons, indicated there were no patrons that met the criteria of "category: staff." The other categories worked as expected. Can this tool not delete staff patrons? Is that by design? If it is by design, then that categorycode needs to be removed from the list. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9076 --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to comment #4)
With the sample data, there are 5 staff patrons defined (or so - I had 6 but I believe I added one more). This tool, when asked to delete staff patrons, indicated there were no patrons that met the criteria of "category: staff." The other categories worked as expected.
Can this tool not delete staff patrons? Is that by design? If it is by design, then that categorycode needs to be removed from the list.
That is correct. It has never been able to delete staff patrons. I would assume that was a 'safety' feature. I'll add a followup to remove staff from the list. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9076 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13449|0 |1 is obsolete| | --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 13491 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13491&action=edit Bug 9076 - Add ability to delete borrowers by expiration date and category code to cleanborrowers.pl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9076 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13450|0 |1 is obsolete| | --- Comment #7 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 13492 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13492&action=edit Bug 9076 - Followup - Perltidy cleanborrowers.pl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9076 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff --- Comment #8 from Kyle M Hall <kyle@bywatersolutions.com> --- Fixed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9076 Liz Rea (CatalystIT) <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13491|0 |1 is obsolete| | --- Comment #9 from Liz Rea (CatalystIT) <liz@catalyst.net.nz> --- Created attachment 13541 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13541&action=edit Bug 9076 - Add ability to delete borrowers by expiration date and category code to cleanborrowers.pl Signed-off-by: Liz Rea <liz@catalyst.net.nz> Tested per plan, works. Staff category is not shown, and patch passes automated testing. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9076 Liz Rea (CatalystIT) <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13492|0 |1 is obsolete| | --- Comment #10 from Liz Rea (CatalystIT) <liz@catalyst.net.nz> --- Created attachment 13542 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13542&action=edit Bug 9076 - Followup - Perltidy cleanborrowers.pl Signed-off-by: Liz Rea <liz@catalyst.net.nz> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9076 Liz Rea (CatalystIT) <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9076 --- Comment #11 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 13551 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13551&action=edit Bug 9076: Followup: FIX ergonomic issues If no criteria is given, the form was submitted. Labels were wrong -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9076 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff CC| |jonathan.druart@biblibre.co | |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9076 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9076 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13551|0 |1 is obsolete| | --- Comment #12 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 13552 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13552&action=edit Bug 9076: Followup: FIX ergonomic issues If no criteria is given, the form was submitted. Labels were wrong Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9076 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9076 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact| |jonathan.druart@biblibre.co | |m --- Comment #13 from Jonathan Druart <jonathan.druart@biblibre.com> --- QA Comment: Great improvements for the clean borrowers tool. Patch clean. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9076 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |In Discussion --- Comment #14 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- I have a question about your changes to the GetBorrowersWhoHaveNotBorrowedSince routine. It looks to me like you have changed the routine so that it will use a number of different criteria to decide whether a borrower should be deleted. Is that correct? If so, shouldn't we change the name to reflect what the routine actually does? Perhaps something like "GetBorrowersToExpunge" would more accurately describe what it does now? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9076 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch --- Comment #15 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to comment #14)
I have a question about your changes to the GetBorrowersWhoHaveNotBorrowedSince routine. It looks to me like you have changed the routine so that it will use a number of different criteria to decide whether a borrower should be deleted. Is that correct? If so, shouldn't we change the name to reflect what the routine actually does? Perhaps something like "GetBorrowersToExpunge" would more accurately describe what it does now?
I totally agree. I'll submit a followup to fix this unless someone else beats me to it. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9076 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9076 --- Comment #16 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 14008 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14008&action=edit Bug 9076 - QA Followup - Rename GetBorrowersWhoHaveNotBorrowedSince to GetBorrowersToExpunge -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9076 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9076 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |7919 --- Comment #17 from Jonathan Druart <jonathan.druart@biblibre.com> --- This patch is broken by Bug 7919 (categorycode is null so we cannot filter by patron category) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9076 --- Comment #18 from Kyle M Hall <kyle@bywatersolutions.com> --- I'm seeing the category pulldown populated correctly. Can you give me a bit more detail about the problem? (In reply to comment #17)
This patch is broken by Bug 7919 (categorycode is null so we cannot filter by patron category)
-- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9076 --- Comment #19 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to comment #18)
I'm seeing the category pulldown populated correctly. Can you give me a bit more detail about the problem?
The fix has been pushed so the problem does not exist anymore. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9076 --- Comment #20 from Liz Rea (CatalystIT) <liz@catalyst.net.nz> --- so this still needs a QA look please. :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9076 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #21 from Jonathan Druart <jonathan.druart@biblibre.com> --- Last patch passes QA. The feature still works. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9076 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13541|0 |1 is obsolete| | --- Comment #22 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 14406 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14406&action=edit Bug 9076 - Add ability to delete borrowers by expiration date and category code to cleanborrowers.pl Signed-off-by: Liz Rea <liz@catalyst.net.nz> Tested per plan, works. Staff category is not shown, and patch passes automated testing. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9076 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13542|0 |1 is obsolete| | --- Comment #23 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 14407 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14407&action=edit Bug 9076 - Followup - Perltidy cleanborrowers.pl Signed-off-by: Liz Rea <liz@catalyst.net.nz> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9076 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13552|0 |1 is obsolete| | --- Comment #24 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 14408 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14408&action=edit Bug 9076: Followup: FIX ergonomic issues If no criteria is given, the form was submitted. Labels were wrong Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9076 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14008|0 |1 is obsolete| | --- Comment #25 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 14409 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14409&action=edit Bug 9076 - QA Followup - Rename GetBorrowersWhoHaveNotBorrowedSince to GetBorrowersToExpunge Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9076 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #26 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master, though not without some concern about the layout. Liz has promised a speedy follow-up, so I will open another bug about it. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9076 --- Comment #27 from Jacek Ablewicz <abl@biblos.pk.edu.pl> --- *** Bug 6404 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9076 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15398 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org