[Bug 11489] New: OPAC search results in 404 error when the only search result is supressed
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11489 Bug ID: 11489 Summary: OPAC search results in 404 error when the only search result is supressed Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: kyle@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org If hidelostitems is enabled, and the result of an opac search is a single lost item, then the opac will display a 404 error, rather than a "no results" screen. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11489 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11489 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11489 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 23989 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23989&action=edit Bug 11489 - OPAC search results in 404 error when the only search result is supressed If hidelostitems is enabled, and the result of an opac search is a single lost item, then the opac will display a 404 error, rather than a "no results" screen. Test Plan: 1) Catalog a record/item such that it is the only result for some search e.g. Give it the title 'zxcvb' 2) Enable hidelostitems 3) Mark this item as lost 4) Perform an OPAC search that should result in a redirect to this record 5) Notice you a redirected to a 404 error 6) Apply this patch 7) Repeat step 4 8) Note you new get a "No results found!" page instead -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11489 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23989|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 23990 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23990&action=edit Bug 11489 - OPAC search results in 404 error when the only search result is supressed If hidelostitems is enabled, and the result of an opac search is a single lost item, then the opac will display a 404 error, rather than a "no results" screen. Test Plan: 1) Catalog a record/item such that it is the only result for some search e.g. Give it the title 'zxcvb' 2) Enable hidelostitems 3) Mark this item as lost 4) Perform an OPAC search that should result in a redirect to this record 5) Notice you a redirected to a 404 error 6) Apply this patch 7) Repeat step 4 8) Note you new get a "No results found!" page instead -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11489 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11489 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset@hotmail.com See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11432 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11489 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion CC| |cbrannon@cdalibrary.org --- Comment #3 from Christopher Brannon <cbrannon@cdalibrary.org> --- Kyle, This issue appears to no longer apply. I tested on a sandbox against master, and with hidelostitems set to show, item shows as lost. If set to Don't show, record shows without any item showing. Please confirm test parameters. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11489 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- I'm still seeing this error in master: http://screencast.com/t/gvuoF4pyebF -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11489 --- Comment #5 from Christopher Brannon <cbrannon@cdalibrary.org> --- My bad. I don't know why it worked before. I just tested it again and now I am getting the same results. Thanks for confirming. Christopher -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11489 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sandboxes@biblibre.com --- Comment #6 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Patch tested with a sandbox, by Christopher Brannon <cbrannon@cdalibrary.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11489 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23990|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11489 --- Comment #7 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 24291 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24291&action=edit Bug 11489 - OPAC search results in 404 error when the only search result is supressed If hidelostitems is enabled, and the result of an opac search is a single lost item, then the opac will display a 404 error, rather than a "no results" screen. Test Plan: 1) Catalog a record/item such that it is the only result for some search e.g. Give it the title 'zxcvb' 2) Enable hidelostitems 3) Mark this item as lost 4) Perform an OPAC search that should result in a redirect to this record 5) Notice you a redirected to a 404 error 6) Apply this patch 7) Repeat step 4 8) Note you new get a "No results found!" page instead Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11489 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion --- Comment #8 from M. Tompsett <mtompset@hotmail.com> --- Using a copy of our old data on a git install, I found we had a three copies of a book '101 Stupid Things Trainers Do To Sabotage Success' (1 biblio, 3 items), and one was lost. I deleted the two we had, and kept the lost one. I went to the system preferences and toggled it between looking at the OPAC search for 'stupid things' which was unique, and I have it showing and not showing the 1 item. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11489 --- Comment #9 from Christopher Brannon <cbrannon@cdalibrary.org> --- (In reply to M. Tompsett from comment #8)
Using a copy of our old data on a git install, I found we had a three copies of a book '101 Stupid Things Trainers Do To Sabotage Success' (1 biblio, 3 items), and one was lost. I deleted the two we had, and kept the lost one. I went to the system preferences and toggled it between looking at the OPAC search for 'stupid things' which was unique, and I have it showing and not showing the 1 item.
I had a similar result the first time, which prompted my request for confirmation above. But when I went to try it today, it gave the error. I have tested twice now, and the patch does work. Christopher -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11489 --- Comment #10 from M. Tompsett <mtompset@hotmail.com> --- Oops... I got a cross-problem with the OpacHiddenItems. I'm doing further retesting. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11489 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off --- Comment #11 from M. Tompsett <mtompset@hotmail.com> --- TEST PLAN --------- home cataloguing new from z39.50 purple search import (Abbott & Costello cartoons.) 9 set the default type. save > save and edit items add a lost item rather than wait, I reindexed it immediately: $ ./misc/migration_tools/rebuild_zebra.pl -b -a -z -v made sure system preference for hidelostitems was Show search Staff, found search OPAC, found toggle the systempreference search staff, found search OPAC, 404 apply patch search OPAC, no results -- facets still show. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11489 --- Comment #12 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 24292 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24292&action=edit Hide facets if there are no results to show (because they are hidden) I believe that the second patch from 11489 will make this patch better. Notice how facets still displayed. This patch will remove the facets. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11489 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24292|0 |1 is patch| | --- Comment #13 from M. Tompsett <mtompset@hotmail.com> --- Comment on attachment 24292 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24292 Hide facets if there are no results to show (because they are hidden) It is a patch, but it isn't mine. It is from Jonathan Druart <jonathan.druart@biblibre.com>. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11489 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24292|0 |1 is obsolete| | --- Comment #14 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 24294 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24294&action=edit [SIGNED OFF] Bug 11489: Show facets only if there is result to display If all results are hidden, the facets are displayed. With this patch, the facets are hidden too. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11489 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10584 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11489 --- Comment #15 from M. Tompsett <mtompset@hotmail.com> --- *** Bug 11432 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11489 Meg <janegcpl@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |janegcpl@gmail.com --- Comment #16 from Meg <janegcpl@gmail.com> --- I have tested the patch and it works! OPAC hides lost/missing items and no longer displays 404 error. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11489 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24291|0 |1 is obsolete| | --- Comment #17 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 24496 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24496&action=edit Bug 11489 - OPAC search results in 404 error when the only search result is supressed If hidelostitems is enabled, and the result of an opac search is a single lost item, then the opac will display a 404 error, rather than a "no results" screen. Test Plan: 1) Catalog a record/item such that it is the only result for some search e.g. Give it the title 'zxcvb' 2) Enable hidelostitems 3) Mark this item as lost 4) Perform an OPAC search that should result in a redirect to this record 5) Notice you a redirected to a 404 error 6) Apply this patch 7) Repeat step 4 8) Note you new get a "No results found!" page instead Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11489 --- Comment #18 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 24497 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24497&action=edit Bug 11489: Show facets only if there is result to display If all results are hidden, the facets are displayed. With this patch, the facets are hidden too. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11489 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24294|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11489 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |katrin.fischer@bsz-bw.de --- Comment #19 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Sorry, but there is a bug: Testing notes: - Record with 1 lost item, result list = 1 - Verified without both patches 404 error page is shown - Verified with 1st patch, no results page is shown - Verified with 2nd patch, the still showing facets are gone - Record with 1 lost item, result list > 1 - Record is hidden from result list, but - result count is wrong - result numbering is wrong > This is an old problem, just noting - Record with 1 lost and 1 available item, result list = 1 - Detail page is shown, only lost item is hidden - Record with 1 ost and 1 available item, result list > 1 - Only available item is shown in result list BUT: FACETS ARE HIDDEN. I think the problem was introduced by the second patch, but since it fixes a problem with the first patch, it also needs to be fixed before either patch can be passed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11489 --- Comment #20 from M. Tompsett <mtompset@hotmail.com> --- Actually, in that last case which causes the problem, the page should be auto-redirecting, because there is only 1 visible result. The problem is there is a [0] hard coded into the one result redirection. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11489 --- Comment #21 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- You misunderstood the test case - I did a search with a real result list, in my case 7 results matching the search term. The record with the lost item shows, but the lost item is not listed, because there is another item available. The only problem there is that the facets are gone. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11489 --- Comment #22 from M. Tompsett <mtompset@hotmail.com> --- I'm still not understanding. You searched for something, and there are 7 results in total. That implies items. How many biblios? Was the lost item the same or different biblio than the available one? And does that mean the other 5 were checked out? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11489 --- Comment #23 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- 7 records one of which was my testing record with 1 item and 1 normal item. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11489 --- Comment #24 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- 1 lost item... and 1 available item. I am talking of a normal result list, where one of the records happens to have a hidden item. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11489 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11489 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24497|0 |1 is obsolete| | --- Comment #25 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 24733 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24733&action=edit Bug 11489: Show facets only if there is result to display If all results are hidden, the facets are displayed. With this patch, the facets are hidden too. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11489 --- Comment #26 from M. Tompsett <mtompset@hotmail.com> --- I changed hits to total because of line 683 in opac/opac-search.pl, and since hits is not set as a parameter to the template. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11489 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #27 from Owen Leonard <oleonard@myacpl.org> --- Both of these patches appear to be signed off, so I'm changing this bug's status. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11489 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff --- Comment #28 from M. Tompsett <mtompset@hotmail.com> --- I'm not sure that is right, because I tweaked the second patch and signed it off. I think the second patch needs proper sign off by someone else before being marked as signed off. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11489 michot <nmichot@voila.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nmichot@voila.fr --- Comment #29 from michot <nmichot@voila.fr> --- We test today on sandbox and everything seems OK : - request with 9 results, one of them with 2 items - we mark one of the 2 items "lost" - we enable prefsystem hidelostitems = "don't show" - we search again on opac - the lost item is hidden, in the list of results and on the biblio view - the facets are displayed We try another request with only one result and do the same process : - we have the message "No results found " and no facets. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11489 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #30 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Patch tested with a sandbox, by Michot <nmichot@voila.fr> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11489 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24496|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11489 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24733|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11489 --- Comment #31 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 26061 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26061&action=edit Bug 11489 - OPAC search results in 404 error when the only search result is supressed If hidelostitems is enabled, and the result of an opac search is a single lost item, then the opac will display a 404 error, rather than a "no results" screen. Test Plan: 1) Catalog a record/item such that it is the only result for some search e.g. Give it the title 'zxcvb' 2) Enable hidelostitems 3) Mark this item as lost 4) Perform an OPAC search that should result in a redirect to this record 5) Notice you a redirected to a 404 error 6) Apply this patch 7) Repeat step 4 8) Note you new get a "No results found!" page instead Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org> Signed-off-by: Michot <nmichot@voila.fr> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11489 --- Comment #32 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 26062 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26062&action=edit Bug 11489: Show facets only if there is result to display If all results are hidden, the facets are displayed. With this patch, the facets are hidden too. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Michot <nmichot@voila.fr> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11489 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|Trivial patch |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11489 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26061|0 |1 is obsolete| | Attachment #26062|0 |1 is obsolete| | --- Comment #33 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 26889 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26889&action=edit [PASSED QA] Bug 11489 - OPAC search results in 404 error when the only search result is supressed If hidelostitems is enabled, and the result of an opac search is a single lost item, then the opac will display a 404 error, rather than a "no results" screen. Test Plan: 1) Catalog a record/item such that it is the only result for some search e.g. Give it the title 'zxcvb' 2) Enable hidelostitems 3) Mark this item as lost 4) Perform an OPAC search that should result in a redirect to this record 5) Notice you a redirected to a 404 error 6) Apply this patch 7) Repeat step 4 8) Note you new get a "No results found!" page instead Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org> Signed-off-by: Michot <nmichot@voila.fr> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11489 --- Comment #34 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 26890 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26890&action=edit [PASSED QA] Bug 11489: Show facets only if there is result to display If all results are hidden, the facets are displayed. With this patch, the facets are hidden too. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Michot <nmichot@voila.fr> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes all tests and QA script. Tested: - Record with 1 lost item, result list = 1 - Verified without both patches 404 error page is shown - Verified with 1st patch, no results page is shown - Verified with 2nd patch, the still showing facets are gone - Record with 1 lost item, result list > 1 - Record is hidden from result list, but - result count is wrong - result numbering is wrong > This is an old problem, just noting - Record with 1 lost and 1 available item, result list = 1 - Detail page is shown, only lost item is hidden - Record with 1 lost and 1 available item, result list > 1 - Only available item is shown in result list Also checked that the lost item shows up with hidelostitems off. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11489 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #35 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Kyle! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11489 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolyn.somers@biblibre.co | |m --- Comment #36 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- Pushed to 3.14.x, will be in 3.14.10 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11489 --- Comment #37 from Kyle M Hall <kyle@bywatersolutions.com> --- Picked for 3.12.15! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org