[Bug 10138] New: Add some authorized values in french installer
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10138 Bug ID: 10138 Summary: Add some authorized values in french installer Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Installation and upgrade (web-based installer) Assignee: koha-bugs@lists.koha-community.org Reporter: mathieu.saby@univ-rennes2.fr CC: gmcharlt@gmail.com The english installer creates and populates some categories in authorized values table (SUGGEST, OPAC_SUG, REPORT_GROUP, LOST, DAMAGED) that are not created by french installer. M. Saby -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10138 mathieu saby <mathieu.saby@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10138 mathieu saby <mathieu.saby@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |mathieu.saby@univ-rennes2.f |ity.org |r -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10138 --- Comment #1 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- Created attachment 17773 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17773&action=edit PATCH] Bug 10138: Add some authorized values in french installer ; small fixes in frameworks This patch adds some categories of values in french installer : - SUGGEST - OPAC_SUG - REPORT_GROUP - LOST - DAMAGED SUGGEST and OPAC_SUG are used by Suggestions module. REPORT_GROUP is used by Reports module. It also adds a new status for "ETAT" (en commande) It creates a 995$2 subfield in french frameworks when it did not exist. It links existing 995$2 subfield with LOST category. It cleans up the list of authorised values installed with "Lecture publique" framework : - some codes are moved in general 1-Obligatoire/authorised_values.sql (SUGGEST, REPORT_GROUP) - some are suppressed, because they are also defined in 1-Obligatoire/authorised_values.sql (langue, COUNTRY, statut) - the code for interting the left ones is changed (I suppress the `id` column) To test : 1. Take a fresh new Koha 2. Install Koha choosing French installer and UNIMARC Lecture publique 3. Check the authorised values are imported 4. Check the cataloguing frameworks are usable : especially 995 $2 field, which must be mapped with LOST values : Perdu, Long retard, Perdu et remboursé, Introuvable you can also check 101$a (language codes), 102$a (country codes) 5. In OPAC, make a suggestion. See if you can select a cause for your suggestion ("Bestseller" or "'L'exemplaire en rayon est endommagé") 6. In staff interface, manage some suggestions. See if you can select a cause for rejection or acceptation ("Bestseller", "Budget insuffisant" etc) 7. In reports, see if you can sort reports according to values of REPORT_GROUP ("Circulation", "Catalogue", "Adhérents" etc) M. Saby -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10138 mathieu saby <mathieu.saby@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10138 I'm just a bot <gitbot@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gitbot@bugs.koha-community. | |org When did the bot| |2012-09-24 last check this| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10138 I'm just a bot <gitbot@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- When did the bot|2012-09-24 00:00:00 |2013-09-24 last check this| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10138 I'm just a bot <gitbot@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- When did the bot|2013-09-24 00:00:00 |2013-10-25 last check this| | --- Comment #2 from I'm just a bot <gitbot@bugs.koha-community.org> --- Patch applied cleanly, go forth and signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10138 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz --- Comment #3 from Chris Cormack <chris@bigballofwax.co.nz> --- Could someone who speaks french please look at this? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10138 --- Comment #4 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- I send a message to french list ;-) Mathieu -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10138 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17773|0 |1 is obsolete| | CC| |jonathan.druart@biblibre.co | |m --- Comment #5 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 23799 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23799&action=edit Bug 10138: Add some authorized values in french installer ; small fixes in frameworks -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10138 --- Comment #6 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 23800 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23800&action=edit Bug 10138: FIX sql errors -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10138 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10138 --- Comment #7 from mathieu saby <mathsabypro@gmail.com> --- Thank you Jonathan. I see a typo to fix in the main patch: "INSERT INTO `authorised_values` ( `category`, `authorised_value`, `lib`) VALUES ('DAMAGED','1','Endommagdé');" Endommadgé-> Endommagé I will make a followup for this line Mathieu -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10138 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 23827 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23827&action=edit [PASSED QA] Bug 10138: Add some authorized values in french installer ; small fixes in frameworks This patch adds some categories of values in french installer : - SUGGEST - OPAC_SUG - REPORT_GROUP - LOST - DAMAGED SUGGEST and OPAC_SUG are used by Suggestions module. REPORT_GROUP is used by Reports module. It also adds a new status for "ETAT" (en commande) It creates a 995$2 subfield in french frameworks when it did not exist. It links existing 995$2 subfield with LOST category. It cleans up the list of authorised values installed with "Lecture publique" framework : - some codes are moved in general 1-Obligatoire/authorised_values.sql (SUGGEST, REPORT_GROUP) - some are suppressed, because they are also defined in 1-Obligatoire/authorised_values.sql (langue, COUNTRY, statut) - the code for interting the left ones is changed (I suppress the `id` column) To test : 1. Take a fresh new Koha 2. Install Koha choosing French installer and UNIMARC Lecture publique 3. Check the authorised values are imported 4. Check the cataloguing frameworks are usable : especially 995 $2 field, which must be mapped with LOST values : Perdu, Long retard, Perdu et remboursé, Introuvable you can also check 101$a (language codes), 102$a (country codes) 5. In OPAC, make a suggestion. See if you can select a cause for your suggestion ("Bestseller" or "'L'exemplaire en rayon est endommagé") 6. In staff interface, manage some suggestions. See if you can select a cause for rejection or acceptation ("Bestseller", "Budget insuffisant" etc) 7. In reports, see if you can sort reports according to values of REPORT_GROUP ("Circulation", "Catalogue", "Adhérents" etc) Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Comments on second patch. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10138 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 23828 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23828&action=edit [PASSED QA] Bug 10138: FIX sql errors There were 2 INSERT in error. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> I have gone ahead and fixed the typo pointed out by Mathieu: Endommadgé-> Endommagé Sample files install without problems, tests look good. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10138 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |katrin.fischer@bsz-bw.de Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10138 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23800|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10138 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23799|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10138 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #10 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Mathieu! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10138 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolyn.somers@biblibre.co | |m --- Comment #11 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- Pushed to 3.14.x, will be in 3.14.10 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10138 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com --- Comment #12 from Kyle M Hall <kyle@bywatersolutions.com> --- Picked for 3.12.15! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org