[Bug 29718] New: DateTime - our 'iso' is not ISO 8601
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29718 Bug ID: 29718 Summary: DateTime - our 'iso' is not ISO 8601 Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: In Discussion Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: jonathan.druart+koha@gmail.com QA Contact: testopia@bugs.koha-community.org CC: martin.renvoize@ptfs-europe.com, tomascohen@gmail.com In some scripts we are doing unnecessary conversion from string to DT and vice-versa, sometimes several times. For instance, see bug 29711. We have epoch => DT => string => sending to template in 'iso' YYYY-MM-DD HH:MM => DT => string. This is because the stringified version of DT (the real ISO 8601 YYYY-MM-DDTHH:MM:SS) is not supported by our dt_from_string method. There are (at least) two options: * Use DateTime::Format::Strptime In dt_from_string: my $formatter = DateTime::Format::Strptime->new(pattern => '%Y-%m-%d %H:%M:%S'); return DateTime->now( time_zone => $tz, formatter => $formatter, ) unless $date_string; Then later $dt_params{formatter} = $formatter; But that's an overhead for all dt_from_string calls. * add "T?" to $time_re, easy and efficient. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29718 --- Comment #1 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 128631 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128631&action=edit Bug 29718: Support ISO8601 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29718 --- Comment #2 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Note that this patch fixes bug 29711. We would also remove all the extra output_pref calls from pl scripts. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29718 --- Comment #3 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Martin, Tomas, what do you think? I knew we wanted to be stricter, but here I have the feeling that this patch is correct. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29718 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29711 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29718 --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Right.. I agree with your patch.. mostly. In the RFC3339 regex we actually do '([Tt\s])'.. Whilst I think ISO was slightly more strict.. i.e 'T' now and '\s' before (So I agree to allowing for both).. should we also support lower case 't' ? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29718 --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Also.. being slightly picky.. I'd update the comment lines that explain the regex's.. # iso or sql format are yyyy-dd-mm[ hh:mm:ss]" and # Add the faculative time part [hh:mm[:ss]] -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29718 --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Also, interestingly.. I note that for ISO I don't believe 'am/pm' is actually allowed.. all times should be 24 hour. That's an oversight I hadn't spotted before.. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29718 --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Also.. to properly adhere to ISO we should also optionally support timezone (with it defaulting to "local" when one isn't passed). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29718 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128631|0 |1 is obsolete| | --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 128653 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128653&action=edit Bug 29718: Support ISO8601 Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29718 --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 128654 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128654&action=edit Bug 29718: (QA follow-up) Make 'T' check case insensative Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29718 --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 128658 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128658&action=edit Bug 29718: (QA follow-up) Add optional offset handling ISO8601 optionally supports timezone offsets. If a timezone is ommited, we should assume 'local' time (Which in our case is instance configuration time), if we are passed 'Z' or 'z' we should set timezone to 'UTC', otherwise we should set the timezone to the passed offset. Whilst ISO8601 does NOT support AM/PM, I left that intact as it has historical relevance in Koha and we share the ISO parsing with SQL type parsing amongth other things. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29718 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29718 --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Clearly, we still need to add some additional unit tests to prove the new support. Whilst testing I took the following set of strings to test the regex's against: 2020-12-09T16:09:53+00:00 2020-12-09 16:09:53+00:00 2020-12-09T 16:09:53+00:00 2020-12-09t16:09:53+00:00 2020-12-0916:09:53+00:00 2020-12-09 16:09:53+00:00 2020-12-09 16:09:53Z 2020-12-09 04:09:53 pm 2020-12-09 04:09:53 am 2020-12-09 04:09:53 2020-12-09 04:09:53am+00:00 # Fails as it should 2020-12-09 04:09:53+00:00am # Fails as it should -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29718 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29403 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29403 [Bug 29403] dt_from_string should fail if passed an rfc3339 formatted string when 'iso' is selected as dateformat -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29718 --- Comment #12 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 128840 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128840&action=edit Bug 29718: Unit tests -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29718 --- Comment #13 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Tests are failing for me t/DateUtils.t .. 20/79 # Failed test 'dt_from_string with no offset assumes "local"' # at t/DateUtils.t line 160. # got: '1325462399' # expected: '1325455199' # Failed test 'dt_from_string with UTC prescribed as Z' # at t/DateUtils.t line 164. # got: '1325462399' # expected: '1325455199' # Looks like you failed 2 tests of 6. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29718 --- Comment #14 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Interesting.. on k-t-d I can't replicate your failures..? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29718 --- Comment #15 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- humm.. my local branch misses the unit tests.. wonder why.. I can replicate now I've grabbed the patches here. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29718 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29718 --- Comment #16 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Martin Renvoize from comment #15)
humm.. my local branch misses the unit tests.. wonder why..
I can replicate now I've grabbed the patches here.
I am still getting the same failure, patches from bug 29403 and bug 29718 applied. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29718 --- Comment #17 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Shouldn't we mock the timezone here? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29718 --- Comment #18 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 129372 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129372&action=edit Bug 29718: Mock the timezone -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29718 --- Comment #19 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- You are indeed right, we needed to mock the timezone.. what I was still trying to wrap my head around was a) what timezone we should pick and b) if it should affect all the existing tests in any way and what the actual times should end up as for the tests.. Looks like you've given that some thought :).. I'll take a look and confirm now. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29718 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128653|0 |1 is obsolete| | --- Comment #20 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 129385 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129385&action=edit Bug 29718: Support ISO8601 Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29718 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128654|0 |1 is obsolete| | --- Comment #21 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 129386 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129386&action=edit Bug 29718: (QA follow-up) Make 'T' check case insensative Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29718 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128658|0 |1 is obsolete| | --- Comment #22 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 129387 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129387&action=edit Bug 29718: (QA follow-up) Add optional offset handling ISO8601 optionally supports timezone offsets. If a timezone is ommited, we should assume 'local' time (Which in our case is instance configuration time), if we are passed 'Z' or 'z' we should set timezone to 'UTC', otherwise we should set the timezone to the passed offset. Whilst ISO8601 does NOT support AM/PM, I left that intact as it has historical relevance in Koha and we share the ISO parsing with SQL type parsing amongth other things. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29718 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128840|0 |1 is obsolete| | --- Comment #23 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 129388 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129388&action=edit Bug 29718: Unit tests Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29718 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129372|0 |1 is obsolete| | --- Comment #24 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 129389 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129389&action=edit Bug 29718: Mock the timezone Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29718 --- Comment #25 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 129390 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129390&action=edit Bug 29718: (QA follow-up) Remove duplicate test I'd inadvertantly introduced the exact same test twice! This patch removes the duplicate and annotates the test to clarify the timezone handling expectations. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29718 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #26 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I've tested Jonathans follow-up and added another of my own to annotate the tests and remove a duplicate. Setting to Signed off to get QA attention as I think we're ready for a last technical eye here now. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29718 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | CC| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29718 --- Comment #27 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- QA: Looking here -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29718 --- Comment #28 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Martin Renvoize from comment #5)
Also.. being slightly picky.. I'd update the comment lines that explain the regex's..
# iso or sql format are yyyy-dd-mm[ hh:mm:ss]"
and
# Add the faculative time part [hh:mm[:ss]]
Even more picky. What about spelling? Facultative? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29718 --- Comment #29 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (?<utc>[Zz]$)|((?<offset>[\+|\-])(?<hours>[01][0-9]|2[0-3]):(?<minutes>[0-5][0-9])) What slightly confuses is that we use the names hours and minutes here while we also use hour and minute. It is not completely clear that the hours and minutes belong to the tz offset. Better name? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29718 --- Comment #30 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- The UTC offset is appended to the time in the same way that 'Z' was above, in the form ±[hh]:[mm], ±[hh][mm], or ±[hh]. So we should be able to specify +02, +0200 as well. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29718 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29718 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129385|0 |1 is obsolete| | --- Comment #31 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 129465 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129465&action=edit Bug 29718: Support ISO8601 Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29718 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129386|0 |1 is obsolete| | --- Comment #32 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 129466 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129466&action=edit Bug 29718: (QA follow-up) Make 'T' check case insensative Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29718 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129387|0 |1 is obsolete| | --- Comment #33 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 129467 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129467&action=edit Bug 29718: (QA follow-up) Add optional offset handling ISO8601 optionally supports timezone offsets. If a timezone is ommited, we should assume 'local' time (Which in our case is instance configuration time), if we are passed 'Z' or 'z' we should set timezone to 'UTC', otherwise we should set the timezone to the passed offset. Whilst ISO8601 does NOT support AM/PM, I left that intact as it has historical relevance in Koha and we share the ISO parsing with SQL type parsing amongth other things. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29718 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129388|0 |1 is obsolete| | --- Comment #34 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 129468 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129468&action=edit Bug 29718: Unit tests Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29718 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129389|0 |1 is obsolete| | --- Comment #35 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 129469 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129469&action=edit Bug 29718: Mock the timezone Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29718 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129390|0 |1 is obsolete| | --- Comment #36 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 129470 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129470&action=edit Bug 29718: (QA follow-up) Remove duplicate test I'd inadvertantly introduced the exact same test twice! This patch removes the duplicate and annotates the test to clarify the timezone handling expectations. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29718 --- Comment #37 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 129471 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129471&action=edit Bug 29718: (QA follow-up) ISO 8601 allows +02 and +0200 The UTC offset is appended to the time in the form: ±[hh]:[mm], ±[hh][mm], or ±[hh] Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29718 --- Comment #38 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice call regards +02 vs +02:00 and +0200.. I hadn't spotted that.. and.. it turns out I've been spelling facultative wrong my entire life.. lol. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29718 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #39 from David Cook <dcook@prosentient.com.au> --- (In reply to Martin Renvoize from comment #38)
it turns out I've been spelling facultative wrong my entire life.. lol.
I had the same realization a few months ago haha. I never say it in English (I just say optional) but in French I would say/spell it as faculative too haha. Do people use the word "facultative" much in the UK? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29718 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29718 --- Comment #40 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29718 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |kyle@bywatersolutions.com Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29718 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |30030 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30030 [Bug 30030] Test t/db_dependent/Koha/Patrons.t is_going_to_expire fails on U18 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29718 --- Comment #41 from Victor Grousset/tuxayo <victor@tuxayo.net> --- This causes a failure on Ubuntu 18.04: bug 30030 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29718 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29718 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net --- Comment #42 from Victor Grousset/tuxayo <victor@tuxayo.net> --- To have the CI still be meaningful for Ubuntu 18.04 (until 2023-04-26) for Koha 22.05 and in the future 22.11, should these patch be reverted until then? (assuming it's possible to revert) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29718 --- Comment #43 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Victor Grousset/tuxayo from comment #42)
To have the CI still be meaningful for Ubuntu 18.04 (until 2023-04-26) for Koha 22.05 and in the future 22.11, should these patch be reverted until then? (assuming it's possible to revert)
We need to backport a newer DateTime library for 18.04. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29718 --- Comment #44 from Mason James <mtj@kohaaloha.com> --- (In reply to Tomás Cohen Arazi from comment #43)
(In reply to Victor Grousset/tuxayo from comment #42)
To have the CI still be meaningful for Ubuntu 18.04 (until 2023-04-26) for Koha 22.05 and in the future 22.11, should these patch be reverted until then? (assuming it's possible to revert)
We need to backport a newer DateTime library for 18.04.
i have had some success with updating just the 'libdatetime-timezone-perl' pkg, for u18 my theory is that a newer olsen database is needed for u18 - its been upgraded from 2018d to 2022a (ps: i cant explain why u20 works with only a 2019c database??) http://ftp.iana.org/tz/releases/ i did the update some days ago, which fixed the broken tests for master and stable https://jenkins.koha-community.org/view/master/job/Koha_Master_U18/1510/ https://jenkins.koha-community.org/view/22.05/job/Koha_22.05_U18/44/ i'll aim to update the prod repo soon -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29718 --- Comment #45 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Congratulation Mason :D Even if there is still mystery we will be able to close bug 30030 when it hit the prod repo, right? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29718 --- Comment #46 from Mason James <mtj@kohaaloha.com> ---
my theory is that a newer olsen database is needed for u18 - its been upgraded from 2018d to 2022a (ps: i cant explain why u20 works with only a 2019c database??)
aah, the 2019b database has fixes for Brazil http://changelogs.ubuntu.com/changelogs/pool/universe/libd/libdatetime-timez... ------------------------------------------------------ libdatetime-timezone-perl (1:2.36-1+2019b) unstable; urgency=medium * Import upstream version 2.36. This release is based on version 2019b of the Olson database. It includes contemporary changes for Brazil and Palestine. <<< ------------------------------------------------------ updating u18 to libdatetime-timezone-perl_2.23-1+2022a_all.deb fixes the following errors 'Invalid local time for date in time zone: America/Campo_Grande' 'Invalid local time for date in time zone: America/Cuiaba' 'Invalid local time for date in time zone: America/Sao_Paulo' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29718 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|FIXED |--- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23079 Status|RESOLVED |REOPENED --- Comment #47 from Mason James <mtj@kohaaloha.com> --- reopened, until confirmed fixed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29718 --- Comment #48 from Mason James <mtj@kohaaloha.com> --- (In reply to Victor Grousset/tuxayo from comment #45)
Congratulation Mason :D
Even if there is still mystery we will be able to close bug 30030 when it hit the prod repo, right?
yes, correct :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29718 --- Comment #49 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- What is this bug status? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29718 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|REOPENED |RESOLVED --- Comment #50 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Tomás Cohen Arazi (tcohen) from comment #49)
What is this bug status?
Pushed. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org