[Bug 22901] New: in items search authorised values select disappears on conditional change
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22901 Bug ID: 22901 Summary: in items search authorised values select disappears on conditional change Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Searching Assignee: koha-bugs@lists.koha-community.org Reporter: fridolin.somers@biblibre.com QA Contact: testopia@bugs.koha-community.org Target Milestone: --- in items search, when there is a custom field with authorised values : when changing the conditional select AND/OR then the authorised values select disappears. This behaviour is like when the search field is changed. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22901 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |fridolin.somers@biblibre.co |ity.org |m Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22901 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22901 --- Comment #1 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Created attachment 89726 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89726&action=edit Bug 22901 - in items search fix search field change listerning In items search, when there is a custom field with authorised values : when changing the conditional select AND/OR then the authorised values select disappears. This behaviour is like when the search field is changed. The bug is that JavaScript code meaning search field change listens on all selects instead of only search field select. Test plan : 1) Define a custom items search field with authorised values 2) Go to items search 3) Click on 'New field' 4) On second line, select custom field 5) The authorised values select appears 6) Select 'AND' in conditional select 7) Without patch the authorised values select disappears, with patch nothing changes 8) On second line, select a non-custom field 9) The authorised values select is replaced by a text field 10) On second line, select custom field 11) The authorised values select appears -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22901 Maryse Simard <maryse.simard@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89726|0 |1 is obsolete| | --- Comment #2 from Maryse Simard <maryse.simard@inlibro.com> --- Created attachment 89920 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89920&action=edit Bug 22901 - in items search fix search field change listerning In items search, when there is a custom field with authorised values : when changing the conditional select AND/OR then the authorised values select disappears. This behaviour is like when the search field is changed. The bug is that JavaScript code meaning search field change listens on all selects instead of only search field select. Test plan : 1) Define a custom items search field with authorised values 2) Go to items search 3) Click on 'New field' 4) On second line, select custom field 5) The authorised values select appears 6) Select 'AND' in conditional select 7) Without patch the authorised values select disappears, with patch nothing changes 8) On second line, select a non-custom field 9) The authorised values select is replaced by a text field 10) On second line, select custom field 11) The authorised values select appears Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22901 Maryse Simard <maryse.simard@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |maryse.simard@inlibro.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22901 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Summary|in items search authorised |On item search authorised |values select disappears on |values select disappears on |conditional change |conditional change -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22901 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22901 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 90136 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90136&action=edit Bug 22901: On items search fix search field change listening In items search, when there is a custom field with authorised values : when changing the conditional select AND/OR then the authorised values select disappears. This behaviour is like when the search field is changed. The bug is that JavaScript code meaning search field change listens on all selects instead of only search field select. Test plan : 1) Define a custom items search field with authorised values 2) Go to items search 3) Click on 'New field' 4) On second line, select custom field 5) The authorised values select appears 6) Select 'AND' in conditional select 7) Without patch the authorised values select disappears, with patch nothing changes 8) On second line, select a non-custom field 9) The authorised values select is replaced by a text field 10) On second line, select custom field 11) The authorised values select appears Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22901 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Attachment #89920|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22901 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22901 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |martin.renvoize@ptfs-europe | |.com Version(s)| |19.05.00, 18.11.06 released in| | --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pushed to 18.11.x for 18.11.06 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org