[Bug 22586] New: IntranetReportsHomeHTML no longer renders as HTML on reports-home.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22586 Bug ID: 22586 Summary: IntranetReportsHomeHTML no longer renders as HTML on reports-home.pl Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: lucas@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org Target Milestone: --- As of 18.11 the IntranetReportsHomeHTML syspref no longer renders HTML on report-home.pl. I think this is being filtered wrong in the template. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22586 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22586 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13618 CC| |nick@bywatersolutions.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 [Bug 13618] Add additional template filter methods and a filter presence test to Koha -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22586 --- Comment #1 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 87095 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87095&action=edit Bug 22586: fix IntranetReportsHomeHTML filter -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22586 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22586 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87095|0 |1 is obsolete| | --- Comment #2 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 87096 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87096&action=edit Bug 22586: IntranetReportsHomeHTML no longer renders as HTML on reports-home.pl As of 18.11 the IntranetReportsHomeHTML syspref no longer renders HTML on report-home.pl. I think this is being filtered wrong in the template. Test Plan: 1) Edit IntranetReportsHomeHTML, set to "<p>Test</p>" 2) View a report, note that you see the html p tags are displayed litterly 3) Apply this patch 4) Reload the page 5) Note the p tags are rendered as html -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22586 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87096|0 |1 is obsolete| | --- Comment #3 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 87116 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87116&action=edit Bug 22586: IntranetReportsHomeHTML no longer renders as HTML on reports-home.pl As of 18.11 the IntranetReportsHomeHTML syspref no longer renders HTML on report-home.pl. I think this is being filtered wrong in the template. Test Plan: 1) Edit IntranetReportsHomeHTML, set to "<p>Test</p>" 2) View a report, note that you see the html p tags are displayed litterly 3) Apply this patch 4) Reload the page 5) Note the p tags are rendered as html Signed-off-by: George Williams <george@nekls.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22586 George Williams (NEKLS) <george@nekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |george@nekls.org --- Comment #4 from George Williams (NEKLS) <george@nekls.org> --- Tested successfully on ByWater sandboxes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22586 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22586 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87116|0 |1 is obsolete| | --- Comment #5 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 87169 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87169&action=edit Bug 22586: IntranetReportsHomeHTML no longer renders as HTML on reports-home.pl As of 18.11 the IntranetReportsHomeHTML syspref no longer renders HTML on report-home.pl. I think this is being filtered wrong in the template. Test Plan: 1) Edit IntranetReportsHomeHTML, set to "<p>Test</p>" 2) View a report, note that you see the html p tags are displayed litterly 3) Apply this patch 4) Reload the page 5) Note the p tags are rendered as html Signed-off-by: George Williams <george@nekls.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22586 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Version|18.11 |master QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | CC| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22586 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #6 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22586 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Pushed to Master |Pushed to Stable --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pushed to 18.11.x for 18.11.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22586 --- Comment #8 from Lucas Gass <lucas@bywatersolutions.com> --- not backporting this to the 18.05.x series -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22586 Lisette Scheer <lisetteslatah@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22586 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Stable |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org