[Bug 16807] New: Frameworks unordered in dropdown when adding/editing a biblio
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16807 Bug ID: 16807 Summary: Frameworks unordered in dropdown when adding/editing a biblio Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: gmcharlt@gmail.com Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl addbiblio.pl should use GetFrameWorksLoop instead of getframeworks -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16807 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16807 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 52799 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52799&action=edit Bug 16807 - Frameworks unordered in dropdown when adding/editing a biblio To test: Start to add or edit a biblio Open the dropdown to change framework Notice the order Refresh the page - notice the order changes Apply patch Order is alphabetical Refresh the page Order does not change -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16807 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |nick@bywatersolutions.com Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16807 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52799|0 |1 is obsolete| | --- Comment #2 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Created attachment 52808 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52808&action=edit [SIGNED-OFF]Bug 16807: Frameworks unordered in dropdown when adding/editing a biblio To test: Start to add or edit a biblio Open the dropdown to change framework Notice the order Refresh the page - notice the order changes Apply patch Order is alphabetical Refresh the page Order does not change Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as described -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16807 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |hector.hecaxmmx@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16807 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I removes GetFrameWorksLoop in bug 15801 (needs QA), could you please avoid to introduce a new call to it? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16807 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- s/removes/removed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16807 --- Comment #5 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 52828 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52828&action=edit Bug 16807 - Use Koha::BiblioFrameworks instead of GetFrameWorkLoop Refactor code to use work from 14889 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16807 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16807 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52808|0 |1 is obsolete| | Attachment #52828|0 |1 is obsolete| | --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 52833 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52833&action=edit Bug 16807: Frameworks unordered in dropdown when adding/editing a biblio To test: Start to add or edit a biblio Open the dropdown to change framework Notice the order Refresh the page - notice the order changes Apply patch Order is alphabetical Refresh the page Order does not change Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as described Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16807 --- Comment #7 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 52834 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52834&action=edit Bug 16807 - Use Koha::BiblioFrameworks instead of GetFrameWorkLoop Refactor code to use work from 14889 Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16807 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #8 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 16.11, thanks Nick! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16807 Barton Chittenden <barton@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barton@bywatersolutions.com --- Comment #9 from Barton Chittenden <barton@bywatersolutions.com> --- Can this be back-ported? It looks like a fairly small patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16807 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |frederic@tamil.fr --- Comment #10 from Frédéric Demians <frederic@tamil.fr> --- Pushed in 16.05. Will be in 16.05.02. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16807 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com Depends on| |14889 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14889 [Bug 14889] Move the framework related code to Koha::BiblioFramework[s] -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org