[Bug 8202] New: Add authorities to export tool
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8202 Priority: P5 - low Change sponsored?: --- Bug ID: 8202 Assignee: jcamins@cpbibliography.com Summary: Add authorities to export tool Severity: enhancement Classification: Unclassified OS: All Reporter: jcamins@cpbibliography.com Hardware: All Status: ASSIGNED Version: master Component: Tools Product: Koha Right now it is not possible to export authorities from the staff client. It should be possible to export authorities using the export tool. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8202 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8202 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |8203 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8202 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |8212 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8202 --- Comment #1 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Created attachment 10305 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10305&action=edit Bug 8202: Add authority export to tools/export.pl Adds a separate tab on tools/export.pl for exporting authority records. To test: 1. Try exporting authority records from the "Export data" tool -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8202 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8202 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10305|0 |1 is obsolete| | --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 10311 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10311&action=edit [SIGNED-OFF] Bug 8202: Add authority export to tools/export.pl Adds a separate tab on tools/export.pl for exporting authority records. To test: 1. Try exporting authority records from the "Export data" tool Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Tried different exports and everything worked nicely: - removing fields from export (example: 942) - limiting to one authority type - changing the given file name - exporting as MARC or XML -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8202 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8202 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |8268 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8202 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m Depends on| |7986 --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- Arf, A patch for Bug 7986 introduces a lot of modifications for the same file tools/export.pl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8202 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Jonathan, I know it's annoying, but as this patch is already signed off, I don't think the other should block it. This way 2 patches will have to be reworked. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8202 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |7986 Depends on|7986 | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8202 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #5 from Jonathan Druart <jonathan.druart@biblibre.com> --- QA comments: Hi Jared, Your modifications seem good and they are close to mine (for export.pl). About your patch, I think you can repropose it modifying the indentation of export.tt (ex. + <ol><li> + </li></ol> +[% ELSE %] +<div id="exporttype" class="toptabs"> +<ul> ) I agree with you, I quibble... However, more important, I found a bug in this script while testing. I can't exclude from export some fields, as 500$3 for example. The regexp to split field and subfield is /^(\d*)(\w)?$/; This is not what we want. And, the subfield's deletion: if( $subfield ) { $record->field($field)->delete_subfields($subfield); } only delete in the first field. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8202 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #6 from Jonathan Druart <jonathan.druart@biblibre.com> --- Sorry, you didn't introduce these bugs. And I can't failed QA only for indentation, I switch back to signed off. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8202 --- Comment #7 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- (In reply to comment #5)
QA comments:
Hi Jared,
Your modifications seem good and they are close to mine (for export.pl). About your patch, I think you can repropose it modifying the indentation of export.tt (ex. + <ol><li>
+ </li></ol>
+[% ELSE %]
+<div id="exporttype" class="toptabs"> +<ul> )
I agree with you, I quibble...
I would be happy to submit a follow-up fixing indentation. I was very tempted to reindent export.tt, actually, but section 1.3 in the coding guidelines says don't refactor needlessly, and don't spend time changing someone else's style to yours. :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8202 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10311|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 10607 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10607&action=edit [SIGNED-OFF] Bug 8202: Add authority export to tools/export.pl Rebased patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8202 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #9 from Jonathan Druart <jonathan.druart@biblibre.com> --- Marking as Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8202 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain@biblibre.com Version|master |rel_3_10 --- Comment #10 from Paul Poulain <paul.poulain@biblibre.com> --- (In reply to comment #7)
I would be happy to submit a follow-up fixing indentation. I was very tempted to reindent export.tt, actually, but section 1.3 in the coding guidelines says don't refactor needlessly, and don't spend time changing someone else's style to yours. :)
We also have decided to use the default perltidy formatting, so, this rule "wins" against the "don't spend time..." Anyway, there's something wronger than this : you test the MARCflavour, and, if it's UNIMARC you send do ->as_xml('unimarc') When it's an authority, you must do ->as_xml('UNIMARCAUTH') The 100 -coded- field in UNIMARCAUTH has a different size than UNIMARC (biblio) So you get a nasty: Unsupported UNIMARC character encoding [] for XML output for UNIMARC; 100$a -> 20091001afrey50 ba0 at /usr/share/perl5/MARC/File/XML.pm line 505. (trying to decode a 100 "biblio", but it's an auth, so considered wrong size) yes, that's silly, but UNIMARC is silly ;-) Please signoff the follow-up and i'll push your patch with my (tiny) follow-up -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8202 --- Comment #11 from Paul Poulain <paul.poulain@biblibre.com> --- Created attachment 10629 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10629&action=edit Bug 8202 follow-up UNIMARC authority support -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8202 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10629|0 |1 is obsolete| | --- Comment #12 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Created attachment 10630 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10630&action=edit Bug 8202 follow-up UNIMARC authority support Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8202 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8202 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #13 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This feature is available in Master. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org