http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8202 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain@biblibre.com Version|master |rel_3_10 --- Comment #10 from Paul Poulain <paul.poulain@biblibre.com> --- (In reply to comment #7)
I would be happy to submit a follow-up fixing indentation. I was very tempted to reindent export.tt, actually, but section 1.3 in the coding guidelines says don't refactor needlessly, and don't spend time changing someone else's style to yours. :)
We also have decided to use the default perltidy formatting, so, this rule "wins" against the "don't spend time..." Anyway, there's something wronger than this : you test the MARCflavour, and, if it's UNIMARC you send do ->as_xml('unimarc') When it's an authority, you must do ->as_xml('UNIMARCAUTH') The 100 -coded- field in UNIMARCAUTH has a different size than UNIMARC (biblio) So you get a nasty: Unsupported UNIMARC character encoding [] for XML output for UNIMARC; 100$a -> 20091001afrey50 ba0 at /usr/share/perl5/MARC/File/XML.pm line 505. (trying to decode a 100 "biblio", but it's an auth, so considered wrong size) yes, that's silly, but UNIMARC is silly ;-) Please signoff the follow-up and i'll push your patch with my (tiny) follow-up -- You are receiving this mail because: You are watching all bug changes.