https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42500 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42500 --- Comment #1 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 201437 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201437&action=edit Bug 42500: Add filter_by_pending to Koha::Acquisition::Orders The hold ratios report needs to know how many copies are still on order for a biblio. This adds a filter_by_pending method to Koha::Acquisition::Orders returning the orders that have not been cancelled and still have copies left to receive ( quantityreceived less than quantity ), matching the criteria the old CountPendingOrdersByBiblionumber used. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42500 --- Comment #3 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 201439 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201439&action=edit Bug 42500: Add Koha::Holds->hold_ratios method This moves the hold ratios aggregation out of the REST controller into a Koha::Holds->hold_ratios class method so it can be unit tested directly. The ratio is computed in SQL and filtered with a HAVING clause, so the database returns only the qualifying biblios and the report can be paginated. The method returns the holds and items counts, the ratio, the number of copies to buy and the library, item type and authorised value codes of the biblio's items, along with the total number of qualifying biblios. Resolving the codes to names is left to the caller. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42500 --- Comment #5 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 201441 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201441&action=edit Bug 42500: Add REST API for hold ratios The hold ratios page ( reserveratios.pl ) builds its entire result set in Perl and renders every matching row, which is a pain point for larger systems with many holds. This patch adds a /holds/ratios REST endpoint so the page can fetch the data and paginate it. The hold ratio is computed in SQL and the ratio threshold is applied as a HAVING clause, so the database returns only the biblios that meet the ratio and the endpoint returns one page at a time instead of the whole set. Each row carries the computed holds_count, items_count, hold_ratio, copies_to_buy and the count of copies still on order, along with the home and holding libraries, locations, item types, collections and call numbers of the biblio's items. The old page adjusted the item count when it was reached from an acquisitions basket that creates items on receiving. That adjustment is dropped here; the pending order count is still returned separately. Test Plan: 1) Apply this patch 2) Restart all the things! 3) Place several holds on a biblio that has fewer items than holds 4) curl the endpoint as a librarian with circulate permission: curl -s -u koha:koha "http://localhost:8081/api/v1/holds/ratios?ratio=1" | json_pp 5) Note the biblio is returned with its hold ratio, items needed and item details! 6) Try ratio=99, note the biblio is filtered out! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42500 --- Comment #7 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 201443 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201443&action=edit Bug 42500: Add unit tests REST API endpoint list_ratios Patch from commit 17836ad -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42500 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|42643 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42643 [Bug 42643] [OMNIBUS] Assorted performance and stability work -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42500 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|kyle@bywatersolutions.com |Laura.escamilla@bywatersolu | |tions.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42500 --- Comment #9 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 205380 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205380&action=edit Bug 42500: Restore hold ratios report behavior -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42500 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42500 --- Comment #10 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 205653 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205653&action=edit Bug 42500: Add filter_by_pending to Koha::Acquisition::Orders The hold ratios report needs to know how many copies are still on order for a biblio. This adds a filter_by_pending method to Koha::Acquisition::Orders returning the orders that have not been cancelled and still have copies left to receive ( quantityreceived less than quantity ), matching the criteria the old CountPendingOrdersByBiblionumber used. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42500 --- Comment #12 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 205655 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205655&action=edit Bug 42500: Add Koha::Holds->hold_ratios method This moves the hold ratios aggregation out of the REST controller into a Koha::Holds->hold_ratios class method so it can be unit tested directly. The ratio is computed in SQL and filtered with a HAVING clause, so the database returns only the qualifying biblios and the report can be paginated. The method returns the holds and items counts, the ratio, the number of copies to buy and the library, item type and authorised value codes of the biblio's items, along with the total number of qualifying biblios. Resolving the codes to names is left to the caller. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42500 --- Comment #14 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 205657 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205657&action=edit Bug 42500: Add REST API for hold ratios The hold ratios page ( reserveratios.pl ) builds its entire result set in Perl and renders every matching row, which is a pain point for larger systems with many holds. This patch adds a /holds/ratios REST endpoint so the page can fetch the data and paginate it. The hold ratio is computed in SQL and the ratio threshold is applied as a HAVING clause, so the database returns only the biblios that meet the ratio and the endpoint returns one page at a time instead of the whole set. Each row carries the computed holds_count, items_count, hold_ratio, copies_to_buy and the count of copies still on order, along with the home and holding libraries, locations, item types, collections and call numbers of the biblio's items. The old page adjusted the item count when it was reached from an acquisitions basket that creates items on receiving. That adjustment is dropped here; the pending order count is still returned separately. Test Plan: 1) Apply this patch 2) Restart all the things! 3) Place several holds on a biblio that has fewer items than holds 4) curl the endpoint as a librarian with circulate permission: curl -s -u koha:koha "http://localhost:8081/api/v1/holds/ratios?ratio=1" | json_pp 5) Note the biblio is returned with its hold ratio, items needed and item details! 6) Try ratio=99, note the biblio is filtered out! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42500 --- Comment #16 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 205659 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205659&action=edit Bug 42500: Add unit tests REST API endpoint list_ratios -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42500 --- Comment #18 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Rebased the full Bug 42500 patch series onto current main and regenerated all patches. The previous series could conflict when applying against current main, particularly in t/db_dependent/Koha/Holds.t and reserveratios.tt. The refreshed 8-patch series applies cleanly from current main and includes the Failed QA follow-up fixes for date persistence, global search, and sorting. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42500 --- Comment #19 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- In order to test these patches, I've worked to confirm the current functionality, which led me to file Bug 43541, highlighting inconsistencies in how this report counts unreceived orders without attached items. With these patches, the hold ratios report *never* includes unreceived orders without attached items (rather than counting them sometimes, as the current code does), introducing a new and different issue. I don't think it makes sense to replicate the current faulty behavior in these patches, or to patch Bug 43541 on the current code before updating these patches to match the updated behavior. I suggest we simply update these patches to match the ideal behavior I've suggested on Bug 43541: - Allow un-received orders without attached items to be included in the hold ratio items count when one is accessing the hold ratios via circulation - Allow un-received orders without attached items to be included in the hold ratio items count when one is accessing the hold ratios via acquistions regardless of the create_items value of the basket to which one is adding orders - In either circulation or acquisitions, only include un-received orders without attached items if the "Include ordered" checkbox has been selected - Never count un-received orders with attached items (count the item instead) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42500 --- Comment #20 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Follow-up patches addressing QA feedback from Bug 43541. Itemless pending orders are now counted when "Include ordered" is selected, while orders with attached items are not double-counted. Also fixes the acquisition orders test plan. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42500 --- Comment #22 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 206823 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206823&action=edit Bug 42500: Fix acquisition orders test plan -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42500 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |zoho.roboto@bywatersolution | |s.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42500 --- Comment #24 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Updated test plan: Test Plan: 1) Apply this patch 2) Restart all the things! 3) Place several holds on a biblio with fewer items than holds 4) Go to Circulation -> Hold ratios 5) Note the biblio is listed with its hold ratio, libraries, item types and items needed! 6) Change the hold ratio filter and the dates, click Go 7) Note the list updates to match! 8) Sort by Holds, Items, Hold ratio and Items needed 9) Note the sorting works across pages! 10) Suspend some holds. Confirm suspended holds are not counted unless "Include suspended" is checked 11) Edit an item to set the not for loan value to a negative number. Confirm the item is not counted unless "Include ordered" is checked 12) Create a basket set to create items when placing an order. Place an order, make sure the item that is created has its not for loan value set to a negative value. Confirm the order and item are not counted unless "Include ordered" is checked. Confirm the item and order and never both counted. 13) Create a basket set to create items when receiving an order. Place an order. Confirm the order is not counted unless "Include ordered" is checked. 14) Create a basket set to create items when cataloging. Place an order. Confirm the order is not counted unless "Include ordered" is checked. 15) Reach the page by adding to an acquisitions basket with the "From titles with highest hold ratios" option 16) Confirm items/orders are counted consistently regardless of the "Create items when" value of your basket 17) Note the "N to order" button links into a new order! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42500 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42500 --- Comment #25 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 206933 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206933&action=edit Bug 42500: Add filter_by_pending to Koha::Acquisition::Orders The hold ratios report needs to know how many copies are still on order for a biblio. This adds a filter_by_pending method to Koha::Acquisition::Orders returning the orders that have not been cancelled and still have copies left to receive ( quantityreceived less than quantity ), matching the criteria the old CountPendingOrdersByBiblionumber used. Signed-off-by: Kristi Krueger <KKRUEGER@cuyahogalibrary.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42500 --- Comment #27 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 206935 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206935&action=edit Bug 42500: Add Koha::Holds->hold_ratios method This moves the hold ratios aggregation out of the REST controller into a Koha::Holds->hold_ratios class method so it can be unit tested directly. The ratio is computed in SQL and filtered with a HAVING clause, so the database returns only the qualifying biblios and the report can be paginated. The method returns the holds and items counts, the ratio, the number of copies to buy and the library, item type and authorised value codes of the biblio's items, along with the total number of qualifying biblios. Resolving the codes to names is left to the caller. Signed-off-by: Kristi Krueger <KKRUEGER@cuyahogalibrary.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42500 --- Comment #29 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 206937 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206937&action=edit Bug 42500: Add REST API for hold ratios The hold ratios page ( reserveratios.pl ) builds its entire result set in Perl and renders every matching row, which is a pain point for larger systems with many holds. This patch adds a /holds/ratios REST endpoint so the page can fetch the data and paginate it. The hold ratio is computed in SQL and the ratio threshold is applied as a HAVING clause, so the database returns only the biblios that meet the ratio and the endpoint returns one page at a time instead of the whole set. Each row carries the computed holds_count, items_count, hold_ratio, copies_to_buy and the count of copies still on order, along with the home and holding libraries, locations, item types, collections and call numbers of the biblio's items. The old page adjusted the item count when it was reached from an acquisitions basket that creates items on receiving. That adjustment is dropped here; the pending order count is still returned separately. Test Plan: 1) Apply this patch 2) Restart all the things! 3) Place several holds on a biblio that has fewer items than holds 4) curl the endpoint as a librarian with circulate permission: curl -s -u koha:koha "http://localhost:8081/api/v1/holds/ratios?ratio=1" | json_pp 5) Note the biblio is returned with its hold ratio, items needed and item details! 6) Try ratio=99, note the biblio is filtered out! Signed-off-by: Kristi Krueger <KKRUEGER@cuyahogalibrary.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42500 --- Comment #31 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 206939 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206939&action=edit Bug 42500: Add unit tests REST API endpoint list_ratios Signed-off-by: Kristi Krueger <KKRUEGER@cuyahogalibrary.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42500 --- Comment #33 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 206941 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206941&action=edit Bug 42500: Count itemless pending orders in hold ratios Signed-off-by: Kristi Krueger <KKRUEGER@cuyahogalibrary.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42500 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@openfifth.c |y.org |o.uk -- You are receiving this mail because: You are watching all bug changes.