https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42500 --- Comment #24 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Updated test plan: Test Plan: 1) Apply this patch 2) Restart all the things! 3) Place several holds on a biblio with fewer items than holds 4) Go to Circulation -> Hold ratios 5) Note the biblio is listed with its hold ratio, libraries, item types and items needed! 6) Change the hold ratio filter and the dates, click Go 7) Note the list updates to match! 8) Sort by Holds, Items, Hold ratio and Items needed 9) Note the sorting works across pages! 10) Suspend some holds. Confirm suspended holds are not counted unless "Include suspended" is checked 11) Edit an item to set the not for loan value to a negative number. Confirm the item is not counted unless "Include ordered" is checked 12) Create a basket set to create items when placing an order. Place an order, make sure the item that is created has its not for loan value set to a negative value. Confirm the order and item are not counted unless "Include ordered" is checked. Confirm the item and order and never both counted. 13) Create a basket set to create items when receiving an order. Place an order. Confirm the order is not counted unless "Include ordered" is checked. 14) Create a basket set to create items when cataloging. Place an order. Confirm the order is not counted unless "Include ordered" is checked. 15) Reach the page by adding to an acquisitions basket with the "From titles with highest hold ratios" option 16) Confirm items/orders are counted consistently regardless of the "Create items when" value of your basket 17) Note the "N to order" button links into a new order! -- You are receiving this mail because: You are watching all bug changes.