https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39517 --- Comment #1 from Janusz Kaczmarek <januszop@gmail.com> --- Created attachment 180229 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180229&action=edit Bug 39517: Make LDR/6-7 = 'am' be interpreted by MARC21slim2OPACDetail.xsl as 'Book' instead of more generic 'Text' Currently, in OPAC, MARC21slim2OPACDetail.xsl assigns to LDR/6-7 = 'am' a label 'Text' (materialTypeLabel), which is then used in defining variable schemaOrgType and also for display. The variable schemaOrgType would be set to 'Book' if materialTypeLabel was 'Book', but with the current xslt code never will be. Instead schemaOrgType will be set to a generic type CreativeWork for 'am'. materialTypeLabel is also used for display purposes as the label next to the material type icon (when DisplayOPACiconsXSLT enabled). Test plan: ========== 1. Make sure that DisplayOPACiconsXSLT is on. 2. In OPAC open any book record (e.g. in standard ktd - sn:1). 3. Note "Material type: [icon] Text" info below author line. 4. Apply the patch ; restart_all 5. Verify that you get "Material type: [icon] Book" info below author line. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39517 Roman Dolny <roman.dolny@jezuici.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39517 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion CC| |dcook@prosentient.com.au --- Comment #3 from David Cook <dcook@prosentient.com.au> --- There's no guarantee that it's a book. It could be an electronic resource, it could be a report, research study, a pamphlet, a thesis, a play, etc. -- 06 - Type of record a - Language material Used for non-manuscript language material. Manuscript language material uses code t. Includes microforms and electronic resources that are basically textual in nature, whether they are reproductions from print or originally produced. -- 07 - Bibliographic level m - Monograph/Item Item either complete in one part (e.g., a single monograph, a single map, a single manuscript, etc.) or intended to be completed, in a finite number of separate parts (e.g., a multivolume monograph, a sound recording with multiple tracks, etc.). -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39517 --- Comment #4 from Janusz Kaczmarek <januszop@gmail.com> --- Created attachment 192862 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192862&action=edit Bug 39517: Make books be interpreted by MARC21slim2OPACDetail.xsl as 'Book' instead of more generic 'Text' Currently, in OPAC, MARC21slim2OPACDetail.xsl assigns to LDR/6-7 = 'am' a label 'Text' (materialTypeLabel), which is then used in defining variable schemaOrgType and also for display. The variable schemaOrgType would be set to 'Book' if materialTypeLabel was 'Book', but with the current xslt code never will be. Instead schemaOrgType will be set to a generic type CreativeWork for 'am'. materialTypeLabel is also used for display purposes as the label next to the material type icon (when DisplayOPACiconsXSLT enabled). Test plan: ========== 1. Make sure that DisplayOPACiconsXSLT is on. 2. In OPAC open any biblio record (e.g. in standard ktd - sn:1). 3. Note "Material type: [icon] Text" info below author line. 4. Edit the record, setting LDR/6-7 = 'am', 008/24-27 (Nature of contents)=' ' (for No specified nature of contents), and 008/33 (Literary form)='1' (fiction). 5. Note that the info "Material type: [icon] Text" has not changed. 6. Apply the patch ; restart_all 7. Verify that you get "Material type: [icon] Book" info below author line. You can also check in browser dev tools that 'typeof' in schema.org div is set to Book now. 8. Edit the record, 008/24-27='j ' (Patent document), and 008/33='|' (No attempt to code). 9. Verify that you get "Material type: [icon] Text" info below author line. Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39517 --- Comment #5 from Janusz Kaczmarek <januszop@gmail.com> --- (In reply to David Cook from comment #3)

There's no guarantee that it's a book. It could be an electronic resource, it could be a report, research study, a pamphlet, a thesis, a play, etc.

It seems that it is not so obvious what should be included in the "Book" category. Here is another, more rigorous (perhaps too rigorous) attempt, based on the nature of the content and literary form from field 008. (BTW, an e-book is still a book). Ultimately, if we cannot agree on what a book is, we should remove the "Book" category from the schema.org options in the XSLT stylesheet. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39517 --- Comment #6 from David Cook <dcook@prosentient.com.au> --- (In reply to Janusz Kaczmarek from comment #5)

(In reply to David Cook from comment #3)

...

There's no guarantee that it's a book. It could be an electronic resource, it could be a report, research study, a pamphlet, a thesis, a play, etc.

It seems that it is not so obvious what should be included in the "Book" category. Here is another, more rigorous (perhaps too rigorous) attempt, based on the nature of the content and literary form from field 008. (BTW, an e-book is still a book).

I'm not sure I understand this one. If 24-27 Nature of contents is "No specified nature of contents" and 34 Biographic is "No attempt to code", then it's a book?

Ultimately, if we cannot agree on what a book is, we should remove the "Book" category from the schema.org options in the XSLT stylesheet.

Yeah not a bad idea... -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39517 Michael Skarupianski <michael.skarupianski@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |michael.skarupianski@gmail. | |com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39517 --- Comment #8 from Michael Skarupianski <michael.skarupianski@gmail.com> --- Created attachment 196107 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196107&action=edit Bug 39517: Make books be interpreted by MARC21slim2OPACDetail.xsl as 'Book' instead of more generic 'Text' Currently, in OPAC, MARC21slim2OPACDetail.xsl assigns to LDR/6-7 = 'am' a label 'Text' (materialTypeLabel), which is then used in defining variable schemaOrgType and also for display. The variable schemaOrgType would be set to 'Book' if materialTypeLabel was 'Book', but with the current xslt code never will be. Instead schemaOrgType will be set to a generic type CreativeWork for 'am'. materialTypeLabel is also used for display purposes as the label next to the material type icon (when DisplayOPACiconsXSLT enabled). Test plan: ========== 1. Make sure that DisplayOPACiconsXSLT is on. 2. In OPAC open any biblio record (e.g. in standard ktd - sn:1). 3. Note "Material type: [icon] Text" info below author line. 4. Edit the record, setting LDR/6-7 = 'am', 008/24-27 (Nature of contents)=' ' (for No specified nature of contents), and 008/33 (Literary form)='1' (fiction). 5. Note that the info "Material type: [icon] Text" has not changed. 6. Apply the patch ; restart_all 7. Verify that you get "Material type: [icon] Book" info below author line. You can also check in browser dev tools that 'typeof' in schema.org div is set to Book now. 8. Edit the record, 008/24-27='j ' (Patent document), and 008/33='|' (No attempt to code). 9. Verify that you get "Material type: [icon] Text" info below author line. Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: Michael Skarupianski <michael.skarupianski@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39517 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | CC| |m.de.rooy@rijksmuseum.nl --- Comment #9 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Trivial, but still triggering questions: + <xsl:when test="$leader7='m' and substring($controlField008,25,4)=' ' and substring($controlField008,34,1)!='|'">Book</xsl:when> LOC: The definition of field 008 character positions 18-34 varies according to the Type of record code in Leader/06 and Bibliographic level code in Leader/07. Wondering if the combination of in leader6 and m in leader7 is not enough to classify it as a "book" ? You check 25 but did you mean 24? 24-27 - Nature of contents # - No specified nature of contents What about | - No attempt to code ? Does it matter here btw? 33 - Literary form (006/16) 34 - Biography (006/17) You check 34, but did you mean 33 ? Does it actually matter here? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39517 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think we had moved from "book" to "text" in the past, because we weren't able to be more specific and it caused confusion/wrong entries. I am not sure if it's possible to really make sure it's a book with the data we have. -- You are receiving this mail because: You are watching all bug changes.