[Bug 39955] New: Report subgroup filter not cleared when changing tabs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39955 Bug ID: 39955 Summary: Report subgroup filter not cleared when changing tabs Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Reports Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org There is an error in the way saved SQL report subgroups behave when you change tabs: The subgroup filter gets applied to the new tab too. Since subgroup codes are unique, this means the all the reports under the tab you switched to are filtered out. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39955 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39955 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39955 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 182695 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182695&action=edit Bug 39955: Report subgroup filter not cleared when changing tabs This patch fixes the JS on the saved SQL reports page so that the subgroup column filter is correctly cleared when the tab changes. The wrong table column is targeted. To test, apply the patch and go to Reports -> Saved SQL reports. - If necessary, at least two SQL reports, each with in a different group and different subgroup. For example: - sql: SELECT * FROM items LIMIT 10; - group: Catalog - subgroup: Statistics ...and... - sql: SELECT * FROM borrowers LIMIT 10; - group: Patrons - subgroup: Statistics - From the saved reports page, go to the tab for one of your reports and filter by subgroup. - Switch to a different tab containing SQL reports. The reports should be shown as expected. Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39955 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |39534 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39534 [Bug 39534] Saved report subgroup filter not hidden correctly -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39955 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182695|0 |1 is obsolete| | --- Comment #2 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 182715 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182715&action=edit Bug 39955: Report subgroup filter not cleared when changing tabs This patch fixes the JS on the saved SQL reports page so that the subgroup column filter is correctly cleared when the tab changes. The wrong table column is targeted. To test, apply the patch and go to Reports -> Saved SQL reports. - If necessary, at least two SQL reports, each with in a different group and different subgroup. For example: - sql: SELECT * FROM items LIMIT 10; - group: Catalog - subgroup: Statistics ...and... - sql: SELECT * FROM borrowers LIMIT 10; - group: Patrons - subgroup: Statistics - From the saved reports page, go to the tab for one of your reports and filter by subgroup. - Switch to a different tab containing SQL reports. The reports should be shown as expected. Sponsored-by: Athens County Public Libraries Signed-off-by: Anneli Österman <anneli.osterman@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39955 Anneli Österman <anneli.osterman@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |anneli.osterman@koha-suomi. | |fi Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39955 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182715|0 |1 is obsolete| | --- Comment #3 from Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> --- Created attachment 182850 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182850&action=edit Bug 39955: Report subgroup filter not cleared when changing tabs This patch fixes the JS on the saved SQL reports page so that the subgroup column filter is correctly cleared when the tab changes. The wrong table column is targeted. To test, apply the patch and go to Reports -> Saved SQL reports. - If necessary, at least two SQL reports, each with in a different group and different subgroup. For example: - sql: SELECT * FROM items LIMIT 10; - group: Catalog - subgroup: Statistics ...and... - sql: SELECT * FROM borrowers LIMIT 10; - group: Patrons - subgroup: Statistics - From the saved reports page, go to the tab for one of your reports and filter by subgroup. - Switch to a different tab containing SQL reports. The reports should be shown as expected. Sponsored-by: Athens County Public Libraries Signed-off-by: Anneli Österman <anneli.osterman@koha-suomi.fi> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39955 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emily.lamancusa@montgomeryc | |ountymd.gov QA Contact|testopia@bugs.koha-communit |emily.lamancusa@montgomeryc |y.org |ountymd.gov Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39955 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39955 --- Comment #4 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39955 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|25.11.00 |25.11.00,25.05.01 released in| | CC| |fridolin.somers@biblibre.co | |m Status|Pushed to main |Pushed to stable --- Comment #5 from Fridolin Somers <fridolin.somers@biblibre.com> --- I see in 25.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39955 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|25.11.00,25.05.01 |25.11.00,25.05.01,24.11.06 released in| | Status|Pushed to stable |Pushed to oldstable --- Comment #6 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 24.11.x for 24.11.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39955 --- Comment #7 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Nice work everyone! Pushed to 25.05.x for 25.05.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39955 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Text to go in the| |This fixes the display of release notes| |saved reports in reports | |tabs when subgroups and | |filtering are used. | |Previously, if you used | |filters for subgroups and | |then changed tabs, the | |subgroup filter was not | |cleared - resulting in | |reports not showing. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39955 Jesse Maseto <jesse@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jesse@bywatersolutions.com --- Comment #8 from Jesse Maseto <jesse@bywatersolutions.com> --- Merge conflicts with 24.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39955 --- Comment #9 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Jesse Maseto from comment #8)
Merge conflicts with 24.05.x
I don't think bug exists in 24.05.x I believe it was caused by Bug 36640. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39955 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Needs documenting CC| |wainuiwitikapark@catalyst.n | |et.nz --- Comment #10 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11.x as it wasn't backported to 24.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39955 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED --- Comment #11 from David Nind <david@davidnind.com> --- Bug fix, no changes to the manual required. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org