[Bug 15354] New: item types aren't showing in default hold policies
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15354 Bug ID: 15354 Summary: item types aren't showing in default hold policies Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: nengard@gmail.com QA Contact: testopia@bugs.koha-community.org Created attachment 45609 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45609&action=edit default hold policies See attached. The data is in the database, but the item type is not showing. I'm not sure if this is just my system or if it's all systems. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15354 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org, | |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15354 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |jonathan.druart@bugs.koha-c | |ommunity.org Depends on| |14100 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14100 [Bug 14100] Add base to make item types, branch names, sysprefs values and authorised values translatable -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15354 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15354 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 45632 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45632&action=edit Bug 15354: Fix translted itemtype description In bug 14100, the admin/smart-rules.pl needed much more love. Indeed, the translated_description string should be used everywhere and replaced the previous 'humanitemtype'. Test plan: 1/ Translate some item types. 2/ Define some holds policy using these item types. 3/ Update the template strings 4/ Confirm that the "holds policy by item type" are displayed (for the default and specific library) and sorted by translated item type descriptions. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15354 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45632|0 |1 is obsolete| | --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 45633 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45633&action=edit Bug 15354: Fix translated itemtype descriptions in circ rules In bug 14100, the admin/smart-rules.pl needed much more love. Indeed, the translated_description string should be used everywhere and replaced the previous 'humanitemtype'. Test plan: 1/ Translate some item types. 2/ Define some holds policy using these item types. 3/ Update the template strings 4/ Confirm that the "holds policy by item type" are displayed (for the default and specific library) and sorted by translated item type descriptions. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15354 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15354 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45633|0 |1 is obsolete| | --- Comment #3 from Frédéric Demians <frederic@tamil.fr> --- Created attachment 45716 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45716&action=edit Bug 15354: Fix translated itemtype descriptions in circ rules In bug 14100, the admin/smart-rules.pl needed much more love. Indeed, the translated_description string should be used everywhere and replaced the previous 'humanitemtype'. Test plan: 1/ Translate some item types. 2/ Define some holds policy using these item types. 3/ Update the template strings 4/ Confirm that the "holds policy by item type" are displayed (for the default and specific library) and sorted by translated item type descriptions. Signed-off-by: Frédéric Demians <f.demians@tamil.fr> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15354 Jesse Weaver <jweaver@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jweaver@bywatersolutions.co | |m --- Comment #4 from Jesse Weaver <jweaver@bywatersolutions.com> --- Minor whitespace issues: FAIL koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt FAIL forbidden patterns forbidden pattern: tab char (line 188) SKIP spelling OK tt_valid OK valid_template (These aren't really your fault; I put a patch to fix all this mess on bug 15456 that you can rebase onto if you'd prefer.) More importantly, though, I noticed that while the item type descriptions now correctly show, and the list of rules is sorted by the translated description, the item type selection dropdown is not sorted by the translated description. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15354 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15354 --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 46222 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46222&action=edit Bug 15354: Sort itemtypes by translated description everywhere on circ rules admin page It's better to cmp on lc. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15354 --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Jesse Weaver from comment #4)
Minor whitespace issues:
FAIL koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt FAIL forbidden patterns forbidden pattern: tab char (line 188) SKIP spelling OK tt_valid OK valid_template
(These aren't really your fault; I put a patch to fix all this mess on bug 15456 that you can rebase onto if you'd prefer.)
I think it should be fixed asap and not depend on something else to ease a possible backport.
More importantly, though, I noticed that while the item type descriptions now correctly show, and the list of rules is sorted by the translated description, the item type selection dropdown is not sorted by the translated description.
Good catch. I have fixed it. Not that C4::Koha::GetItemTypes should be fixed for a global fix. It will be easy to do on top of bug 14828. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15354 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15337 --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #6)
Not that C4::Koha::GetItemTypes should be fixed for a global fix. It will be easy to do on top of bug 14828.
Finally done on bug 15337 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15354 Jesse Weaver <jweaver@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15354 Jesse Weaver <jweaver@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45716|0 |1 is obsolete| | --- Comment #8 from Jesse Weaver <jweaver@bywatersolutions.com> --- Created attachment 46281 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46281&action=edit Bug 15354: Fix translated itemtype descriptions in circ rules In bug 14100, the admin/smart-rules.pl needed much more love. Indeed, the translated_description string should be used everywhere and replaced the previous 'humanitemtype'. Test plan: 1/ Translate some item types. 2/ Define some holds policy using these item types. 3/ Update the template strings 4/ Confirm that the "holds policy by item type" are displayed (for the default and specific library) and sorted by translated item type descriptions. Signed-off-by: Frédéric Demians <f.demians@tamil.fr> Signed-off-by: Jesse Weaver <jweaver@bywatersolutions.com> Passes QA tools. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15354 Jesse Weaver <jweaver@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46222|0 |1 is obsolete| | --- Comment #9 from Jesse Weaver <jweaver@bywatersolutions.com> --- Created attachment 46282 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46282&action=edit Bug 15354: Sort itemtypes by translated description everywhere on circ rules admin page It's better to cmp on lc. Signed-off-by: Jesse Weaver <jweaver@bywatersolutions.com> Passes QA tools. Fixes sorting of dropdown for translated itemtype descriptions. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15354 --- Comment #10 from Jesse Weaver <jweaver@bywatersolutions.com> --- Created attachment 46283 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46283&action=edit Bug 15354: (QA followup) remove tab character Signed-off-by: Jesse Weaver <jweaver@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15354 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 46949 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46949&action=edit [PASSED QA] Bug 15354: Fix translated itemtype descriptions in circ rules In bug 14100, the admin/smart-rules.pl needed much more love. Indeed, the translated_description string should be used everywhere and replaced the previous 'humanitemtype'. Test plan: 1/ Translate some item types. 2/ Define some holds policy using these item types. 3/ Update the template strings 4/ Confirm that the "holds policy by item type" are displayed (for the default and specific library) and sorted by translated item type descriptions. Signed-off-by: Frédéric Demians <f.demians@tamil.fr> Signed-off-by: Jesse Weaver <jweaver@bywatersolutions.com> Passes QA tools. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15354 --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 46950 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46950&action=edit [PASSED QA] Bug 15354: Sort itemtypes by translated description everywhere on circ rules admin page It's better to cmp on lc. Signed-off-by: Jesse Weaver <jweaver@bywatersolutions.com> Passes QA tools. Fixes sorting of dropdown for translated itemtype descriptions. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15354 --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 46951 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46951&action=edit [PASSED QA] Bug 15354: (QA followup) remove tab character Signed-off-by: Jesse Weaver <jweaver@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15354 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46281|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15354 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46282|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15354 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46283|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15354 Jesse Weaver <jweaver@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #14 from Jesse Weaver <jweaver@bywatersolutions.com> --- Pushed to master (after Cait added her QA stamp). Thanks for the work! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15354 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |julian.maurice@biblibre.com --- Comment #15 from Julian Maurice <julian.maurice@biblibre.com> --- Patches pushed to 3.22.x, will be in 3.22.2 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org